postgres-xc-committers Mailing List for Postgres-XC

Code-wise this is just reordering and rearrangement of code, so it should
not have any performance impact. But, yes this is going to pave the way for
fast query shipping, where we ship queries directly to datanode, when
coordinator is not required. The pgxc_planner() code as such was a bit
cluttered and was not readable. Hopefully it's better now.

Big blocker is the code in get_plan_nodes and examine_conditions_walker().
That's still something I am trying to understand.

On Thu, Sep 29, 2011 at 4:39 PM, Mason <ma...@us...>wrote:

> On Thu, Sep 29, 2011 at 6:41 AM, Ashutosh Bapat
> <ash...@us...> wrote:
> > Project "Postgres-XC".
> >
> > The branch, master has been updated
> >       via  dfa5b5171b09930bd6f2863bfb13cfd91c000d1f (commit)
> >      from  0dc793a19b61dba2122feb621ca640145cf2828e (commit)
> >
> >
> > - Log -----------------------------------------------------------------
> >
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=dfa5b5171b09930bd6f2863bfb13cfd91c000d1f
> >
> > commit dfa5b5171b09930bd6f2863bfb13cfd91c000d1f
> > Author: Ashutosh Bapat <ash...@en...>
> > Date:   Thu Sep 29 15:59:41 2011 +0530
> >
> >    Modularise pgxc_planner() function. This function first throws error
> for
> >    unsupported statements, then checks if the query can be completely
> shipped to
> >    datanodes (pgxc_fqs_planner()). If the later is not possible and
> coordinator is
> >    needed for evaluation of query, standard_planner() is invoked.
> >    Most of the code in pgxc_planner() is now moved to pgxc_fqs_planner().
> The later
> >    function doesn't plan a query if it needs coordinator for execution of
> query or
> >    the query does not need datanodes for evaluation. If the query can be
> completely
> >    evaluated on datanodes, pgxc_fqs_planner() creates the plan, which
> mostly
> >    contains only RemoteQuery node and ships most of the query to the
> datanode.
> >    EXECUTE DIRECT statements which are to be executed on datanodes, are
> also
> >    directly shipped to the datanode, without involving planner on the
> coordinator.
> >
> > M       src/backend/pgxc/plan/planner.c
> >
>
> This is more similar to how things were a few+ versions ago (back to
> the future).  It may give a small bump in performance. Have you done
> any tests to see if it helps performance for singleton statements?
>
> Thanks,
>
> Mason
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

On Thu, Sep 29, 2011 at 6:41 AM, Ashutosh Bapat
<ash...@us...> wrote:
> Project "Postgres-XC".
>
> The branch, master has been updated
>       via  dfa5b5171b09930bd6f2863bfb13cfd91c000d1f (commit)
>      from  0dc793a19b61dba2122feb621ca640145cf2828e (commit)
>
>
> - Log -----------------------------------------------------------------
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=dfa5b5171b09930bd6f2863bfb13cfd91c000d1f
>
> commit dfa5b5171b09930bd6f2863bfb13cfd91c000d1f
> Author: Ashutosh Bapat <ash...@en...>
> Date:   Thu Sep 29 15:59:41 2011 +0530
>
>    Modularise pgxc_planner() function. This function first throws error for
>    unsupported statements, then checks if the query can be completely shipped to
>    datanodes (pgxc_fqs_planner()). If the later is not possible and coordinator is
>    needed for evaluation of query, standard_planner() is invoked.
>    Most of the code in pgxc_planner() is now moved to pgxc_fqs_planner(). The later
>    function doesn't plan a query if it needs coordinator for execution of query or
>    the query does not need datanodes for evaluation. If the query can be completely
>    evaluated on datanodes, pgxc_fqs_planner() creates the plan, which mostly
>    contains only RemoteQuery node and ships most of the query to the datanode.
>    EXECUTE DIRECT statements which are to be executed on datanodes, are also
>    directly shipped to the datanode, without involving planner on the coordinator.
>
> M       src/backend/pgxc/plan/planner.c
>

This is more similar to how things were a few+ versions ago (back to
the future).  It may give a small bump in performance. Have you done
any tests to see if it helps performance for singleton statements?

Thanks,

Mason

Project "Postgres-XC".

The branch, master has been updated
       via  dfa5b5171b09930bd6f2863bfb13cfd91c000d1f (commit)
      from  0dc793a19b61dba2122feb621ca640145cf2828e (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=dfa5b5171b09930bd6f2863bfb13cfd91c000d1f

commit dfa5b5171b09930bd6f2863bfb13cfd91c000d1f
Author: Ashutosh Bapat <ash...@en...>
Date:   Thu Sep 29 15:59:41 2011 +0530

    Modularise pgxc_planner() function. This function first throws error for
    unsupported statements, then checks if the query can be completely shipped to
    datanodes (pgxc_fqs_planner()). If the later is not possible and coordinator is
    needed for evaluation of query, standard_planner() is invoked.
    Most of the code in pgxc_planner() is now moved to pgxc_fqs_planner(). The later
    function doesn't plan a query if it needs coordinator for execution of query or
    the query does not need datanodes for evaluation. If the query can be completely
    evaluated on datanodes, pgxc_fqs_planner() creates the plan, which mostly
    contains only RemoteQuery node and ships most of the query to the datanode.
    EXECUTE DIRECT statements which are to be executed on datanodes, are also
    directly shipped to the datanode, without involving planner on the coordinator.

M	src/backend/pgxc/plan/planner.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c |  264 +++++++++++++++++++++++++--------------
 1 files changed, 169 insertions(+), 95 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  0dc793a19b61dba2122feb621ca640145cf2828e (commit)
      from  8254e3165c2410f8b1b7490da068194607a67920 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=0dc793a19b61dba2122feb621ca640145cf2828e

commit 0dc793a19b61dba2122feb621ca640145cf2828e
Author: Michael P <mic...@us...>
Date:   Mon Sep 26 12:01:24 2011 +0900

    Fix for regression test stats
    
    INTO clause is not supported yet.

A	src/test/regress/expected/stats_1.out

-----------------------------------------------------------------------

Summary of changes:
 .../regress/expected/{stats.out => stats_1.out}    |   28 +++++++++----------
 1 files changed, 13 insertions(+), 15 deletions(-)
 copy src/test/regress/expected/{stats.out => stats_1.out} (76%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  8254e3165c2410f8b1b7490da068194607a67920 (commit)
      from  be27afbe503de28dffe0392d2fbe71f75a40e614 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=8254e3165c2410f8b1b7490da068194607a67920

commit 8254e3165c2410f8b1b7490da068194607a67920
Author: Michael P <mic...@us...>
Date:   Mon Sep 26 11:21:37 2011 +0900

    Fix for bug 3410137: CREATE TABLE ... LIKE with temp table
    
    Treat correctly table inheritance dependencies between temporary
    and permanent objects by insuring temporary object creation on
    all the nodes. This enforces creation of temporary tables not only
    on all the datanodes but also on coordinators so it increases
    interactions between nodes but this is necessary to keep synchronized
    catalogs for tables.
    
    A test case in regressions is added regarding this particular behavior.

M	src/backend/parser/parse_utilcmd.c
M	src/backend/pgxc/pool/execRemote.c
M	src/backend/pgxc/pool/poolmgr.c
M	src/backend/tcop/utility.c
M	src/test/regress/expected/xc_temp.out
M	src/test/regress/sql/xc_temp.sql

-----------------------------------------------------------------------

Summary of changes:
 src/backend/parser/parse_utilcmd.c    |   11 +++++++
 src/backend/pgxc/pool/execRemote.c    |   10 +++++-
 src/backend/pgxc/pool/poolmgr.c       |   51 ++++++++++++++++++---------------
 src/backend/tcop/utility.c            |   13 ++------
 src/test/regress/expected/xc_temp.out |    4 ++
 src/test/regress/sql/xc_temp.sql      |    5 +++
 6 files changed, 59 insertions(+), 35 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  be27afbe503de28dffe0392d2fbe71f75a40e614 (commit)
      from  94d506c20f962b2a3e5097f87510994de5f358be (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=be27afbe503de28dffe0392d2fbe71f75a40e614

commit be27afbe503de28dffe0392d2fbe71f75a40e614
Author: Michael P <mic...@us...>
Date:   Tue Sep 20 09:02:23 2011 +0900

    Fix documentation typo in pg_ctl
    
    Since merge with PostgreSQL 9.1, pg_ctl uses -Z and not -S when
    starting up a PGXC node.

M	doc-xc/src/sgml/ref/pg_ctl-ref.sgmlin

-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/ref/pg_ctl-ref.sgmlin |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  94d506c20f962b2a3e5097f87510994de5f358be (commit)
      from  1d2801f818da73e0c73be4db281ab96beb628c9d (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=94d506c20f962b2a3e5097f87510994de5f358be

commit 94d506c20f962b2a3e5097f87510994de5f358be
Author: Abbas <abb...@en...>
Date:   Tue Sep 6 19:55:00 2011 +0500

    A few fixes for regression test cases and a variable name change

M	src/backend/pgxc/plan/planner.c
M	src/test/regress/expected/transactions_1.out
R097	src/test/regress/expected/create_misc_1.out	src/test/regress/output/create_misc_1.source
M	src/test/regress/sql/transactions.sql

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c                    |    8 ++++----
 src/test/regress/expected/transactions_1.out       |    4 ++--
 .../create_misc_1.source}                          |    4 ++--
 src/test/regress/sql/transactions.sql              |    4 ++--
 4 files changed, 10 insertions(+), 10 deletions(-)
 rename src/test/regress/{expected/create_misc_1.out => output/create_misc_1.source} (97%)


hooks/post-receive
-- 
Postgres-XC

>
>    In case of tables created with round robin distribution the function
> get_plan_nodes_insert was trying to use an un-initialized local variable
> named constant.
>


Sorry to bring this this late, but we should choose a better variable name
instead of "constant", the name may reflect which/what constant.


>    Added a test case and changed the expected output too
>
> M       src/backend/pgxc/plan/planner.c
> M       src/test/regress/expected/xc_distkey.out
> M       src/test/regress/sql/xc_distkey.sql
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  src/backend/pgxc/plan/planner.c          |    8 +++++---
>  src/test/regress/expected/xc_distkey.out |   12 +++++++++++-
>  src/test/regress/sql/xc_distkey.sql      |    7 +++++++
>  3 files changed, 23 insertions(+), 4 deletions(-)
>
>
> hooks/post-receive
> --
> Postgres-XC
>
>
> ------------------------------------------------------------------------------
> Special Offer -- Download ArcSight Logger for FREE!
> Finally, a world-class log management solution at an even better
> price-free! And you'll get a free "Love Thy Logs" t-shirt when you
> download Logger. Secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsisghtdev2dev
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Project "Postgres-XC".

The branch, master has been updated
       via  1d2801f818da73e0c73be4db281ab96beb628c9d (commit)
      from  76fb1e06d9eef7d0cdb9870b720c8eec10b38865 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=1d2801f818da73e0c73be4db281ab96beb628c9d

commit 1d2801f818da73e0c73be4db281ab96beb628c9d
Author: Abbas <abb...@en...>
Date:   Mon Sep 5 20:46:19 2011 +0500

    In case of tables created with round robin distribution the function get_plan_nodes_insert was trying to use an un-initialized local variable named constant.
    Added a test case and changed the expected output too

M	src/backend/pgxc/plan/planner.c
M	src/test/regress/expected/xc_distkey.out
M	src/test/regress/sql/xc_distkey.sql

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c          |    8 +++++---
 src/test/regress/expected/xc_distkey.out |   12 +++++++++++-
 src/test/regress/sql/xc_distkey.sql      |    7 +++++++
 3 files changed, 23 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  76fb1e06d9eef7d0cdb9870b720c8eec10b38865 (commit)
      from  d661b22a3141d8b92704cc08ee8ba5547d325f4f (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=76fb1e06d9eef7d0cdb9870b720c8eec10b38865

commit 76fb1e06d9eef7d0cdb9870b720c8eec10b38865
Author: Michael P <mic...@us...>
Date:   Fri Sep 2 11:44:25 2011 +0200

    Support for make check
    
    "make check" is a compilation command that can be run to check
    if code has been correctly compiled in the environment.
    For Postgres-XC, this is run on 2 Coordinators and 2 Datanodes
    that are installed on local machine in the temporary repository
    chosen.
    
    Coordinator 1 has data folder data_co1.
    Coordinator 2 has data folder data_co2.
    Datanode 1 has data folder data_dn1.
    Datanode 2 has data folder data_dn2.
    
    The entry port of for regression client that can be customized with
    the option "--port" is Coordinator 1, and all the regressions are made
    from this one to the other remote nodes.
    A configuration with 2 Coordinators is chosen to check that DDL queries
    are correctly run.
    
    "make check" is basically supported by there are still uses with XC itself
    when running a parallel schedule in regressions.

M	src/test/regress/parallel_schedule
M	src/test/regress/pg_regress.c

-----------------------------------------------------------------------

Summary of changes:
 src/test/regress/parallel_schedule |    3 +
 src/test/regress/pg_regress.c      |  679 ++++++++++++++++++++++++++++++++++++
 2 files changed, 682 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "RPM files for Postgres-XC".

The branch, master has been updated
       via  4cdcfa9cbb7502d0cda48d87de5d5fb965f65845 (commit)
      from  c7f8f804718e0e3ec34146ab26e2ca9dc92ddd95 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=4cdcfa9cbb7502d0cda48d87de5d5fb965f65845

commit 4cdcfa9cbb7502d0cda48d87de5d5fb965f65845
Author: Michael P <mic...@us...>
Date:   Thu Sep 1 16:14:22 2011 +0900

    RPM files for Postgres-XC 0.9.5
    
    This commit contains a README for reference,
    The spec and PAM files.

A	pgxc0_9_5/README
A	pgxc0_9_5/postgres-xc.pam
A	pgxc0_9_5/postgres-xc.spec

-----------------------------------------------------------------------

Summary of changes:
 pgxc0_9_5/README           |   39 ++++
 pgxc0_9_5/postgres-xc.pam  |    3 +
 pgxc0_9_5/postgres-xc.spec |  498 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 540 insertions(+), 0 deletions(-)
 create mode 100644 pgxc0_9_5/README
 create mode 100644 pgxc0_9_5/postgres-xc.pam
 create mode 100644 pgxc0_9_5/postgres-xc.spec


hooks/post-receive
-- 
RPM files for Postgres-XC