postgres-xc-committers Mailing List for Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  63fceec5c5e21223c91a0ca94c7832ee2734a137 (commit)
      from  a6bf59fc92023e20bc039fdcf0bf393d60025143 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=63fceec5c5e21223c91a0ca94c7832ee2734a137

commit 63fceec5c5e21223c91a0ca94c7832ee2734a137
Author: Abbas <abb...@en...>
Date:   Tue Apr 24 18:37:49 2012 +0500

    Fix for constraints test case.
    
    The test case was failing for the following reasons
    1. Partition column cannot be updated. Distributed the tables by replication
       to make sure the test case do test constraints.
       Added test test case name in feature request 3520518.
    
    2. There was a problem in function pgxc_node_remote_prepare.
       The function was sending PREPARE TRANSACTION command to the data nodes
       and was checking the response from the data nodes.
       However it was ignoring the fact that the data nodes might have
       responded with ROLLBACK. Even if the data nodes responded with ROLLBACK,
       meaning that the transaction was not prepared, still the coordinator was
       under the impression it got prepared and was trying to commit it.
    
       To solve this problem we have added an option in the system to enable
       response checking in HandleCommandComplete.
       If response checking is enable then the system would compare the response
       with ROLLBACK and if found it would indicate that to the caller.
       The function pgxc_node_remote_prepare would then be able to know ROLLBACK
       was received in response to PREPARE TRANSACTION and would not issue a COMMIT.

M	src/backend/pgxc/pool/execRemote.c
M	src/include/pgxc/pgxcnode.h
M	src/test/regress/input/constraints.source
M	src/test/regress/output/constraints_1.source

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/pool/execRemote.c           |   38 ++++++-
 src/include/pgxc/pgxcnode.h                  |   28 +++++
 src/test/regress/input/constraints.source    |   12 +-
 src/test/regress/output/constraints_1.source |  157 ++++++++++---------------
 4 files changed, 131 insertions(+), 104 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  a6bf59fc92023e20bc039fdcf0bf393d60025143 (commit)
      from  ba13c73845855573c28d16fc4a4d5919b3e0946c (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=a6bf59fc92023e20bc039fdcf0bf393d60025143

commit a6bf59fc92023e20bc039fdcf0bf393d60025143
Author: Michael Paquier <mi...@ot...>
Date:   Tue Apr 24 19:53:20 2012 +0900

    Correct regression test tablespace
    
    Its output is generated depending on environment.

R096	src/test/regress/expected/tablespace_1.out	src/test/regress/output/tablespace_1.source

-----------------------------------------------------------------------

Summary of changes:
 .../tablespace_1.source}                           |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 rename src/test/regress/{expected/tablespace_1.out => output/tablespace_1.source} (96%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  ba13c73845855573c28d16fc4a4d5919b3e0946c (commit)
      from  f12afa86e544f581c7c6d7a0fdf02502c4a0aed9 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=ba13c73845855573c28d16fc4a4d5919b3e0946c

commit ba13c73845855573c28d16fc4a4d5919b3e0946c
Author: Michael Paquier <mi...@ot...>
Date:   Tue Apr 24 19:48:41 2012 +0900

    Fix standard remote DML plans using inherited tables
    
    Simple test cases like this one were not possible for 4 reasons:
    create table p1 (f1 int);
    create table c1 (f2 text, f3 int) inherits (p1);
    alter table p1 add column a1 int check (a1 > 0);
    alter table p1 add column f2 text;
    insert into p1 values (1,2,'abc');
    insert into c1 values(11,'xyz',33,22);
    update p1 set a1 = a1 + 1, f2 = upper(f2);
    
    1) When generating a remote DDL query, the parent relation name was
    used instead of the child name.
    2) UPDATE and DELETE did not use ONLY when generating query, causing
    subtables to be deleted or updated twice. Well deletion is not so much
    a problem but UPDATE leaded to inconsistencies for stuff updated like
    "column = column + expression()"
    3) Remote DDL executor was always using the parent plan, leading to
    inconsistencies in parameters pushed down
    4) In query generated for remote UPDATE, the attribute number used was the
    one from target list. In case of parent it is correct, but not always for
    child tables.
    
    This commit fixes some issues in tests alter_table and plpgsql.

M	src/backend/executor/nodeModifyTable.c
M	src/backend/optimizer/plan/createplan.c
M	src/test/regress/expected/xc_FQS_join.out

-----------------------------------------------------------------------

Summary of changes:
 src/backend/executor/nodeModifyTable.c    |   15 +++++++----
 src/backend/optimizer/plan/createplan.c   |   37 +++++++++++++++++-----------
 src/test/regress/expected/xc_FQS_join.out |    8 +++---
 3 files changed, 35 insertions(+), 25 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  f12afa86e544f581c7c6d7a0fdf02502c4a0aed9 (commit)
       via  fcf60e947d785e0f2be79840e096cb18bcbd34b4 (commit)
      from  a127a85b198ecfb37f4530a804781c0e15ff50d2 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=f12afa86e544f581c7c6d7a0fdf02502c4a0aed9

commit f12afa86e544f581c7c6d7a0fdf02502c4a0aed9
Author: Ashutosh Bapat <ash...@en...>
Date:   Tue Apr 24 15:18:31 2012 +0530

    Updates using views or those involving inheritance may cause an error because
    the row marks for them are not available at the coordinator. These errors
    will not be fixed in this release. Hence add alternate output file rules_1.out
    to pass the regression.

A	src/test/regress/expected/rules_1.out

http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=fcf60e947d785e0f2be79840e096cb18bcbd34b4

commit f12afa86e544f581c7c6d7a0fdf02502c4a0aed9
Author: Ashutosh Bapat <ash...@en...>
Date:   Tue Apr 24 15:18:31 2012 +0530

    Updates using views or those involving inheritance may cause an error because
    the row marks for them are not available at the coordinator. These errors
    will not be fixed in this release. Hence add alternate output file rules_1.out
    to pass the regression.

A	src/test/regress/expected/rules_1.out

-----------------------------------------------------------------------

Summary of changes:
 src/test/regress/expected/rules.out                |   27 ++++++------
 .../regress/expected/{rules.out => rules_1.out}    |   43 +++++++++++--------
 src/test/regress/serial_schedule                   |    1 -
 src/test/regress/sql/rules.sql                     |   24 +++++-----
 4 files changed, 51 insertions(+), 44 deletions(-)
 copy src/test/regress/expected/{rules.out => rules_1.out} (98%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  a127a85b198ecfb37f4530a804781c0e15ff50d2 (commit)
      from  81d571c54c11d946aa67fea2804dadf654432d01 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=a127a85b198ecfb37f4530a804781c0e15ff50d2

commit a127a85b198ecfb37f4530a804781c0e15ff50d2
Author: Ashutosh Bapat <ash...@en...>
Date:   Tue Apr 24 12:40:12 2012 +0530

    Revert "Alternative regression output for test inherit"
    
    This reverts commit dfda23e7547f457e15d79054f81d30e826faeecf, which added the
    queries which used 'table name'::regclass instead of tablename.tableoid. These
    two things are not the same and hence the new set of queries added does not
    server the same purpose as old queries. Hence reverting the commit.
    
    Conflicts:
    
    	src/test/regress/expected/inherit_1.out

D	src/test/regress/expected/inherit_1.out
M	src/test/regress/sql/inherit.sql

-----------------------------------------------------------------------

Summary of changes:
 src/test/regress/expected/inherit_1.out | 1355 -------------------------------
 src/test/regress/sql/inherit.sql        |   45 -
 2 files changed, 0 insertions(+), 1400 deletions(-)
 delete mode 100644 src/test/regress/expected/inherit_1.out


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  81d571c54c11d946aa67fea2804dadf654432d01 (commit)
      from  2cd592680ce90e91776f1452d277af888670d71a (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=81d571c54c11d946aa67fea2804dadf654432d01

commit 81d571c54c11d946aa67fea2804dadf654432d01
Author: Amit Khandekar <ami...@en...>
Date:   Tue Apr 24 11:36:28 2012 +0530

    Block create-table-as-execute syntax because we do not support this yet.
    And add prepare_1.out and wthout_oid_1.out to accommodate the diffs caused
    by this feature restriction.
    
    without_1.out also has another diff accommodated :
    SELECT min(relpages) < max(relpages), min(reltuples) - max(reltuples)
      FROM pg_class
    The relpages in XC does not reflect the data stored in datanodes. So it is
    always 0. So min(relpages) < max(relpages) returns false in XC, whereas it
    returns true in PG. There's nothing much we can do about it. So added this
    diff in without_1.out.

M	src/backend/parser/gram.y
A	src/test/regress/expected/prepare_1.out
A	src/test/regress/expected/tablespace_1.out
A	src/test/regress/expected/without_oid_1.out

-----------------------------------------------------------------------

Summary of changes:
 src/backend/parser/gram.y                          |    5 ++++
 .../expected/{prepare.out => prepare_1.out}        |   24 +++----------------
 .../tablespace_1.out}                              |   13 +++++-----
 .../{without_oid.out => without_oid_1.out}         |   18 ++++++++------
 4 files changed, 25 insertions(+), 35 deletions(-)
 copy src/test/regress/expected/{prepare.out => prepare_1.out} (78%)
 copy src/test/regress/{output/tablespace.source => expected/tablespace_1.out} (92%)
 copy src/test/regress/expected/{without_oid.out => without_oid_1.out} (88%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  2cd592680ce90e91776f1452d277af888670d71a (commit)
      from  06928f2a3493248f6b6564a010c6304bd75cb41d (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=2cd592680ce90e91776f1452d277af888670d71a

commit 2cd592680ce90e91776f1452d277af888670d71a
Author: Michael Paquier <mi...@ot...>
Date:   Tue Apr 24 14:45:18 2012 +0900

    Fix crash in remote UPDATE planning due to a list moving to next element
    with lnext in foreach loop.
    This was not spotted by regressions.

M	src/backend/optimizer/plan/createplan.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/optimizer/plan/createplan.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  06928f2a3493248f6b6564a010c6304bd75cb41d (commit)
      from  cea3d90164373a4b86018563390ec9c024f2f972 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=06928f2a3493248f6b6564a010c6304bd75cb41d

commit 06928f2a3493248f6b6564a010c6304bd75cb41d
Author: Amit Khandekar <ami...@en...>
Date:   Tue Apr 24 09:52:31 2012 +0530

    While generating create-table query for CTAS, include all reloptions as well.
    
    The issue was, when WITH OIDS exists in create-table-as-select type of stmt, the
    oids are not created on datanodes. This happens because the deparsed
    create-table query generated for datanodes does not include WITH OIDS. So this
    fix generates all reloptions that are supplied by the user into the deparsed
    query.

M	src/backend/utils/adt/ruleutils.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/utils/adt/ruleutils.c |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  cea3d90164373a4b86018563390ec9c024f2f972 (commit)
      from  15e875d0d72a5d8a378e6d7cdf1266c8f6453c28 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=cea3d90164373a4b86018563390ec9c024f2f972

commit cea3d90164373a4b86018563390ec9c024f2f972
Author: Amit Khandekar <ami...@en...>
Date:   Tue Apr 24 09:50:57 2012 +0530

    pg_regress: with.sql :
    1. In WITH statements, the RETURNING clause *inside* WITH clause did not get
       identified as having RETURNING clause in the main query, these statements
       produce unexpected results instead of erroring out. So, added "RETURNING
       not supported" restriction in addRangeTableEntryForCTE().
    2. Addeded ORDER BY clauses in the plain select statements in the with.sql.
    3. Adjusted expected file to accommodate above changes.

M	src/backend/parser/parse_relation.c
M	src/test/regress/expected/with.out
M	src/test/regress/sql/with.sql

-----------------------------------------------------------------------

Summary of changes:
 src/backend/parser/parse_relation.c |    7 +
 src/test/regress/expected/with.out  |  656 ++++++++++-------------------------
 src/test/regress/sql/with.sql       |   46 ++--
 3 files changed, 207 insertions(+), 502 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  15e875d0d72a5d8a378e6d7cdf1266c8f6453c28 (commit)
      from  739e32b0097cc63bb3c066c0daf08150a916b5c7 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=15e875d0d72a5d8a378e6d7cdf1266c8f6453c28

commit 15e875d0d72a5d8a378e6d7cdf1266c8f6453c28
Author: Michael Paquier <mi...@ot...>
Date:   Tue Apr 24 13:21:42 2012 +0900

    Fix for remote UPDATE planning with inherited relations
    
    This fix permits adds an additional scan on RowMarks regarding
    entries whose parent target entry is different than the child one.
    With this fix, the test case rules in now bug-free.

M	src/backend/optimizer/plan/createplan.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/optimizer/plan/createplan.c |   28 +++++++++++++++++++---------
 1 files changed, 19 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  739e32b0097cc63bb3c066c0daf08150a916b5c7 (commit)
      from  eedafabec0a0ca8700c2f6b6d07e0648d1815531 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=739e32b0097cc63bb3c066c0daf08150a916b5c7

commit 739e32b0097cc63bb3c066c0daf08150a916b5c7
Author: Michael Paquier <mi...@ot...>
Date:   Tue Apr 24 10:01:08 2012 +0900

    Support for TAB completion with XC queries in psql
    
    The new commands recognized are CREATE/ALTER/DROP NODE/NODE GROUP,
    CLEAN CONNECTION, EXECUTE DIRECT.
    Patch by Koichi Suzuki

M	src/bin/psql/tab-complete.c

-----------------------------------------------------------------------

Summary of changes:
 src/bin/psql/tab-complete.c |  203 +++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 203 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Postgres-XC