postgres-xc-committers Mailing List for Postgres-XC

On Thu, Mar 22, 2012 at 5:36 PM, Koichi Suzuki <koi...@gm...> wrote:

> Difference in conversion of floating number affects the last digits.
> Our case is caused by this (and by internal module from PostgreSQL).
>  Conversion tool place at the datanode and sent to the coordinator in
> a text format with different precision (last digit was affected by
> this).
>
>
Suzuki-san,
This is different thread. This one is related to new GUCs added for fast
query shipping. Probably you want to reply to aggregates thread :)


> Regards;
> ----------
> Koichi Suzuki
>
>
>
> 2012年3月22日19:51 Ahsan Hadi <ahs...@en...>:
> >
> >
> > On Thu, Mar 22, 2012 at 10:16 AM, Koichi Suzuki <koi...@gm...>
> > wrote:
> >>
> >> We can comment why XC changed .out file to .sql file.    Or, we can
> >> change the file name to *_xc.out to indicate that there's some change
> >> in XC for some reason.
> >
> >
> > Since this output will always be same on XC why don't we consider
> changing
> > the rangefuncs.out instead of creating alternative expected output files.
> > Creating alternative expected output files can cause a confusion or
> sometime
> > cause a bug to be pushed under the rug so it will be better to avoid
> > alternative output file as much as possible.
> >
> >>
> >> Regards;
> >> ----------
> >> Koichi Suzuki
> >>
> >>
> >>
> >> 2012年3月22日14:02 Ashutosh Bapat <ash...@en...>:
> >> >
> >> >
> >> > On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier
> >> > <mic...@gm...> wrote:
> >> >>
> >> >>
> >> >>
> >> >> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat
> >> >> <ash...@en...> wrote:
> >> >>>
> >> >>> Hi Michael,
> >> >>> Is the only difference between rangefuncs.out and rangefuncs_1.out
> the
> >> >>> new GUCs added?
> >> >>
> >> >> Yes, there are some enable_*fqs* parameters that are exclusively XC
> >> >> related.
> >> >>
> >> >>>
> >> >>> In that case it might be better to change rangefuncs.out itself,
> >> >>> rather
> >> >>> than creating the alternate output file, since that's the expected
> >> >>> output in
> >> >>> XC.
> >> >>
> >> >> We discussed about that a long time ago and it was decided to create
> >> >> alternative output results to limit the possible interactions of our
> >> >> code
> >> >> with Postgres itself.
> >> >
> >> >
> >> > I am not sure about this conclusion. We have been changing the sql and
> >> > out
> >> > files in some cases. I think, it needs to be handled on case by case
> >> > basis.
> >> > When there is a feature blocked and the outputs differ, we should
> create
> >> > an
> >> > alternate output file. When the diff is inherent to XC, we should
> change
> >> > the
> >> > output. In this particular case, we are not going to take out those
> >> > GUCs, so
> >> > the output is going to have those GUCs there. There is not reason to
> not
> >> > change the output file. Having alternate output file creates confusion
> >> > as to
> >> > which of the outputs are correct. FAILure of a testcase with alternate
> >> > output depends upon the diff between the alternate outputs. So, we
> >> > should
> >> > avoid alternate outputs as much as well as think about the merge of
> >> > testcases and outputs. So, we need a balance in both the approaches.
> >> >
> >> >>
> >> >> --
> >> >> Michael Paquier
> >> >> http://michael.otacoo.com
> >> >
> >> >
> >> >
> >> >
> >> > --
> >> > Best Wishes,
> >> > Ashutosh Bapat
> >> > EntepriseDB Corporation
> >> > The Enterprise Postgres Company
> >> >
> >> >
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > This SF email is sponsosred by:
> >> > Try Windows Azure free for 90 days Click Here
> >> > http://p.sf.net/sfu/sfd2d-msazure
> >> > _______________________________________________
> >> > Postgres-xc-committers mailing list
> >> > Pos...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
> >> >
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> This SF email is sponsosred by:
> >> Try Windows Azure free for 90 days Click Here
> >> http://p.sf.net/sfu/sfd2d-msazure
> >> _______________________________________________
> >> Postgres-xc-committers mailing list
> >> Pos...@li...
> >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
> >
> >
> >
> >
> > --
> > Ahsan Hadi
> > Snr Director Product Development
> > EnterpriseDB Corporation
> > The Enterprise Postgres Company
> >
> > Phone: +92-51-8358874
> > Mobile: +92-333-5162114
> >
> > Website: www.enterprisedb.com
> > EnterpriseDB Blog: http://blogs.enterprisedb.com/
> > Follow us on Twitter: http://www.twitter.com/enterprisedb
> >
> > This e-mail message (and any attachment) is intended for the use of the
> > individual or entity to whom it is addressed. This message contains
> > information from EnterpriseDB Corporation that may be privileged,
> > confidential, or exempt from disclosure under applicable law. If you are
> not
> > the intended recipient or authorized to receive this for the intended
> > recipient, any use, dissemination, distribution, retention, archiving, or
> > copying of this communication is strictly prohibited. If you have
> received
> > this e-mail in error, please notify the sender immediately by reply
> e-mail
> > and delete this message.
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Difference in conversion of floating number affects the last digits.
Our case is caused by this (and by internal module from PostgreSQL).
 Conversion tool place at the datanode and sent to the coordinator in
a text format with different precision (last digit was affected by
this).

Regards;
----------
Koichi Suzuki



2012年3月22日19:51 Ahsan Hadi <ahs...@en...>:
>
>
> On Thu, Mar 22, 2012 at 10:16 AM, Koichi Suzuki <koi...@gm...>
> wrote:
>>
>> We can comment why XC changed .out file to .sql file.    Or, we can
>> change the file name to *_xc.out to indicate that there's some change
>> in XC for some reason.
>
>
> Since this output will always be same on XC why don't we consider changing
> the rangefuncs.out instead of creating alternative expected output files.
> Creating alternative expected output files can cause a confusion or sometime
> cause a bug to be pushed under the rug so it will be better to avoid
> alternative output file as much as possible.
>
>>
>> Regards;
>> ----------
>> Koichi Suzuki
>>
>>
>>
>> 2012年3月22日14:02 Ashutosh Bapat <ash...@en...>:
>> >
>> >
>> > On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier
>> > <mic...@gm...> wrote:
>> >>
>> >>
>> >>
>> >> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat
>> >> <ash...@en...> wrote:
>> >>>
>> >>> Hi Michael,
>> >>> Is the only difference between rangefuncs.out and rangefuncs_1.out the
>> >>> new GUCs added?
>> >>
>> >> Yes, there are some enable_*fqs* parameters that are exclusively XC
>> >> related.
>> >>
>> >>>
>> >>> In that case it might be better to change rangefuncs.out itself,
>> >>> rather
>> >>> than creating the alternate output file, since that's the expected
>> >>> output in
>> >>> XC.
>> >>
>> >> We discussed about that a long time ago and it was decided to create
>> >> alternative output results to limit the possible interactions of our
>> >> code
>> >> with Postgres itself.
>> >
>> >
>> > I am not sure about this conclusion. We have been changing the sql and
>> > out
>> > files in some cases. I think, it needs to be handled on case by case
>> > basis.
>> > When there is a feature blocked and the outputs differ, we should create
>> > an
>> > alternate output file. When the diff is inherent to XC, we should change
>> > the
>> > output. In this particular case, we are not going to take out those
>> > GUCs, so
>> > the output is going to have those GUCs there. There is not reason to not
>> > change the output file. Having alternate output file creates confusion
>> > as to
>> > which of the outputs are correct. FAILure of a testcase with alternate
>> > output depends upon the diff between the alternate outputs. So, we
>> > should
>> > avoid alternate outputs as much as well as think about the merge of
>> > testcases and outputs. So, we need a balance in both the approaches.
>> >
>> >>
>> >> --
>> >> Michael Paquier
>> >> http://michael.otacoo.com
>> >
>> >
>> >
>> >
>> > --
>> > Best Wishes,
>> > Ashutosh Bapat
>> > EntepriseDB Corporation
>> > The Enterprise Postgres Company
>> >
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > This SF email is sponsosred by:
>> > Try Windows Azure free for 90 days Click Here
>> > http://p.sf.net/sfu/sfd2d-msazure
>> > _______________________________________________
>> > Postgres-xc-committers mailing list
>> > Pos...@li...
>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> This SF email is sponsosred by:
>> Try Windows Azure free for 90 days Click Here
>> http://p.sf.net/sfu/sfd2d-msazure
>> _______________________________________________
>> Postgres-xc-committers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>
>
>
>
> --
> Ahsan Hadi
> Snr Director Product Development
> EnterpriseDB Corporation
> The Enterprise Postgres Company
>
> Phone: +92-51-8358874
> Mobile: +92-333-5162114
>
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.

On Thu, Mar 22, 2012 at 10:16 AM, Koichi Suzuki <koi...@gm...>wrote:

> We can comment why XC changed .out file to .sql file.    Or, we can
> change the file name to *_xc.out to indicate that there's some change
> in XC for some reason.
>

Since this output will always be same on XC why don't we consider changing
the rangefuncs.out instead of creating alternative expected output files.
Creating alternative expected output files can cause a confusion or
sometime cause a bug to be pushed under the rug so it will be better to
avoid alternative output file as much as possible.


> Regards;
> ----------
> Koichi Suzuki
>
>
>
> 2012年3月22日14:02 Ashutosh Bapat <ash...@en...>:
> >
> >
> > On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier
> > <mic...@gm...> wrote:
> >>
> >>
> >>
> >> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat
> >> <ash...@en...> wrote:
> >>>
> >>> Hi Michael,
> >>> Is the only difference between rangefuncs.out and rangefuncs_1.out the
> >>> new GUCs added?
> >>
> >> Yes, there are some enable_*fqs* parameters that are exclusively XC
> >> related.
> >>
> >>>
> >>> In that case it might be better to change rangefuncs.out itself, rather
> >>> than creating the alternate output file, since that's the expected
> output in
> >>> XC.
> >>
> >> We discussed about that a long time ago and it was decided to create
> >> alternative output results to limit the possible interactions of our
> code
> >> with Postgres itself.
> >
> >
> > I am not sure about this conclusion. We have been changing the sql and
> out
> > files in some cases. I think, it needs to be handled on case by case
> basis.
> > When there is a feature blocked and the outputs differ, we should create
> an
> > alternate output file. When the diff is inherent to XC, we should change
> the
> > output. In this particular case, we are not going to take out those
> GUCs, so
> > the output is going to have those GUCs there. There is not reason to not
> > change the output file. Having alternate output file creates confusion
> as to
> > which of the outputs are correct. FAILure of a testcase with alternate
> > output depends upon the diff between the alternate outputs. So, we should
> > avoid alternate outputs as much as well as think about the merge of
> > testcases and outputs. So, we need a balance in both the approaches.
> >
> >>
> >> --
> >> Michael Paquier
> >> http://michael.otacoo.com
> >
> >
> >
> >
> > --
> > Best Wishes,
> > Ashutosh Bapat
> > EntepriseDB Corporation
> > The Enterprise Postgres Company
> >
> >
> >
> ------------------------------------------------------------------------------
> > This SF email is sponsosred by:
> > Try Windows Azure free for 90 days Click Here
> > http://p.sf.net/sfu/sfd2d-msazure
> > _______________________________________________
> > Postgres-xc-committers mailing list
> > Pos...@li...
> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
> >
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
Ahsan Hadi
Snr Director Product Development
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +92-51-8358874
Mobile: +92-333-5162114

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the
individual or entity to whom it is addressed. This message contains
information from EnterpriseDB Corporation that may be privileged,
confidential, or exempt from disclosure under applicable law. If you are
not the intended recipient or authorized to receive this for the intended
recipient, any use, dissemination, distribution, retention, archiving, or
copying of this communication is strictly prohibited. If you have received
this e-mail in error, please notify the sender immediately by reply e-mail
and delete this message.

Project "Postgres-XC".

The branch, master has been updated
       via  400958d15da435c74bd8e911bf4e3ab530618c9f (commit)
      from  ad4ea5eff4c28ea930f1ab301784d11d5550b3ed (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=400958d15da435c74bd8e911bf4e3ab530618c9f

commit 400958d15da435c74bd8e911bf4e3ab530618c9f
Author: Michael P <mi...@ot...>
Date:   Thu Mar 22 16:27:06 2012 +0900

    Fix a problem regarding obtention of distribution data
    for database relations in XC planner when checking for updates
    on distribution columns.
    
    Some relations like views have no distribution data, so only relations
    whose relkind is a table can be accessed in this case.

M	src/backend/pgxc/plan/planner.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Postgres-XC

We can comment why XC changed .out file to .sql file.    Or, we can
change the file name to *_xc.out to indicate that there's some change
in XC for some reason.

Regards;
----------
Koichi Suzuki



2012年3月22日14:02 Ashutosh Bapat <ash...@en...>:
>
>
> On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier
> <mic...@gm...> wrote:
>>
>>
>>
>> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat
>> <ash...@en...> wrote:
>>>
>>> Hi Michael,
>>> Is the only difference between rangefuncs.out and rangefuncs_1.out the
>>> new GUCs added?
>>
>> Yes, there are some enable_*fqs* parameters that are exclusively XC
>> related.
>>
>>>
>>> In that case it might be better to change rangefuncs.out itself, rather
>>> than creating the alternate output file, since that's the expected output in
>>> XC.
>>
>> We discussed about that a long time ago and it was decided to create
>> alternative output results to limit the possible interactions of our code
>> with Postgres itself.
>
>
> I am not sure about this conclusion. We have been changing the sql and out
> files in some cases. I think, it needs to be handled on case by case basis.
> When there is a feature blocked and the outputs differ, we should create an
> alternate output file. When the diff is inherent to XC, we should change the
> output. In this particular case, we are not going to take out those GUCs, so
> the output is going to have those GUCs there. There is not reason to not
> change the output file. Having alternate output file creates confusion as to
> which of the outputs are correct. FAILure of a testcase with alternate
> output depends upon the diff between the alternate outputs. So, we should
> avoid alternate outputs as much as well as think about the merge of
> testcases and outputs. So, we need a balance in both the approaches.
>
>>
>> --
>> Michael Paquier
>> http://michael.otacoo.com
>
>
>
>
> --
> Best Wishes,
> Ashutosh Bapat
> EntepriseDB Corporation
> The Enterprise Postgres Company
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>

On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier <mic...@gm...
> wrote:

>
>
> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat <
> ash...@en...> wrote:
>
>> Hi Michael,
>> Is the only difference between rangefuncs.out and rangefuncs_1.out the
>> new GUCs added?
>>
> Yes, there are some enable_*fqs* parameters that are exclusively XC
> related.
>
>
>> In that case it might be better to change rangefuncs.out itself, rather
>> than creating the alternate output file, since that's the expected output
>> in XC.
>>
> We discussed about that a long time ago and it was decided to create
> alternative output results to limit the possible interactions of our code
> with Postgres itself.
>

I am not sure about this conclusion. We have been changing the sql and out
files in some cases. I think, it needs to be handled on case by case basis.
When there is a feature blocked and the outputs differ, we should create an
alternate output file. When the diff is inherent to XC, we should change
the output. In this particular case, we are not going to take out those
GUCs, so the output is going to have those GUCs there. There is not reason
to not change the output file. Having alternate output file creates
confusion as to which of the outputs are correct. FAILure of a testcase
with alternate output depends upon the diff between the alternate outputs.
So, we should avoid alternate outputs as much as well as think about the
merge of testcases and outputs. So, we need a balance in both the
approaches.


> --
> Michael Paquier
> http://michael.otacoo.com
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Hi Michael,
Is the only difference between rangefuncs.out and rangefuncs_1.out the new
GUCs added? In that case it might be better to change rangefuncs.out
itself, rather than creating the alternate output file, since that's the
expected output in XC.

On Thu, Mar 22, 2012 at 8:32 AM, Michael Paquier <
mic...@us...> wrote:

> Project "Postgres-XC".
>
> The branch, master has been updated
>       via  ad4ea5eff4c28ea930f1ab301784d11d5550b3ed (commit)
>      from  6086e355914fdebcd2c002d7ee1d3132582a33f9 (commit)
>
>
> - Log -----------------------------------------------------------------
>
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=ad4ea5eff4c28ea930f1ab301784d11d5550b3ed
>
> commit ad4ea5eff4c28ea930f1ab301784d11d5550b3ed
> Author: Michael P <mi...@ot...>
> Date:   Thu Mar 22 12:05:50 2012 +0900
>
>    Fix for regression test rangefuncs
>
>    Some parameters have been added to pg_settings for FQS.
>
> A       src/test/regress/expected/rangefuncs_1.out
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  .../expected/{rangefuncs.out => rangefuncs_1.out}  |   39
> +++++++++-----------
>  1 files changed, 18 insertions(+), 21 deletions(-)
>  copy src/test/regress/expected/{rangefuncs.out => rangefuncs_1.out} (97%)
>
>
> hooks/post-receive
> --
> Postgres-XC
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Project "Postgres-XC".

The branch, master has been updated
       via  ad4ea5eff4c28ea930f1ab301784d11d5550b3ed (commit)
      from  6086e355914fdebcd2c002d7ee1d3132582a33f9 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=ad4ea5eff4c28ea930f1ab301784d11d5550b3ed

commit ad4ea5eff4c28ea930f1ab301784d11d5550b3ed
Author: Michael P <mi...@ot...>
Date:   Thu Mar 22 12:05:50 2012 +0900

    Fix for regression test rangefuncs
    
    Some parameters have been added to pg_settings for FQS.

A	src/test/regress/expected/rangefuncs_1.out

-----------------------------------------------------------------------

Summary of changes:
 .../expected/{rangefuncs.out => rangefuncs_1.out}  |   39 +++++++++-----------
 1 files changed, 18 insertions(+), 21 deletions(-)
 copy src/test/regress/expected/{rangefuncs.out => rangefuncs_1.out} (97%)


hooks/post-receive
-- 
Postgres-XC