postgres-xc-committers Mailing List for Postgres-XC

Hi Michael,
If you would have committed this patch with the patch supporting SERIAL,
DEFAULT it would have been easier to manage. Basically, if it comes to
revert back the code commit, both the code and documentation changes get
reverted at the same time. Otherwise, someone has to find out and revert
the documentation changes separately.

As a thumb-rule we should commit code + documenation + regression changes
for any feature in one go, so that it's easy to locate all of them in one
shot.

On Tue, Feb 21, 2012 at 6:11 AM, Michael Paquier <
mic...@us...> wrote:

> Project "Postgres-XC".
>
> The branch, master has been updated
>       via  5e4102c4406e3f7b1f609ca6f0c6f50e00b5806b (commit)
>      from  9471816d20d41572e014bd795bc49598780c1524 (commit)
>
>
> - Log -----------------------------------------------------------------
>
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=5e4102c4406e3f7b1f609ca6f0c6f50e00b5806b
>
> commit 5e4102c4406e3f7b1f609ca6f0c6f50e00b5806b
> Author: Michael P <mi...@ot...>
> Date:   Tue Feb 21 09:44:33 2012 +0900
>
>    Correct documentation related to SERIAL and DEFAULT values
>
>    Now both functionalities are fully supported.
>
> M       doc-xc/src/sgml/ddl.sgmlin
> M       doc-xc/src/sgml/func.sgmlin
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  doc-xc/src/sgml/ddl.sgmlin  |   15 ---------------
>  doc-xc/src/sgml/func.sgmlin |    5 -----
>  2 files changed, 0 insertions(+), 20 deletions(-)
>
>
> hooks/post-receive
> --
> Postgres-XC
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Project "Postgres-XC".

The branch, master has been updated
       via  5e4102c4406e3f7b1f609ca6f0c6f50e00b5806b (commit)
      from  9471816d20d41572e014bd795bc49598780c1524 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=5e4102c4406e3f7b1f609ca6f0c6f50e00b5806b

commit 5e4102c4406e3f7b1f609ca6f0c6f50e00b5806b
Author: Michael P <mi...@ot...>
Date:   Tue Feb 21 09:44:33 2012 +0900

    Correct documentation related to SERIAL and DEFAULT values
    
    Now both functionalities are fully supported.

M	doc-xc/src/sgml/ddl.sgmlin
M	doc-xc/src/sgml/func.sgmlin

-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/ddl.sgmlin  |   15 ---------------
 doc-xc/src/sgml/func.sgmlin |    5 -----
 2 files changed, 0 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  9471816d20d41572e014bd795bc49598780c1524 (commit)
      from  d09a42f2aac08a909ad9c23b534f11c6e7f16cee (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=9471816d20d41572e014bd795bc49598780c1524

commit 9471816d20d41572e014bd795bc49598780c1524
Author: Michael P <mi...@ot...>
Date:   Tue Feb 21 09:20:30 2012 +0900

    Correct regression test copyselect
    
    The SQL queries used in this test were plain copies so the output could not be
    consistent because of Postgres-XC cluster structure. Such Copy output is now simply
    managed by a SELECT with ORDER BY on serial ID.

A	src/test/regress/expected/copyselect_1.out
M	src/test/regress/sql/copyselect.sql

-----------------------------------------------------------------------

Summary of changes:
 .../expected/{copyselect.out => copyselect_1.out}  |    6 +++---
 src/test/regress/sql/copyselect.sql                |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
 copy src/test/regress/expected/{copyselect.out => copyselect_1.out} (93%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  d09a42f2aac08a909ad9c23b534f11c6e7f16cee (commit)
      from  48719ff5b4ec9dee9857185927db921971259d59 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d09a42f2aac08a909ad9c23b534f11c6e7f16cee

commit d09a42f2aac08a909ad9c23b534f11c6e7f16cee
Author: Michael P <mi...@ot...>
Date:   Tue Feb 21 09:02:04 2012 +0900

    Support for SERIAL types
    
    SERIAL columns in table use default values based on nextval of sequences
    to auto-generate values. In vanilla Postgres, table creation with serial
    column(s) is made with the following process:
    1 - Create sequence(s)
    2 - Create table
    3 - Alter sequence(s) to change it as being owned by the column of table
    previously created to manage object dependency.
    
    In Postgres-XC, the sequence creation is made such as the object is created
    on all the nodes, so a boolean flag associated to the serial process is
    added to bypass sequence creation on remote nodes in case a sequence is created
    within a serial process, and the query sent to remote nodes is the one given
    by client application and it is sent only once when table is created on local
    node.
    
    Regression tests are all updated in consequence.

M	src/backend/commands/copy.c
M	src/backend/parser/gram.y
M	src/backend/parser/parse_utilcmd.c
M	src/backend/tcop/utility.c
M	src/include/nodes/parsenodes.h
M	src/test/regress/expected/cluster_1.out
M	src/test/regress/expected/copy2_1.out
D	src/test/regress/expected/copyselect_1.out
M	src/test/regress/expected/delete_1.out
M	src/test/regress/expected/foreign_data_1.out
M	src/test/regress/expected/functional_deps_1.out
M	src/test/regress/expected/namespace_1.out
M	src/test/regress/expected/returning_1.out
M	src/test/regress/expected/triggers_1.out
M	src/test/regress/expected/truncate_1.out

-----------------------------------------------------------------------

Summary of changes:
 src/backend/commands/copy.c                     |    9 +
 src/backend/parser/gram.y                       |    6 +
 src/backend/parser/parse_utilcmd.c              |   13 +-
 src/backend/tcop/utility.c                      |   32 ++-
 src/include/nodes/parsenodes.h                  |    6 +
 src/test/regress/expected/cluster_1.out         |   35 +--
 src/test/regress/expected/copy2_1.out           |  226 ++++++++++---------
 src/test/regress/expected/copyselect_1.out      |  158 -------------
 src/test/regress/expected/delete_1.out          |   42 ++--
 src/test/regress/expected/foreign_data_1.out    |    4 +-
 src/test/regress/expected/functional_deps_1.out |   16 +-
 src/test/regress/expected/namespace_1.out       |    5 +-
 src/test/regress/expected/returning_1.out       |  281 +++++++++++------------
 src/test/regress/expected/triggers_1.out        |   87 +++-----
 src/test/regress/expected/truncate_1.out        |  179 +++++++--------
 15 files changed, 457 insertions(+), 642 deletions(-)
 delete mode 100644 src/test/regress/expected/copyselect_1.out


hooks/post-receive
-- 
Postgres-XC