postgres-xc-committers Mailing List for Postgres-XC

On Mon, Oct 17, 2011 at 8:04 PM, Ashutosh Bapat <
ash...@en...> wrote:

> Hi All,
> In transformExecDirectStmt() we set sql_statement to NULL.
> 2353     /* Default list of parameters to set */
> 2354     step->is_single_step = true;
> 2355     step->sql_statement = NULL;
> 2356     step->exec_nodes = makeNode(ExecNodes);
> 2357     step->combine_type = COMBINE_TYPE_NONE;
> 2358     step->sort = NULL;
>
> Later in pgxc_planner() we deparse the Query node and build the SQL
> statement. Why don't we use the sql_statement in the Query node itself or
> set RemoteQuery->sql_statement in this function itself? Why do we need to
> deparse it in pgxc_planner()?
>
We do not need to parse the query, sending a raw string is enough. This is
what I could call a bug :)
I haven't been through this code in months, and unfortunately the fixes I
did in this part were kind of made in a hurry, so there may be other issues.
I will try to rework this code by the end of the month if possible as I've
been kept busy now with release stuff, etc.
Regards,
-- 
Michael Paquier
http://michael.otacoo.com