postgres-xc-committers Mailing List for Postgres-XC

Project "Postgres-XC".

The branch, REL0_9_5_STABLE has been updated
       via  9c9346e33d899a9aaebaa1e1a6d5f79bb1d8d49d (commit)
      from  694253102c045e2fc3d145d6718b81b5977004b3 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commit;h=9c9346e33d899a9aaebaa1e1a6d5f79bb1d8d49d

commit 5e13a79645239f25615dfc9ee1d177f44e0bbc09
Author: Michael P <mic...@us...>
Date:   Fri Jul 15 15:30:12 2011 +0900

    Fix for bug 3366724: Autovacuum warning on datanode
    
    This was caused by autovacuum launcher on Datanode.
    As autovacuum is not authorized to get GXID and snapshot from GTM,
    bypass this warning.
    
    Global snapshot is not necessary for launcher as autovacuum analyze and
    worker are in charge of table cleanup.

M	src/backend/storage/ipc/procarray.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/storage/ipc/procarray.c |   19 +++++++++++++------
 1 files changed, 13 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  5e13a79645239f25615dfc9ee1d177f44e0bbc09 (commit)
      from  fb2a3a864dee367f2cfe76a3a4fff5e02cb94fc1 (commit)


- Log -----------------------------------------------------------------
commit 5e13a79645239f25615dfc9ee1d177f44e0bbc09
Author: Michael P <mic...@us...>
Date:   Fri Jul 15 15:30:12 2011 +0900

    Fix for bug 3366724: Autovacuum warning on datanode
    
    This was caused by autovacuum launcher on Datanode.
    As autovacuum is not authorized to get GXID and snapshot from GTM,
    bypass this warning.
    
    Global snapshot is not necessary for launcher as autovacuum analyze and
    worker are in charge of table cleanup.

diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index 5477df6..783b352 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -1243,18 +1243,25 @@ GetSnapshotData(Snapshot snapshot)
 		/* else fallthrough */
 	}
 
-	/* If we have no snapshot, we will use a local one.
+	/*
+	 * If we have no snapshot, we will use a local one.
 	 * If we are in normal mode, we output a warning though.
 	 * We currently fallback and use a local one at initdb time,
 	 * as well as when a new connection occurs.
+	 * This is also the case for autovacuum launcher.
+	 *
 	 * IsPostmasterEnvironment - checks for initdb
 	 * IsNormalProcessingMode() - checks for new connections
+	 * IsAutoVacuumLauncherProcess - checks for autovacuum launcher process
 	 */
-	 if (IS_PGXC_DATANODE && snapshot_source == SNAPSHOT_UNDEFINED 
-	 		&& IsPostmasterEnvironment && IsNormalProcessingMode())
-	 {
-	 	elog(WARNING, "Do not have a GTM snapshot available");
-	 }
+	if (IS_PGXC_DATANODE &&
+		snapshot_source == SNAPSHOT_UNDEFINED &&
+		IsPostmasterEnvironment &&
+		IsNormalProcessingMode() &&
+		!IsAutoVacuumLauncherProcess())
+	{
+		elog(WARNING, "Do not have a GTM snapshot available");
+	}
 #endif
       
 	/*

-----------------------------------------------------------------------

Summary of changes:
 src/backend/storage/ipc/procarray.c |   19 +++++++++++++------
 1 files changed, 13 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Postgres-XC