postgres-xc-committers Mailing List for Postgres-XC (Page 84)

Project "Postgres-XC".

The branch, master has been updated
       via  ce001733b43f9e76e6554ffea21fb35385e34db4 (commit)
       via  23320a802642454ed15066a9d73620f9225e8547 (commit)
      from  ce9ef820fe16ca700fb72d90a1b526b1a11b06a6 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=ce001733b43f9e76e6554ffea21fb35385e34db4

commit ce001733b43f9e76e6554ffea21fb35385e34db4
Merge: 23320a8 ce9ef82
Author: Koichi Suzuki <koi...@gm...>
Date:   Fri Apr 6 18:16:21 2012 +0900

    Merge branch 'master' of ssh://postgres-xc.git.sourceforge.net/gitroot/postgres-xc/postgres-xc


http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=23320a802642454ed15066a9d73620f9225e8547

commit ce001733b43f9e76e6554ffea21fb35385e34db4
Merge: 23320a8 ce9ef82
Author: Koichi Suzuki <koi...@gm...>
Date:   Fri Apr 6 18:16:21 2012 +0900

    Merge branch 'master' of ssh://postgres-xc.git.sourceforge.net/gitroot/postgres-xc/postgres-xc


-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/ref/pgxc_clean-ref.sgmlin |  226 +++++++++++++++++++++++++++++
 1 files changed, 226 insertions(+), 0 deletions(-)
 create mode 100644 doc-xc/src/sgml/ref/pgxc_clean-ref.sgmlin


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  ce9ef820fe16ca700fb72d90a1b526b1a11b06a6 (commit)
      from  4e607875577fc897bf25ab9547e70bbf1c3fce06 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=ce9ef820fe16ca700fb72d90a1b526b1a11b06a6

commit ce9ef820fe16ca700fb72d90a1b526b1a11b06a6
Author: Michael P <mi...@ot...>
Date:   Fri Apr 6 11:28:03 2012 +0900

    Add an estimation of row returned for pgxc_is_committed
    
    For a pg_proc function having proretset set at true, prorows cannot
    be 0.

M	src/include/catalog/pg_proc.h

-----------------------------------------------------------------------

Summary of changes:
 src/include/catalog/pg_proc.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  4e607875577fc897bf25ab9547e70bbf1c3fce06 (commit)
      from  bd16ef0ead6914985eb377aeb5d19c7084799ad0 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=4e607875577fc897bf25ab9547e70bbf1c3fce06

commit 4e607875577fc897bf25ab9547e70bbf1c3fce06
Author: Michael P <mi...@ot...>
Date:   Thu Apr 5 16:34:51 2012 +0900

    New GUC parameter to control 2PC usage for temporary objects
    
    This new parameter, called enforce_two_phase_commit can be used to
    enforce the use of 2PC on transactions involving temporary objects
    or having ON COMMIT actions pending on them.
    Enforcing the use of autocommit on several nodes that have performed
    write operations at the same time might break consistency very easily
    so the default value of enforce_two_phase_commit is on, but a superuser
    can modify its value with SET on a private session. And its initial value
    can be changed in postgresql.conf.
    Regression tests have been updated in such a way that all the tests using
    ON COMMIT actions or temporary objects have their sessions with this
    parameter set to off, to it leads to a correct regression behavior.
    
    The reason of introducing this parameter in Postgres-XC is originally
    from PostgreSQL, where it is not possible to use two phase commit on
    temporary objects. This might be or might not be implemented in Postgres,
    so we need a mechanism to provide DBA some ways to protect data consistency
    at all costs when he sets up his cluster as such functionality tunning
    is application-dependent.

M	doc-xc/src/sgml/config.sgmlin
M	doc-xc/src/sgml/runtime.sgmlin
M	src/backend/access/transam/xact.c
M	src/backend/commands/tablecmds.c
M	src/backend/pgxc/pool/execRemote.c
M	src/backend/utils/misc/guc.c
M	src/backend/utils/misc/postgresql.conf.sample
M	src/include/pgxc/execRemote.h
M	src/test/regress/expected/aggregates_1.out
M	src/test/regress/expected/arrays.out
M	src/test/regress/expected/cluster.out
M	src/test/regress/expected/cluster_1.out
M	src/test/regress/expected/combocid_1.out
M	src/test/regress/expected/copy2_1.out
M	src/test/regress/expected/create_type.out
M	src/test/regress/expected/create_view.out
M	src/test/regress/expected/domain_1.out
M	src/test/regress/expected/foreign_key.out
M	src/test/regress/expected/foreign_key_1.out
M	src/test/regress/expected/functional_deps_1.out
M	src/test/regress/expected/guc_1.out
M	src/test/regress/expected/inherit.out
M	src/test/regress/expected/inherit_1.out
M	src/test/regress/expected/plancache.out
M	src/test/regress/expected/polymorphism.out
M	src/test/regress/expected/polymorphism_1.out
M	src/test/regress/expected/rangefuncs_1.out
M	src/test/regress/expected/returning_1.out
M	src/test/regress/expected/rowtypes.out
M	src/test/regress/expected/rowtypes_1.out
M	src/test/regress/expected/rules.out
M	src/test/regress/expected/select_1.out
M	src/test/regress/expected/select_distinct.out
M	src/test/regress/expected/sequence.out
M	src/test/regress/expected/subselect.out
M	src/test/regress/expected/temp.out
M	src/test/regress/expected/transactions_1.out
M	src/test/regress/expected/txid.out
M	src/test/regress/expected/window.out
M	src/test/regress/expected/with.out
M	src/test/regress/expected/with_1.out
M	src/test/regress/expected/xc_temp.out
M	src/test/regress/input/copy.source
M	src/test/regress/output/copy.source
M	src/test/regress/sql/aggregates.sql
M	src/test/regress/sql/arrays.sql
M	src/test/regress/sql/cluster.sql
M	src/test/regress/sql/combocid.sql
M	src/test/regress/sql/copy2.sql
M	src/test/regress/sql/create_type.sql
M	src/test/regress/sql/create_view.sql
M	src/test/regress/sql/domain.sql
M	src/test/regress/sql/foreign_key.sql
M	src/test/regress/sql/functional_deps.sql
M	src/test/regress/sql/guc.sql
M	src/test/regress/sql/inherit.sql
M	src/test/regress/sql/plancache.sql
M	src/test/regress/sql/plpgsql.sql
M	src/test/regress/sql/polymorphism.sql
M	src/test/regress/sql/rangefuncs.sql
M	src/test/regress/sql/returning.sql
M	src/test/regress/sql/rowtypes.sql
M	src/test/regress/sql/rules.sql
M	src/test/regress/sql/select.sql
M	src/test/regress/sql/select_distinct.sql
M	src/test/regress/sql/sequence.sql
M	src/test/regress/sql/subselect.sql
M	src/test/regress/sql/temp.sql
M	src/test/regress/sql/transactions.sql
M	src/test/regress/sql/txid.sql
M	src/test/regress/sql/window.sql
M	src/test/regress/sql/with.sql
M	src/test/regress/sql/xc_temp.sql

-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/config.sgmlin                   |   15 ++++++++++++++-
 doc-xc/src/sgml/runtime.sgmlin                  |   11 +++++++++++
 src/backend/access/transam/xact.c               |   22 ++++++++++++++++------
 src/backend/commands/tablecmds.c                |    6 ++----
 src/backend/pgxc/pool/execRemote.c              |    3 +++
 src/backend/utils/misc/guc.c                    |   19 ++++++++++++++-----
 src/backend/utils/misc/postgresql.conf.sample   |    6 +++++-
 src/include/pgxc/execRemote.h                   |    3 +++
 src/test/regress/expected/aggregates_1.out      |    2 ++
 src/test/regress/expected/arrays.out            |    2 ++
 src/test/regress/expected/cluster.out           |    2 ++
 src/test/regress/expected/cluster_1.out         |    4 ++++
 src/test/regress/expected/combocid_1.out        |    2 ++
 src/test/regress/expected/copy2_1.out           |    2 ++
 src/test/regress/expected/create_type.out       |    2 ++
 src/test/regress/expected/create_view.out       |    2 ++
 src/test/regress/expected/domain_1.out          |    2 ++
 src/test/regress/expected/foreign_key.out       |    2 ++
 src/test/regress/expected/foreign_key_1.out     |    2 ++
 src/test/regress/expected/functional_deps_1.out |    2 ++
 src/test/regress/expected/guc_1.out             |    5 +++++
 src/test/regress/expected/inherit.out           |    2 ++
 src/test/regress/expected/inherit_1.out         |    2 ++
 src/test/regress/expected/plancache.out         |    2 ++
 src/test/regress/expected/polymorphism.out      |    2 ++
 src/test/regress/expected/polymorphism_1.out    |    2 ++
 src/test/regress/expected/rangefuncs_1.out      |    2 ++
 src/test/regress/expected/returning_1.out       |    2 ++
 src/test/regress/expected/rowtypes.out          |    2 ++
 src/test/regress/expected/rowtypes_1.out        |    2 ++
 src/test/regress/expected/rules.out             |    2 ++
 src/test/regress/expected/select_1.out          |    2 ++
 src/test/regress/expected/select_distinct.out   |    2 ++
 src/test/regress/expected/sequence.out          |    2 ++
 src/test/regress/expected/subselect.out         |    2 ++
 src/test/regress/expected/temp.out              |    4 ++++
 src/test/regress/expected/transactions_1.out    |    2 ++
 src/test/regress/expected/txid.out              |    2 ++
 src/test/regress/expected/window.out            |    2 ++
 src/test/regress/expected/with.out              |    2 ++
 src/test/regress/expected/with_1.out            |    2 ++
 src/test/regress/expected/xc_temp.out           |    2 ++
 src/test/regress/input/copy.source              |    3 +++
 src/test/regress/output/copy.source             |    2 ++
 src/test/regress/sql/aggregates.sql             |    4 ++++
 src/test/regress/sql/arrays.sql                 |    3 +++
 src/test/regress/sql/cluster.sql                |    5 +++++
 src/test/regress/sql/combocid.sql               |    3 +++
 src/test/regress/sql/copy2.sql                  |    3 +++
 src/test/regress/sql/create_type.sql            |    3 +++
 src/test/regress/sql/create_view.sql            |    3 +++
 src/test/regress/sql/domain.sql                 |    3 +++
 src/test/regress/sql/foreign_key.sql            |    2 ++
 src/test/regress/sql/functional_deps.sql        |    3 +++
 src/test/regress/sql/guc.sql                    |    6 ++++++
 src/test/regress/sql/inherit.sql                |    4 ++++
 src/test/regress/sql/plancache.sql              |    3 +++
 src/test/regress/sql/plpgsql.sql                |    3 +++
 src/test/regress/sql/polymorphism.sql           |    3 +++
 src/test/regress/sql/rangefuncs.sql             |    3 +++
 src/test/regress/sql/returning.sql              |    3 +++
 src/test/regress/sql/rowtypes.sql               |    3 +++
 src/test/regress/sql/rules.sql                  |    2 ++
 src/test/regress/sql/select.sql                 |    4 ++++
 src/test/regress/sql/select_distinct.sql        |    3 +++
 src/test/regress/sql/sequence.sql               |    4 ++++
 src/test/regress/sql/subselect.sql              |    3 +++
 src/test/regress/sql/temp.sql                   |    6 ++++++
 src/test/regress/sql/transactions.sql           |    3 +++
 src/test/regress/sql/txid.sql                   |    3 +++
 src/test/regress/sql/window.sql                 |    3 +++
 src/test/regress/sql/with.sql                   |    3 +++
 src/test/regress/sql/xc_temp.sql                |    3 +++
 73 files changed, 245 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  bd16ef0ead6914985eb377aeb5d19c7084799ad0 (commit)
      from  3d39542b5b4d5a709a28414b5b34ff9af8f7b8e8 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=bd16ef0ead6914985eb377aeb5d19c7084799ad0

commit bd16ef0ead6914985eb377aeb5d19c7084799ad0
Author: Michael P <mi...@ot...>
Date:   Thu Apr 5 16:18:59 2012 +0900

    Fix for bug 3485997: UPDATE fails on table with foreign key
    
    This commit provides a fix for Coordinator trying to fetch a tuple
    locally. This is not possible as all the data is localized on Datanodes.
    This commit also enables reference integrity check on Datanodes.
    This is thought as safe as XC has already some check mechanisms at constraint
    creation to insure that constraint can be checked locally based on its dependant
    table distributions.
    
    Patch by Andrei Martsinchyk, I just fixed a bug with reference integrity
    attempt check on Coordinator.

M	src/backend/executor/nodeModifyTable.c
M	src/backend/utils/adt/ri_triggers.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/executor/nodeModifyTable.c |   12 ++++++++++++
 src/backend/utils/adt/ri_triggers.c    |   11 +++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  3d39542b5b4d5a709a28414b5b34ff9af8f7b8e8 (commit)
      from  442d2bf8e191bedaad00923aab91502128de9b4c (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=3d39542b5b4d5a709a28414b5b34ff9af8f7b8e8

commit 3d39542b5b4d5a709a28414b5b34ff9af8f7b8e8
Author: Amit Khandekar <ami...@en...>
Date:   Wed Apr 4 14:01:13 2012 +0530

    Modify expected output files of timestamp.sql, timestamptz.sql to
    make them pass.
    
    One change was to add ORDER BY clause in some queries that were left out.
    
    Another change was to correct particular date values
    that were displayed. The below commit
    70d8a2c29e809c90f7caaded2b4f47b1cf18d01d in PG master branch has changed the
    behaviour of FM suffix specification in to_char() function, so that the query:
    select to_char('0097-02-16 17:32:01'::timestamp, 'FMYYY');
    now returns 97, and before this commit it used to return 097.
    And the expected change output in timestamp*.out has been updated in PG, but
    did not get correctly merged in XC. In XC, the expected/timestamp.out still
    had the old format values.
    
    So the expected output files are now corrected accordingly in this commit.

M	src/test/regress/expected/timestamp.out
M	src/test/regress/expected/timestamptz.out
M	src/test/regress/sql/timestamp.sql
M	src/test/regress/sql/timestamptz.sql

-----------------------------------------------------------------------

Summary of changes:
 src/test/regress/expected/timestamp.out   |   74 +++++----------
 src/test/regress/expected/timestamptz.out |  147 ++++++++++++----------------
 src/test/regress/sql/timestamp.sql        |    2 +-
 src/test/regress/sql/timestamptz.sql      |    2 +-
 4 files changed, 89 insertions(+), 136 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  442d2bf8e191bedaad00923aab91502128de9b4c (commit)
      from  76d3b40cba22469361215fd4937db84eb9d0ce6e (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=442d2bf8e191bedaad00923aab91502128de9b4c

commit 442d2bf8e191bedaad00923aab91502128de9b4c
Author: Koichi Suzuki <koi...@gm...>
Date:   Wed Apr 4 14:49:09 2012 +0900

    This is the fix for the bug 3512692.   Added parameter check of gtm_proxy.

M	src/gtm/proxy/proxy_main.c

-----------------------------------------------------------------------

Summary of changes:
 src/gtm/proxy/proxy_main.c |   31 +++++++++++++++++++++++++++++++
 1 files changed, 31 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  76d3b40cba22469361215fd4937db84eb9d0ce6e (commit)
      from  a40e4ef8d222bf9cdc3952e7af668864949b0d00 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=76d3b40cba22469361215fd4937db84eb9d0ce6e

commit 76d3b40cba22469361215fd4937db84eb9d0ce6e
Author: Ashutosh Bapat <ash...@en...>
Date:   Mon Apr 2 15:49:53 2012 +0530

    Query deparser can not handle PlaceHolderVar nodes. PlaceHolderVar node is added when
    subqueries are pulled up. They are removed before execution starts by function
    fix_scan_expr() for scan nodes. This function is static to setrefs.c, and thus
    needs a wrapper to expose it outside that file. In create_remotequery_plan()
    apply fix_scan_expr() on the target list and quals to remove PlaceHolderVar
    nodes from those.

M	src/backend/optimizer/plan/createplan.c
M	src/backend/optimizer/plan/setrefs.c
M	src/include/optimizer/planmain.h

-----------------------------------------------------------------------

Summary of changes:
 src/backend/optimizer/plan/createplan.c |   10 ++++++++++
 src/backend/optimizer/plan/setrefs.c    |    8 ++++++++
 src/include/optimizer/planmain.h        |    2 ++
 3 files changed, 20 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  a40e4ef8d222bf9cdc3952e7af668864949b0d00 (commit)
      from  d7134501525dd2a3d7c8fc30a8f29fdaab110d98 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=a40e4ef8d222bf9cdc3952e7af668864949b0d00

commit a40e4ef8d222bf9cdc3952e7af668864949b0d00
Author: Ashutosh Bapat <ash...@en...>
Date:   Mon Apr 2 15:39:32 2012 +0530

    Any data exchange between coordinator and datanode happens in the form of text,
    obtained by calling I/O functions for datatypes.  For float4 and float8 we used
    float*out function which limit the number of digits in the string to
    DBL_DIG/FLT_DIG (both 16) + extra_float_digits (GUC). By default the later value
    is 0. Rest of the digits are truncated. Thus we see a difference at the 16th
    digit when we add up truncated floating point transition results from datanodes.
    
    The fix here is really to move from text based data exchange to binary data
    exchange between coordinator and datanode, which will preserve the precision of
    floating point. This is basic change and might be risky to apply just before the
    release. Hence adding alternate output file.
    
    The test aggregates has EXPLAIN outputs specific to PostgreSQL. Those outputs
    are not valid in Postgres-XC. Hence updating the expected output with EXPLAIN
    outputs obtained in Postgres-XC.

M	src/test/regress/expected/aggregates.out
A	src/test/regress/expected/aggregates_1.out
M	src/test/regress/sql/aggregates.sql

-----------------------------------------------------------------------

Summary of changes:
 src/test/regress/expected/aggregates.out           |  255 +++++++-----------
 .../expected/{aggregates.out => aggregates_1.out}  |  281 ++++++++------------
 src/test/regress/sql/aggregates.sql                |   30 ++-
 3 files changed, 237 insertions(+), 329 deletions(-)
 copy src/test/regress/expected/{aggregates.out => aggregates_1.out} (79%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  d7134501525dd2a3d7c8fc30a8f29fdaab110d98 (commit)
      from  2689d1bfcc102d6cbf74f5425a98a221c22e33c1 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d7134501525dd2a3d7c8fc30a8f29fdaab110d98

commit d7134501525dd2a3d7c8fc30a8f29fdaab110d98
Author: Amit Khandekar <ami...@en...>
Date:   Mon Apr 2 14:19:44 2012 +0530

    Pass to the pooler session, the default values for some parameters, like
    DATESTYLE, TZ. If a psql client sets these as environment vars, these do
    not get propagated to datanodes, as a result of which the date formats
    returned do not match PGDATESTYLE for e.g. So, in general these session
    default values should be passed on to session poolers connections to datanodes
    and remote coordinator.
    These values help maintain consistent param values between the datanodes and the
    coordinator for a given client session. The params are passed from coordinator
    backend to the pooler session using pgoptions (for e.g. '-c datestyle=Postgres,MDY'.
    And the database pools are searched for unique combination of database, username
    and pgoptions; earlier it was based on database and username only.

M	src/backend/pgxc/pool/pgxcnode.c
M	src/backend/pgxc/pool/poolmgr.c
M	src/backend/tcop/postgres.c
M	src/include/pgxc/pgxcnode.h
M	src/include/pgxc/poolmgr.h

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/pool/pgxcnode.c |    6 +-
 src/backend/pgxc/pool/poolmgr.c  |  120 +++++++++++++++++++++++++++----------
 src/backend/tcop/postgres.c      |    2 +-
 src/include/pgxc/pgxcnode.h      |    2 +-
 src/include/pgxc/poolmgr.h       |    7 ++-
 5 files changed, 98 insertions(+), 39 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  2689d1bfcc102d6cbf74f5425a98a221c22e33c1 (commit)
      from  5c3f03ccffa86b775e1d4d9be668accebaa2e4c9 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=2689d1bfcc102d6cbf74f5425a98a221c22e33c1

commit 2689d1bfcc102d6cbf74f5425a98a221c22e33c1
Author: Michael P <mi...@ot...>
Date:   Mon Apr 2 15:20:07 2012 +0900

    Correct warning in xact.c: initializer element is not constant
    
    Well, a static element was used instead of a const.

M	src/backend/access/transam/xact.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/access/transam/xact.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  5c3f03ccffa86b775e1d4d9be668accebaa2e4c9 (commit)
      from  8427ea322eabca18fa21f286c2284aa4ffa105a8 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=5c3f03ccffa86b775e1d4d9be668accebaa2e4c9

commit 5c3f03ccffa86b775e1d4d9be668accebaa2e4c9
Author: Koichi Suzuki <koi...@gm...>
Date:   Fri Mar 30 09:22:18 2012 +0900

    Adds pgxc_clean utility.   pgxc_clean checks all the two phase commit status
    to find any outstanding ones, then cleans up them to keep transaction status
    consistent throughout Postgres-XC database cluster.

M	doc-xc/src/sgml/ref/allfiles.sgmlin
M	doc-xc/src/sgml/reference.sgmlin
M	src/Makefile
A	src/pgxc/bin/pgxc_clean/Makefile
A	src/pgxc/bin/pgxc_clean/pgxc_clean.c
A	src/pgxc/bin/pgxc_clean/pgxc_clean.h
A	src/pgxc/bin/pgxc_clean/pgxc_clean_test.sh
A	src/pgxc/bin/pgxc_clean/txninfo.c
A	src/pgxc/bin/pgxc_clean/txninfo.h

-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/ref/allfiles.sgmlin        |    3 +
 doc-xc/src/sgml/reference.sgmlin           |    3 +
 src/Makefile                               |    3 +-
 src/pgxc/bin/pgxc_clean/Makefile           |   46 ++
 src/pgxc/bin/pgxc_clean/pgxc_clean.c       | 1043 ++++++++++++++++++++++++++++
 src/pgxc/bin/pgxc_clean/pgxc_clean.h       |   13 +
 src/pgxc/bin/pgxc_clean/pgxc_clean_test.sh |   85 +++
 src/pgxc/bin/pgxc_clean/txninfo.c          |  338 +++++++++
 src/pgxc/bin/pgxc_clean/txninfo.h          |   83 +++
 9 files changed, 1616 insertions(+), 1 deletions(-)
 create mode 100644 src/pgxc/bin/pgxc_clean/Makefile
 create mode 100644 src/pgxc/bin/pgxc_clean/pgxc_clean.c
 create mode 100644 src/pgxc/bin/pgxc_clean/pgxc_clean.h
 create mode 100644 src/pgxc/bin/pgxc_clean/pgxc_clean_test.sh
 create mode 100644 src/pgxc/bin/pgxc_clean/txninfo.c
 create mode 100644 src/pgxc/bin/pgxc_clean/txninfo.h


hooks/post-receive
-- 
Postgres-XC

Hi Michael,
Was this patch discussed on the mailing list? I did not see any relevant
discussion.

There can a possibility that resorigtbl is set the result table but it's
not added in rewriting. In this case, would there be erroneous column
updation? Instead of resorigtbl can you use some attribute inside the Var
node like varno?

On Thu, Mar 29, 2012 at 10:01 AM, Michael Paquier <
mic...@us...> wrote:

> Project "Postgres-XC".
>
> The branch, master has been updated
>       via  8427ea322eabca18fa21f286c2284aa4ffa105a8 (commit)
>      from  0f11b36d79827bd8b2ed66a31e074e1a8a86fba3 (commit)
>
>
> - Log -----------------------------------------------------------------
>
> http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=8427ea322eabca18fa21f286c2284aa4ffa105a8
>
> commit 8427ea322eabca18fa21f286c2284aa4ffa105a8
> Author: Michael P <mi...@ot...>
> Date:   Thu Mar 29 13:32:53 2012 +0900
>
>    Correct remote DELETE planning for multiple relations
>
>    In case several relations were involved in a remote DELETE (rules,
>    join, etc.), remote query was not correctly generated because it
>    took into account not only its target entries, but also the ones
>    from other relations.
>    A reference of the original table is added in target entries and
>    this is compared to the relation whose remote DELETE is generated
>    to insure that all the operations are consistent.
>
>    This had consequences like bug 3512657, but also on the usage of
>    rules on DELETE.
>
> M       src/backend/optimizer/plan/createplan.c
> M       src/backend/rewrite/rewriteHandler.c
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  src/backend/optimizer/plan/createplan.c |   13 ++++++++++---
>  src/backend/rewrite/rewriteHandler.c    |    9 +++++++++
>  2 files changed, 19 insertions(+), 3 deletions(-)
>
>
> hooks/post-receive
> --
> Postgres-XC
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> Postgres-xc-committers mailing list
> Pos...@li...
> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Project "Postgres-XC".

The branch, master has been updated
       via  8427ea322eabca18fa21f286c2284aa4ffa105a8 (commit)
      from  0f11b36d79827bd8b2ed66a31e074e1a8a86fba3 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=8427ea322eabca18fa21f286c2284aa4ffa105a8

commit 8427ea322eabca18fa21f286c2284aa4ffa105a8
Author: Michael P <mi...@ot...>
Date:   Thu Mar 29 13:32:53 2012 +0900

    Correct remote DELETE planning for multiple relations
    
    In case several relations were involved in a remote DELETE (rules,
    join, etc.), remote query was not correctly generated because it
    took into account not only its target entries, but also the ones
    from other relations.
    A reference of the original table is added in target entries and
    this is compared to the relation whose remote DELETE is generated
    to insure that all the operations are consistent.
    
    This had consequences like bug 3512657, but also on the usage of
    rules on DELETE.

M	src/backend/optimizer/plan/createplan.c
M	src/backend/rewrite/rewriteHandler.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/optimizer/plan/createplan.c |   13 ++++++++++---
 src/backend/rewrite/rewriteHandler.c    |    9 +++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  0f11b36d79827bd8b2ed66a31e074e1a8a86fba3 (commit)
      from  0eaba1379aa2dde346a53eb15f8849c0e09861d0 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=0f11b36d79827bd8b2ed66a31e074e1a8a86fba3

commit 0f11b36d79827bd8b2ed66a31e074e1a8a86fba3
Author: Koichi Suzuki <koi...@gm...>
Date:   Thu Mar 29 11:57:44 2012 +0900

    This commit extends commit/rollback prepared statement for xc_maintenance_mode = on.  With xc_maintenance_mode = on, these command will work only locally and report the result to GTM.
    
    This is needed to maintain transaction integrity after failed node is back or failover took place.

M	doc-xc/src/sgml/config.sgmlin
M	doc-xc/src/sgml/ref/commit_prepared.sgmlin
M	doc-xc/src/sgml/ref/rollback_prepared.sgmlin
M	src/backend/access/transam/twophase.c
M	src/backend/parser/analyze.c
M	src/backend/pgxc/pool/execRemote.c
M	src/backend/tcop/utility.c

-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/config.sgmlin                |   25 ++++++++++-
 doc-xc/src/sgml/ref/commit_prepared.sgmlin   |    7 +++
 doc-xc/src/sgml/ref/rollback_prepared.sgmlin |   16 +++++++
 src/backend/access/transam/twophase.c        |   45 ++++++++++++++++++--
 src/backend/parser/analyze.c                 |    5 +-
 src/backend/pgxc/pool/execRemote.c           |   59 ++++++++++++++++++-------
 src/backend/tcop/utility.c                   |    4 +-
 7 files changed, 133 insertions(+), 28 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  0eaba1379aa2dde346a53eb15f8849c0e09861d0 (commit)
      from  dfda23e7547f457e15d79054f81d30e826faeecf (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=0eaba1379aa2dde346a53eb15f8849c0e09861d0

commit 0eaba1379aa2dde346a53eb15f8849c0e09861d0
Author: Koichi Suzuki <koi...@gm...>
Date:   Thu Mar 29 11:03:25 2012 +0900

    This commit adds GUC parameter xc_maintenance_mode.   This is needed to control
    behavior of some statements to be used to maintain XC database integrity by
    dedicate utility programs such as pgxc_clean, which is now under the
    development.
    
    Also, this patch modifies implicit 2PC xid to _$XC$%u where %u is the transactionId.
    Because it is essential to distinguish implicit 2PC from explicit one to maintain
    database consisitensy, this patch checks xid in PREPARE TRANSACTION and rejects
    xid for implicit 2PC.
    
    See documentation for details.

M	doc-xc/src/sgml/config.sgmlin
M	doc-xc/src/sgml/ref/prepare_transaction.sgmlin
M	src/backend/access/transam/xact.c
M	src/backend/pgxc/Makefile
A	src/backend/pgxc/xc_maintenance_mode/Makefile
A	src/backend/pgxc/xc_maintenance_mode/xc_maintenance_mode.c
M	src/backend/tcop/utility.c
M	src/backend/utils/misc/guc.c
M	src/include/access/xact.h
A	src/include/pgxc/xc_maintenance_mode.h
M	src/include/utils/guc_tables.h

-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/config.sgmlin                      |   15 ++++
 doc-xc/src/sgml/ref/prepare_transaction.sgmlin     |    6 ++
 src/backend/access/transam/xact.c                  |   14 ++++
 src/backend/pgxc/Makefile                          |    2 +-
 .../pgxc/{barrier => xc_maintenance_mode}/Makefile |    4 +-
 .../pgxc/xc_maintenance_mode/xc_maintenance_mode.c |    5 ++
 src/backend/tcop/utility.c                         |   13 ++++
 src/backend/utils/misc/guc.c                       |   74 ++++++++++++++++++++
 src/include/access/xact.h                          |    1 +
 src/include/pgxc/xc_maintenance_mode.h             |   12 +++
 src/include/utils/guc_tables.h                     |    7 ++-
 11 files changed, 149 insertions(+), 4 deletions(-)
 copy src/backend/pgxc/{barrier => xc_maintenance_mode}/Makefile (85%)
 create mode 100644 src/backend/pgxc/xc_maintenance_mode/xc_maintenance_mode.c
 create mode 100644 src/include/pgxc/xc_maintenance_mode.h


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  dfda23e7547f457e15d79054f81d30e826faeecf (commit)
      from  0b3ffcff380d0fe14cb11d6c2f4b88fe20346ff1 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=dfda23e7547f457e15d79054f81d30e826faeecf

commit dfda23e7547f457e15d79054f81d30e826faeecf
Author: Michael P <mi...@ot...>
Date:   Thu Mar 29 10:20:05 2012 +0900

    Alternative regression output for test inherit
    
    This is related to bug 3141171, where XC tries to perform joins with
    objects Oids but it fails because OIDs are not consistent among nodes
    in the cluster. This is a restriction of the XC current architecture.
    Some additional queries, using a cast on regclass with relation name
    are used to show the correct output in the test. This part of the test
    has been updated in consequence.
    
    There are still diffs in test inherit but it is not related to this
    bug, so this regression still fails.

A	src/test/regress/expected/inherit_1.out
M	src/test/regress/sql/inherit.sql

-----------------------------------------------------------------------

Summary of changes:
 .../expected/{inherit.out => inherit_1.out}        |  725 +++++++++++---------
 src/test/regress/sql/inherit.sql                   |   45 ++
 2 files changed, 462 insertions(+), 308 deletions(-)
 copy src/test/regress/expected/{inherit.out => inherit_1.out} (74%)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  0b3ffcff380d0fe14cb11d6c2f4b88fe20346ff1 (commit)
      from  1957c940883036cb30700b400356eda3755139db (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=0b3ffcff380d0fe14cb11d6c2f4b88fe20346ff1

commit 0b3ffcff380d0fe14cb11d6c2f4b88fe20346ff1
Author: Michael P <mi...@ot...>
Date:   Thu Mar 29 09:46:42 2012 +0900

    GTM callback mechanism for sequence consistency on GTM
    
    Addition of a mechanism to insure that sequence information
    is kept consistent on GTM within a transaction block.
    A callback to drop sequences on GTM is registered when sequences are
    dropped or created. Then this callback is used when a transaction that created
    sequence is aborted or when a transaction that dropped a sequence commits,
    insuring that sequence information is properly rollbacked or committed on GTM.

M	src/backend/access/transam/xact.c
M	src/backend/catalog/dependency.c
M	src/backend/commands/sequence.c
M	src/include/access/xact.h
M	src/include/commands/sequence.h

-----------------------------------------------------------------------

Summary of changes:
 src/backend/access/transam/xact.c |  122 +++++++++++++++++++++++++++++++++++++
 src/backend/catalog/dependency.c  |   12 ++--
 src/backend/commands/sequence.c   |   84 +++++++++++++++++++++++++-
 src/include/access/xact.h         |   15 +++++
 src/include/commands/sequence.h   |   17 +++++
 5 files changed, 244 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  1957c940883036cb30700b400356eda3755139db (commit)
      from  9d71db236af45cda76b31a870c23482e988a8896 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=1957c940883036cb30700b400356eda3755139db

commit 1957c940883036cb30700b400356eda3755139db
Author: Ashutosh Bapat <ash...@en...>
Date:   Wed Mar 28 14:22:05 2012 +0530

    A query can not be shipped to the datanodes because of many reasons. Store these
    reasons in the FQS_context for debugging and further optimizations.

M	src/backend/pgxc/plan/planner.c
M	src/include/pgxc/planner.h

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c |  189 +++++++++++++++++++++++++--------------
 src/include/pgxc/planner.h      |   24 ++++-
 2 files changed, 140 insertions(+), 73 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  9d71db236af45cda76b31a870c23482e988a8896 (commit)
      from  d16e34e9c66b1b7949991adb8b6aba172e4f5a6f (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=9d71db236af45cda76b31a870c23482e988a8896

commit 9d71db236af45cda76b31a870c23482e988a8896
Author: Ashutosh Bapat <ash...@en...>
Date:   Tue Mar 27 12:09:01 2012 +0530

    Some C structures and functions were not used after the new FQS code was
    implemented. Removed those.

M	src/backend/pgxc/plan/planner.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c |  198 +--------------------------------------
 1 files changed, 1 insertions(+), 197 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  d16e34e9c66b1b7949991adb8b6aba172e4f5a6f (commit)
      from  118bf9d0bfd000171fd71c37f528db5664d4eb4a (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d16e34e9c66b1b7949991adb8b6aba172e4f5a6f

commit d16e34e9c66b1b7949991adb8b6aba172e4f5a6f
Author: Pavan Deolasee <pav...@gm...>
Date:   Tue Mar 27 10:14:01 2012 +0530

    Honor collations while handling results at the coordinator. This fixes a part of
    collation test case failure

M	src/backend/optimizer/plan/createplan.c
M	src/backend/pgxc/pool/execRemote.c
M	src/backend/utils/sort/tuplesort.c
M	src/include/pgxc/planner.h
M	src/include/utils/tuplesort.h

-----------------------------------------------------------------------

Summary of changes:
 src/backend/optimizer/plan/createplan.c |    1 +
 src/backend/pgxc/pool/execRemote.c      |    1 +
 src/backend/utils/sort/tuplesort.c      |   22 ++++++++++++++--------
 src/include/pgxc/planner.h              |    1 +
 src/include/utils/tuplesort.h           |    2 +-
 5 files changed, 18 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  118bf9d0bfd000171fd71c37f528db5664d4eb4a (commit)
      from  667ce0824d0bcb7acbc128d747b131d78d4ed73e (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=118bf9d0bfd000171fd71c37f528db5664d4eb4a

commit 118bf9d0bfd000171fd71c37f528db5664d4eb4a
Author: Michael P <mi...@ot...>
Date:   Tue Mar 27 11:22:31 2012 +0900

    Clean up warnings in execRemote.c
    
    Some static functions are not used anymore since transaction handling
    has been cleaned up recently.

M	src/backend/pgxc/pool/execRemote.c

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/pool/execRemote.c |   55 ------------------------------------
 1 files changed, 0 insertions(+), 55 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  667ce0824d0bcb7acbc128d747b131d78d4ed73e (commit)
       via  12bce7a547ec92e3c147d2c12bb5f2ba050aef29 (commit)
      from  d6c3f65ec3802dc5506531ed4870fe8fccb20661 (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=667ce0824d0bcb7acbc128d747b131d78d4ed73e

commit 667ce0824d0bcb7acbc128d747b131d78d4ed73e
Merge: 12bce7a d6c3f65
Author: Koichi Suzuki <koi...@gm...>
Date:   Mon Mar 26 16:42:39 2012 +0900

    Merge branch 'master' of ssh://postgres-xc.git.sourceforge.net/gitroot/postgres-xc/postgres-xc


http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=12bce7a547ec92e3c147d2c12bb5f2ba050aef29

commit 667ce0824d0bcb7acbc128d747b131d78d4ed73e
Merge: 12bce7a d6c3f65
Author: Koichi Suzuki <koi...@gm...>
Date:   Mon Mar 26 16:42:39 2012 +0900

    Merge branch 'master' of ssh://postgres-xc.git.sourceforge.net/gitroot/postgres-xc/postgres-xc


-----------------------------------------------------------------------

Summary of changes:
 doc-xc/src/sgml/func.sgmlin          |    8 ++++++++
 src/backend/access/transam/transam.c |   28 ++++++++++++++++++++++++++++
 src/include/catalog/pg_proc.h        |    2 ++
 src/include/utils/builtins.h         |    5 +++++
 4 files changed, 43 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Postgres-XC

Project "Postgres-XC".

The branch, master has been updated
       via  d6c3f65ec3802dc5506531ed4870fe8fccb20661 (commit)
      from  400958d15da435c74bd8e911bf4e3ab530618c9f (commit)


- Log -----------------------------------------------------------------
http://postgres-xc.git.sourceforge.net/git/gitweb.cgi?p=postgres-xc/postgres-xc;a=commitdiff;h=d6c3f65ec3802dc5506531ed4870fe8fccb20661

commit d6c3f65ec3802dc5506531ed4870fe8fccb20661
Author: Ashutosh Bapat <ash...@en...>
Date:   Mon Mar 26 12:57:43 2012 +0530

    Fix for bug 3465997. FieldStore node with more than one fields is not deparsed
    in processIndirection(). Since this is PostgreSQL code, we should get the fix
    from PostgreSQL repository, whenever that gets fixed. For the time being we do
    not "fast-query-ship" a parse tree with FieldStore node.

M	src/backend/pgxc/plan/planner.c
M	src/test/regress/sql/rowtypes.sql

-----------------------------------------------------------------------

Summary of changes:
 src/backend/pgxc/plan/planner.c   |   13 +++++++++++--
 src/test/regress/sql/rowtypes.sql |    3 +--
 2 files changed, 12 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Postgres-XC

On Thu, Mar 22, 2012 at 5:36 PM, Koichi Suzuki <koi...@gm...> wrote:

> Difference in conversion of floating number affects the last digits.
> Our case is caused by this (and by internal module from PostgreSQL).
>  Conversion tool place at the datanode and sent to the coordinator in
> a text format with different precision (last digit was affected by
> this).
>
>
Suzuki-san,
This is different thread. This one is related to new GUCs added for fast
query shipping. Probably you want to reply to aggregates thread :)


> Regards;
> ----------
> Koichi Suzuki
>
>
>
> 2012年3月22日19:51 Ahsan Hadi <ahs...@en...>:
> >
> >
> > On Thu, Mar 22, 2012 at 10:16 AM, Koichi Suzuki <koi...@gm...>
> > wrote:
> >>
> >> We can comment why XC changed .out file to .sql file.    Or, we can
> >> change the file name to *_xc.out to indicate that there's some change
> >> in XC for some reason.
> >
> >
> > Since this output will always be same on XC why don't we consider
> changing
> > the rangefuncs.out instead of creating alternative expected output files.
> > Creating alternative expected output files can cause a confusion or
> sometime
> > cause a bug to be pushed under the rug so it will be better to avoid
> > alternative output file as much as possible.
> >
> >>
> >> Regards;
> >> ----------
> >> Koichi Suzuki
> >>
> >>
> >>
> >> 2012年3月22日14:02 Ashutosh Bapat <ash...@en...>:
> >> >
> >> >
> >> > On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier
> >> > <mic...@gm...> wrote:
> >> >>
> >> >>
> >> >>
> >> >> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat
> >> >> <ash...@en...> wrote:
> >> >>>
> >> >>> Hi Michael,
> >> >>> Is the only difference between rangefuncs.out and rangefuncs_1.out
> the
> >> >>> new GUCs added?
> >> >>
> >> >> Yes, there are some enable_*fqs* parameters that are exclusively XC
> >> >> related.
> >> >>
> >> >>>
> >> >>> In that case it might be better to change rangefuncs.out itself,
> >> >>> rather
> >> >>> than creating the alternate output file, since that's the expected
> >> >>> output in
> >> >>> XC.
> >> >>
> >> >> We discussed about that a long time ago and it was decided to create
> >> >> alternative output results to limit the possible interactions of our
> >> >> code
> >> >> with Postgres itself.
> >> >
> >> >
> >> > I am not sure about this conclusion. We have been changing the sql and
> >> > out
> >> > files in some cases. I think, it needs to be handled on case by case
> >> > basis.
> >> > When there is a feature blocked and the outputs differ, we should
> create
> >> > an
> >> > alternate output file. When the diff is inherent to XC, we should
> change
> >> > the
> >> > output. In this particular case, we are not going to take out those
> >> > GUCs, so
> >> > the output is going to have those GUCs there. There is not reason to
> not
> >> > change the output file. Having alternate output file creates confusion
> >> > as to
> >> > which of the outputs are correct. FAILure of a testcase with alternate
> >> > output depends upon the diff between the alternate outputs. So, we
> >> > should
> >> > avoid alternate outputs as much as well as think about the merge of
> >> > testcases and outputs. So, we need a balance in both the approaches.
> >> >
> >> >>
> >> >> --
> >> >> Michael Paquier
> >> >> http://michael.otacoo.com
> >> >
> >> >
> >> >
> >> >
> >> > --
> >> > Best Wishes,
> >> > Ashutosh Bapat
> >> > EntepriseDB Corporation
> >> > The Enterprise Postgres Company
> >> >
> >> >
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > This SF email is sponsosred by:
> >> > Try Windows Azure free for 90 days Click Here
> >> > http://p.sf.net/sfu/sfd2d-msazure
> >> > _______________________________________________
> >> > Postgres-xc-committers mailing list
> >> > Pos...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
> >> >
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> This SF email is sponsosred by:
> >> Try Windows Azure free for 90 days Click Here
> >> http://p.sf.net/sfu/sfd2d-msazure
> >> _______________________________________________
> >> Postgres-xc-committers mailing list
> >> Pos...@li...
> >> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
> >
> >
> >
> >
> > --
> > Ahsan Hadi
> > Snr Director Product Development
> > EnterpriseDB Corporation
> > The Enterprise Postgres Company
> >
> > Phone: +92-51-8358874
> > Mobile: +92-333-5162114
> >
> > Website: www.enterprisedb.com
> > EnterpriseDB Blog: http://blogs.enterprisedb.com/
> > Follow us on Twitter: http://www.twitter.com/enterprisedb
> >
> > This e-mail message (and any attachment) is intended for the use of the
> > individual or entity to whom it is addressed. This message contains
> > information from EnterpriseDB Corporation that may be privileged,
> > confidential, or exempt from disclosure under applicable law. If you are
> not
> > the intended recipient or authorized to receive this for the intended
> > recipient, any use, dissemination, distribution, retention, archiving, or
> > copying of this communication is strictly prohibited. If you have
> received
> > this e-mail in error, please notify the sender immediately by reply
> e-mail
> > and delete this message.
>



-- 
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company

Difference in conversion of floating number affects the last digits.
Our case is caused by this (and by internal module from PostgreSQL).
 Conversion tool place at the datanode and sent to the coordinator in
a text format with different precision (last digit was affected by
this).

Regards;
----------
Koichi Suzuki



2012年3月22日19:51 Ahsan Hadi <ahs...@en...>:
>
>
> On Thu, Mar 22, 2012 at 10:16 AM, Koichi Suzuki <koi...@gm...>
> wrote:
>>
>> We can comment why XC changed .out file to .sql file.    Or, we can
>> change the file name to *_xc.out to indicate that there's some change
>> in XC for some reason.
>
>
> Since this output will always be same on XC why don't we consider changing
> the rangefuncs.out instead of creating alternative expected output files.
> Creating alternative expected output files can cause a confusion or sometime
> cause a bug to be pushed under the rug so it will be better to avoid
> alternative output file as much as possible.
>
>>
>> Regards;
>> ----------
>> Koichi Suzuki
>>
>>
>>
>> 2012年3月22日14:02 Ashutosh Bapat <ash...@en...>:
>> >
>> >
>> > On Thu, Mar 22, 2012 at 10:18 AM, Michael Paquier
>> > <mic...@gm...> wrote:
>> >>
>> >>
>> >>
>> >> On Thu, Mar 22, 2012 at 1:42 PM, Ashutosh Bapat
>> >> <ash...@en...> wrote:
>> >>>
>> >>> Hi Michael,
>> >>> Is the only difference between rangefuncs.out and rangefuncs_1.out the
>> >>> new GUCs added?
>> >>
>> >> Yes, there are some enable_*fqs* parameters that are exclusively XC
>> >> related.
>> >>
>> >>>
>> >>> In that case it might be better to change rangefuncs.out itself,
>> >>> rather
>> >>> than creating the alternate output file, since that's the expected
>> >>> output in
>> >>> XC.
>> >>
>> >> We discussed about that a long time ago and it was decided to create
>> >> alternative output results to limit the possible interactions of our
>> >> code
>> >> with Postgres itself.
>> >
>> >
>> > I am not sure about this conclusion. We have been changing the sql and
>> > out
>> > files in some cases. I think, it needs to be handled on case by case
>> > basis.
>> > When there is a feature blocked and the outputs differ, we should create
>> > an
>> > alternate output file. When the diff is inherent to XC, we should change
>> > the
>> > output. In this particular case, we are not going to take out those
>> > GUCs, so
>> > the output is going to have those GUCs there. There is not reason to not
>> > change the output file. Having alternate output file creates confusion
>> > as to
>> > which of the outputs are correct. FAILure of a testcase with alternate
>> > output depends upon the diff between the alternate outputs. So, we
>> > should
>> > avoid alternate outputs as much as well as think about the merge of
>> > testcases and outputs. So, we need a balance in both the approaches.
>> >
>> >>
>> >> --
>> >> Michael Paquier
>> >> http://michael.otacoo.com
>> >
>> >
>> >
>> >
>> > --
>> > Best Wishes,
>> > Ashutosh Bapat
>> > EntepriseDB Corporation
>> > The Enterprise Postgres Company
>> >
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > This SF email is sponsosred by:
>> > Try Windows Azure free for 90 days Click Here
>> > http://p.sf.net/sfu/sfd2d-msazure
>> > _______________________________________________
>> > Postgres-xc-committers mailing list
>> > Pos...@li...
>> > https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> This SF email is sponsosred by:
>> Try Windows Azure free for 90 days Click Here
>> http://p.sf.net/sfu/sfd2d-msazure
>> _______________________________________________
>> Postgres-xc-committers mailing list
>> Pos...@li...
>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-committers
>
>
>
>
> --
> Ahsan Hadi
> Snr Director Product Development
> EnterpriseDB Corporation
> The Enterprise Postgres Company
>
> Phone: +92-51-8358874
> Mobile: +92-333-5162114
>
> Website: www.enterprisedb.com
> EnterpriseDB Blog: http://blogs.enterprisedb.com/
> Follow us on Twitter: http://www.twitter.com/enterprisedb
>
> This e-mail message (and any attachment) is intended for the use of the
> individual or entity to whom it is addressed. This message contains
> information from EnterpriseDB Corporation that may be privileged,
> confidential, or exempt from disclosure under applicable law. If you are not
> the intended recipient or authorized to receive this for the intended
> recipient, any use, dissemination, distribution, retention, archiving, or
> copying of this communication is strictly prohibited. If you have received
> this e-mail in error, please notify the sender immediately by reply e-mail
> and delete this message.