Re: [Postgres-xc-general] gtm_ctl env PATH depedency

I tested that both patches work fine and committed them.

Thank you very much for your contribution.

Best Regards;
----------
Koichi Suzuki


2013/2/1 Nikhil Sontakke <ni...@st...>:
>> Thanks.    So for the master, you don't need any modification to Makefile?   Then the rest of the patch is essentially idential.
>>
>
> Yeah, and the fact that gtm_ctl.c is in a different directory in master.
>
>> Okay, I will test and commit them.
>
> Thanks Suzuki-san.
>
> Regards,
> Nikhils
>
>> ---
>> Koichi
>>
>> On Fri, 1 Feb 2013 10:15:51 +0530
>> Nikhil Sontakke <ni...@st...> wrote:
>>
>>> Hi Suzuki-san,
>>>
>>> I already submitted two patches on this thread. The first patch
>>> applies to PGXC 1.0. The second patch applies to master. Apologies for
>>> the confusion on the names.
>>>
>>> I am re-attaching both the patches with proper names again to this mail.
>>>
>>> Regards,
>>> Nikhils
>>>
>>> On Fri, Feb 1, 2013 at 6:59 AM, Koichi Suzuki <koi...@gm...> wrote:
>>> > I tried to apply the patch to the master.    Issues are:
>>> >
>>> > 1. gtm_ctl directry was moved to src/bin/gtm_ctl --> patch includes
>>> > directory src/gtm/main and src/gtm/proxy so -p option of the patch
>>> > does not work here.   Need to edit the patch directly to apply.
>>> > 2. Makefile at gtm_ctl is rejected.
>>> >
>>> > 1. is not an issue.
>>> >
>>> > Nikhil, could you provide Makefile diffs for the master (I don't think
>>> > we need other changes to it) ?
>>> >
>>> > Regards;
>>> > ----------
>>> > Koichi Suzuki
>>> >
>>> >
>>> > 2013/2/1 Koichi Suzuki <koi...@gm...>:
>>> >> Thanks.   I will test this with 1.0 and see if it is applicable to
>>> >> master as well.   I hope it is :-)
>>> >>
>>> >> Appreciate for fixing app name for gtm_standby too.
>>> >>
>>> >> Regards;
>>> >> ----------
>>> >> Koichi Suzuki
>>> >>
>>> >>
>>> >> 2013/1/31 Nikhil Sontakke <ni...@st...>:
>>> >>> Talk about barking up the wrong tree ;)
>>> >>>
>>> >>> I was working with PGXC 1.0 tree. So the earlier sent out patch
>>> >>> applies against it.
>>> >>>
>>> >>> PFA, another patch which applies against MASTER.
>>> >>>
>>> >>> Regards,
>>> >>> Nikhils
>>> >>>
>>> >>> On Thu, Jan 31, 2013 at 5:16 PM, Nikhil Sontakke <ni...@st...> wrote:
>>> >>>> Additionally I also fixed a bug in invoking gtm_standby via gtm_ctl.
>>> >>>> It would blindly append gtm_standby as the name for the binary to
>>> >>>> invoke.
>>> >>>>
>>> >>>> Regards,
>>> >>>> Nikhils
>>> >>>>
>>> >>>> On Thu, Jan 31, 2013 at 5:11 PM, Nikhil Sontakke <ni...@st...> wrote:
>>> >>>>> Hi,
>>> >>>>>
>>> >>>>> PFA, patch which fixes this issue in the master git repo.
>>> >>>>>
>>> >>>>> The behavior is now similar to pg_ctl. Additionally the version
>>> >>>>> checking was missing in gtm_ctl, gtm and gtm_proxy. I added the same
>>> >>>>> as well. The binaries will be checked for version compatibility as
>>> >>>>> well now which is always a good thing.
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Nikhils
>>> >>>>>
>>> >>>>> On Thu, Jan 31, 2013 at 12:40 PM, Nikhil Sontakke <ni...@st...> wrote:
>>> >>>>>>>
>>> >>>>>>> +1. It will be better if we can make it consistent with pg_ctl. We should be
>>> >>>>>>> able to search gtm/proxy binary in the same place where gtm_ctl resides, no
>>> >>>>>>> ?
>>> >>>>>>>
>>> >>>>>>
>>> >>>>>> Yes. The pg_ctl code will provide enough inspiration for a generic
>>> >>>>>> binary search based on relative path as well.
>>> >>>>>>
>>> >>>>>> Regards,
>>> >>>>>> Nikhils
>>> >>>>>> --
>>> >>>>>> StormDB - http://www.stormdb.com
>>> >>>>>> The Database Cloud
>>> >>>>>> Postgres-XC Support and Service
>>> >>>>>
>>> >>>>>
>>> >>>>>
>>> >>>>> --
>>> >>>>> StormDB - http://www.stormdb.com
>>> >>>>> The Database Cloud
>>> >>>>> Postgres-XC Support and Service
>>> >>>>
>>> >>>>
>>> >>>>
>>> >>>> --
>>> >>>> StormDB - http://www.stormdb.com
>>> >>>> The Database Cloud
>>> >>>> Postgres-XC Support and Service
>>> >>>
>>> >>>
>>> >>>
>>> >>> --
>>> >>> StormDB - http://www.stormdb.com
>>> >>> The Database Cloud
>>> >>> Postgres-XC Support and Service
>>> >>>
>>> >>> ------------------------------------------------------------------------------
>>> >>> Everyone hates slow websites. So do we.
>>> >>> Make your web apps faster with AppDynamics
>>> >>> Download AppDynamics Lite for free today:
>>> >>> http://p.sf.net/sfu/appdyn_d2d_jan
>>> >>> _______________________________________________
>>> >>> Postgres-xc-general mailing list
>>> >>> Pos...@li...
>>> >>> https://lists.sourceforge.net/lists/listinfo/postgres-xc-general
>>> >>>
>>>
>>>
>>>
>>> --
>>> StormDB - http://www.stormdb.com
>>> The Database Cloud
>>> Postgres-XC Support and Service
>
>
>
> --
> StormDB - http://www.stormdb.com
> The Database Cloud
> Postgres-XC Support and Service