Menu

[r68]: / trunk / PhpCheckstyle / test / bad.php  Maximize  Restore  History

Download this file

154 lines (110 with data), 3.2 kB

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
<?php
/**
* This file is an exemple of PHP file containing bad style (according to the default ruleset).
*/
class BadTest {
?>
<?= "NoShortTags"; ?>
<?php echo "This is a very long line xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"; ?>
<? // The open tag should be <?php
define("constant", 100); // Incorrect constant naming
define("__BADLY_FORMATttedConstant123%", "Testing regex '%s'.\n");
$TOTO; // Incorrect variable naming
$Toto; // Incorrect variable naming
$to_to; // Incorrect variable naming
// Docblock is missing
function toto() { // Curly brace should be on same line
if ($test) {
}
if ($a AND $b) { // Use logical operators
}
if ($a == $b)
echo $b; // whitespaces are missing // braces are missing
if ($a == $b) { // no space before closing parenthesis
} else { // else should be on the same line
echo $c;
}
if ($a == $b) { // no space after opening parenthesis
}
if ($a == $b) {
b;
} // closing curly should be on the next line
$a; // no space before a semicolon
if (true) { // unnecessary if
}
echo " toto $a "; // avoid variables inside strings
$a = $a - $b; // We should have spaces around the -
$a = $a * $b; // We should have spaces around the *
$a = $a && $b;
;
# Shell / Perl comments are forbidden
@doSomething(); // Errors should not be silenced
exec('toto'); // Forbidden function
if ($u++) { // Unary operators should be on a single line
}
switch ($text) {
case "a":
// break is missing
case "b":
break;
case "c":
break;
// default is missing
}
$z = $HTTP_POST_VARS; // deprecated predefined variables
}
/**
* TODO : // This is a TODO
*/
private function privateFunction($a) { // should have a underscore because it is private
// no space after function name
// unused function parameter $a
}
/**
*
*/
protected function _protectedFunction($a) { // should not have a underscore because it is protected
$a;
}
/**
*
*/
public function publicFunction(&$toto) { // parameter passed by reference
return $a; // the returned parameter should be documented
$a = 0; // unused code
}
/**
* @param a
* @param b
*/
public function publicFunctionBad($a = false, $b) { // default value should be at the end
if ($a = $b) { // inner assignment instead of comparison
echo $a;
}
}
/**
* Function having an exception.
*
*/
public function FunctionWithException() { // Function naming incorrect
try {
// do something
throw $e; // Throw an exception that is not documented
} catch (Exception $e) {
// Empty catch block
}
}
<<<EOT
heredoc syntax should be avoided
EOT
}
// No docblock
class BadTest2 { // 2 class declaration in the same file
while ($a < count($b)) { // Optimisation : store count($b) in a temp variable
}
throw new Exception('test');
// unreachable code
split($a); // deprecated function
}
// The closing tag is not a good idea
?>
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.