Re: [matplotlib-devel] Patch for matplotlib-py3

I thought the workflow/process of contributing to matplotlib did not change:

<http://www.mail-archive.com/mat...@li.../msg07849.html>
<http://matplotlib.sourceforge.net/faq/howto_faq.html#contributing-howto>

Christoph


On 3/17/2011 6:40 AM, Michael Droettboom wrote:
> I have added these as pull requests to matplotlib/matplotlib-py3.
>
> To save us all time and make it easier to do code review, you may want to follow the instructions here to create your own pull requests:
>
> http://matplotlib.github.com/devel/gitwash/development_workflow.html
>
> Cheers,
> Mike
>
> ________________________________________
> From: Christoph Gohlke [cg...@uc...]
> Sent: Wednesday, March 16, 2011 3:01 PM
> To: matplotlib development list
> Subject: [matplotlib-devel] Patch for matplotlib-py3
>
> Hello,
>
> please consider the attached patch for the matplotlib-py3 fork on
> github. It corrects some build and test failures and removes unnecessary
> 'extern "C"' statements from PyMODINIT_FUNC functions.
>
>   From<http://docs.python.org/release/2.6.6/extending/extending.html>:
> Note that PyMODINIT_FUNC declares the function as void return type,
> declares any special linkage declarations required by the platform, and
> for C++ declares the function as extern "C".
>
> Christoph
>
>