From: Benjamin R. <ben...@ou...> - 2010-10-28 16:14:39
|
On Thu, Oct 28, 2010 at 9:55 AM, John Hunter <jd...@gm...> wrote: > On Thu, Oct 28, 2010 at 9:05 AM, Benjamin Root <ben...@ou...> wrote: > > > Just as a quick question that I would like to throw out. It isn't a bug, > > but rather an aesthetics issue that I caused for the version 1.0 release. > > > > With allowing 3d plots to be made subplottable, the margins for the plot > > area became a lot smaller than for the original method of producing 3d > > plots. This is because of the default region for subaxes, which usually > > matches the plotting region for a normal plot. However, 3d plots have > been > > explicitly setting the viewing area to take up the entire axes rather > than > > obeying the rcParams. With subplotting (or even creating a single plot > > using fig.gca() ), the rcParams override the explicit setting of the plot > > area. Therefore, 3d plots appear "squished" if created using the > > projection='3d' approach. > > > > My question is this: Would it at all be feasible (or even desirable) to > have > > some sort of ability to specify defaults that are specific to a > particular > > axes type? Currently, the code for setting the parameters will grab the > > rcparams if the figure is being newly created, or will copy the > parameters > > from an existing figure in the case of creating subplots in an existing > > figure. This assumes a one-size-fits-all which 3d plots might need to be > an > > exception. > > Punting on the larger question.... others may have an opinion. > > If it is a feature not a bug, can you commit new baseline images for > the buildbot and see if we can get it to go green? > > JDH > The current test failures appear to be related to changes made to pcolormesh, and nothing to do with mplot3d. As for the mplot3d images, the documentation images were updated, and I think I updated all of the code and documentation. I don't think the test suite checks those, does it? Oddly enough, I can't seem to find any test code for mplot3d (looks like another item to add onto my todo list...). Ben Root |