Fuse - the Free Unix Spectrum Emulator / Patches / #384 Little changes around disk ui

#384 Little changes around disk ui

Milestone: future

Status: open

Owner: Fredrick Meunier

Labels: disk (4)

Priority: 5

Updated: 2017-02-08

Created: 2017-01-21

Creator: Gergely Szasz

Private: No

menu.c:
- menu_disk_detail(): add some new "detail text" (inserted, inserted WP, etc) to indicate "dirty", changed disk
disk.c:
- disk_new(): mark new disks as dirty
uimedia.c:
- drive_save() and ui_media_drive_save(): remove two unnecessary check which prevent to save disk image second (third, etc..) time
- drive_disk_write(): check if file exists, and ask user about overwrite

1 Attachments

diff.disk_01.patch

Discussion

Gergely Szasz - 2017-01-22

Here is a new, bigger patch:
as previous plus:
- add a "new" ui_confirm_save_specific() dialog - without [Cancel] button
- if there is no meaning of 'cancel' - uses this: Save/Don't save query
- add "overwrite query" to "tape" and "microdrive" code.

diff.disk_02.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2017-02-05

assigned_to: Fredrick Meunier
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2017-02-05

Hi Gergely,
I have been delayed by looking at the release but I expect to get to merging more of this during the week.

Thanks,
Fred

Last edit: Fredrick Meunier 2017-02-05

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Gergely Szasz - 2017-02-06
  
  Thanks!
  I can't test the Win32 UI, but its looks so straightforward...
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fredrick Meunier - 2017-02-08

Thanks for the patch, I started looking at the 'add "overwrite query" to "tape" and "microdrive" code' part of the patch and I've tweaked it a bit so far like the attached.

So far I've noticed:

tape_close() now checks the return code from ui_tape_write() is 1 before returning error in the UI_CONFIRM_SAVE_SAVE case but ui_tape_write() is only returns 0 or 1 and doesn't return state from tape_write() if that is wanted?

ui_confirm_save() will say not to save if the confirm actions option is off - confirming turned off on an overwrite check should probably mean overwrite instead

confirm_overwrite.patch
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Little changes around disk ui

Group

Searches

Help

#384 Little changes around disk ui

Discussion