Hi BogDan,
I'd like to avoid as many conditional includes as possible, could you talk some more about the need to remove the #include <stdlib.h> from libspectrum.h.in and add it to libspectrum/memory.c and add limits.h to fuse/compat.h?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Can you provide info how do you compile Spectacol ?
What is the extend of difference between Fuse and Spectacol ?
I might be able to create GitHub build workflow for you, to benefit both you and also Fuse when playing with possible least-effort compromises to reunite both repos (to some meaningful extend).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I wouldn't be so confident in those changes, for example the libspectrum patch causes these following warnings on the Mac[1] .
You can see a subset of the platforms that Fuse has been compiled on on the website, you can add at least Solaris, SunOS and HP-UX to that list. I'd like to minimise changes to includes to just those that are needed so that we keep them all as healthy as possible especially as we don't have easy access to restest them.
it would really help if you could be specific about what symbols are causing problems for you on Android and that are leading to these changes being suggested so that we can work together to find a suitable patch that we can integrate in the core. I don't think the current version is suitable as it stands.
[1]
32 libspectrum.c:204 col 42: warning: implicitly declaring library function 'abort' with type 'void (void) __attribute__((noreturn))' [-Wimplicit-function-declaration]
35 libspectrum.c:204 col 42: note: include the header <stdlib.h> or explicitly provide a declaration for 'abort'
57 pzx_read.c:118 col 21: warning: implicit declaration of function 'bsearch' is invalid in C99 [-Wimplicit-function-declaration]
60 pzx_read.c:118 col 5: warning: cast to 'struct info_t *' from smaller integer type 'int' [-Wint-to-pointer-cast]
207 myglib/garray.c:43 col 5: warning: implicitly declaring library function 'abort' with type 'void (void) __attribute__((noreturn))' [-Wimplicit-function-declaration]
210 myglib/garray.c:43 col 5: note: include the header <stdlib.h> or explicitly provide a declaration for 'abort'
235 test/test.c:788 col 19: warning: implicit declaration of function 'atoi' is invalid in C99 [-Wimplicit-function-declaration]
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi BogDan,
I'd like to avoid as many conditional includes as possible, could you talk some more about the need to remove the #include <stdlib.h> from libspectrum.h.in and add it to libspectrum/memory.c and add limits.h to fuse/compat.h?
Well, without these includes I can't compile it on Android :) I also think the inclused are safe for all platforms.
Hi!
Can you provide info how do you compile Spectacol ?
What is the extend of difference between Fuse and Spectacol ?
I might be able to create GitHub build workflow for you, to benefit both you and also Fuse when playing with possible least-effort compromises to reunite both repos (to some meaningful extend).
I wouldn't be so confident in those changes, for example the libspectrum patch causes these following warnings on the Mac[1] .
You can see a subset of the platforms that Fuse has been compiled on on the website, you can add at least Solaris, SunOS and HP-UX to that list. I'd like to minimise changes to includes to just those that are needed so that we keep them all as healthy as possible especially as we don't have easy access to restest them.
it would really help if you could be specific about what symbols are causing problems for you on Android and that are leading to these changes being suggested so that we can work together to find a suitable patch that we can integrate in the core. I don't think the current version is suitable as it stands.
[1]