Menu

#43 Tab order in URL settings dialog incorrect (and OT: build process)

Verified
nobody
None
Medium
Defect
2008-07-02
2008-04-12
Anonymous
No

Originally created by: h.heimbu...@gmx.net
Originally owned by: tortoisesvn

What steps will reproduce the problem?
1. Edit a project.
2. Focus the 'password' textfield.
3. Press TAB.

What is the expected output? What do you see instead?
The OK button is focused, but the 'Ignore own commits' checkbox should be.

What version of the product are you using? On what operating system?
WinXP SP2, trunk [r267]

Please provide any additional information below.
I fixed that in the appended patch file (although you could probably fix it
much quicker on your own ;)). The patch file contains two more suggested
minor changes:
a) The 'username' and 'password' fields no longer run out of the 'URL
settings' groupbox.
b) The dialog title is 'Edit project settings' instead of 'URL settings',
which imho is closer to what it does.

Personally, I'd also like the 'URL' and 'Project name' fields to change
places. It's more intuitive to me to type the project name first, then
enter the URL. (Actually, it's what I also do before realizing my mistake.)
   

I couldn't find your e-mail address or a CommitMonitor related
forum/mailing list and didn't want to spam the TSVN list, so I'll (mis-)use
this place for some additional notes regarding the build process:

First of all, it might be interesting to hear that -- after figuring how to
do it right ;) -- CommitMonitor builds fine on VS2008.

To avoid the trouble of compiling Boost myself, I used the binary installer
at http://www.boost-consulting.com/products/free (only 1.34.1 yet). I
wasn't sure which binaries are needed, though. (Multithreaded or
singlethreaded, DLL or static, etc.) Would be great if you could add that
to your build.txt.

It took me a while to figure out that I have to run "nant debug setup" once
to build the dependencies and can then use VS. I tried "nant CommitMonitor"
first because I had no interest in building the installer, which of course
failed.

Although that's quite obvious to me in retrospect, maybe you could also add
a line that the configuration (debug/release) *should* be specified and
that it must match the configuration used in VS.

I also had some problems figuring out that the paths to the libs and
headers of Boost *have* to be added to the global "VC++ Directories" in VS.
I tried to add them to the project configuration instead. Then again,
that's probably mostly related to me not having used NAnt before.

1 Attachments

Discussion

  • Anonymous

    Anonymous - 2008-04-14

    Originally posted by: tortoisesvn

    starting

    Owner: tortoisesvn
    Status: Started

     
  • Anonymous

    Anonymous - 2008-04-14

    Originally posted by: tortoisesvn

    Fixed the tab order in [r268].

    About compiling boost: I like to use the tr1::regex which is available in the VS2008
    feature pack soon. Which means I'll get rid of using the boost regex.

    And you're right, the docs on how to build the CommitMonitor could be improved. Care
    to send a patch?

    Status: Fixed

     
  • Anonymous

    Anonymous - 2008-04-14

    Originally posted by: h.heimbu...@gmx.net

    I don't exactly feel like being an expert on that topic, but I'll send you a patch
    suggestion at the weekend. Small steps are better than nothing. :)

    I guess I should open up a new issue then after all.

     
  • Anonymous

    Anonymous - 2008-04-20

    Originally posted by: h.heimbu...@gmx.net

    I see you already made those changes to the build docs. Good job, I think it's a lot
    clearer now!

    (I'm still struggling with the installation of the MFC Feature Pack, but that's not
    your fault, of course. :) )

     
  • Anonymous

    Anonymous - 2008-04-23

    Originally posted by: h.heimbu...@gmx.net

    Thanks, I figured the part about changing the regional settings out very quickly, but
    the installer was always freezing on me in the middle. It was simply related to the
    disk being full, something the installer apparently considered too obvious to require
    a message (or even some kind of action, it just froze up, not even the cancel button
    triggered any activity).
    Anyway, it works now, and I can build CommitMonitor again.

    One more thing about the build process, though. The document now states that you have
    to run "nant [debug|release] Subversion" and then open and build the solution. That's
    *not* possible, though. You're missing the version.h, which will for example be built
    if you're running "nant msi" (even if that fails because you haven't built the core
    components with VS yet).

    If my still very limited understanding of NAnt is correct, that is because, while the
    targets 'msi' and 'CommitMonitor' depend on the target 'VersionInfo', the target
    'Subversion' does not.

     
  • Anonymous

    Anonymous - 2008-04-24

    Originally posted by: tortoisesvn

    Fixed the NAnt dependency of the 'Subversion' target in [r276].

     
  • Anonymous

    Anonymous - 2008-07-02

    Originally posted by: tortoisesvn

    (No comment was entered for this change.)

    Status: Verified

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.