Originally created by: carsonho...@gmail.com
Originally owned by: tortoisesvn
What steps will reproduce the problem?
1. In the Edit Project Dialog box, the "Max. No. of log entries to keep
field" is limited to 1000. Using a larger value appears to work; but the
next time you bring up the dialog box it says 1000.
2. The Options dialog box has a field "Number of log messages to fetch for
new projects:" which is not limited to 1000.
What is the expected output? What do you see instead?
1) The dialog box should warn you when it is not going to keep the value
you enter.
2) The "number of logs to keep" should accept the same range of values
as "number to fetch for new projects".
3) Maybe number of logs to keep should default to the value set
for "number to fetch for new projects".
What version of the product are you using? On what operating system?
1.6.2.426 - Windows Vista SP2
Please provide any additional information below.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: tortoisesvn
We have to set a max limit for log messages to keep. Otherwise loading/saving the
data takes way too long, and also the main goal of the project is at stake: keeping
the RAM usage to a minimum.
I'll add a warning if the value is out of range.
Owner: tortoisesvn
Status: Started
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: tortoisesvn
(No comment was entered for this change.)
Labels: Milestone-1.6.3
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: tortoisesvn
This issue was closed by [r436].
Status: Fixed
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: ludo.ael...@gmail.com
This doesn't seem to work in version 1.6.7.509: if I create a new project, fill in the details and enter a number above 1000, then click 'ok', nothing happens. I can click 'ok' as much as I want, but the dialog box for the new project doesn't go away.
When I click 'cancel', however, the dialog box goes away, and it turns out the the new project was saved anyway. If I look at its properties, it has "max no. of entries" set to 1000.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: tortoisesvn
works fine for me: if I enter e.g, 2000 and then click the OK button, it shows a message balloon telling me that the maximum is 1000.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: ludo.ael...@gmail.com
Weird, I can reproduce this every time.
Just upgraded to 1.6.8.532, still perfectly reproducable. What would be the best way to determine the cause for this? Run it through WinDbg? But I'd need versions of the CommitMonitor containing debug info for that, if I'm not mistaken.
(This is Windows XP Pro SP3, by the way.)
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: tortoisesvn
Did you maybe disable the balloons on your system? That might be a possible reason why you don't see them.
With WinDbg you wouldn't see much.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: ludo.ael...@gmail.com
AFAIK I didn't disable "balloons", I don't even know what those are :-). Wanted to see if they were enabled, Windows Help doesn't turn up anything about them. Is that maybe a post-XP feature?
If you're talking about those little message notification things which sometimes appear out of the system tray, other applications do have that on my machine.
Regardless, is it normal behaviour that the 'Cancel' button saves the new project? (Note that this only happens because I've already clicked 'Ok', although the 'Ok' button doesn't close the dialog).
Maybe a better way to do this would be to check when the textbox for "max no of entries" loses focus whether its value is over 1000 and, if so, change it to 1000. Displaying an informative balloon about doing this is of course still a good idea, but that way everything will also work perfectly for those who have balloons disabled.
Or maybe even change the label from "max no of log entries to keep:" to "No. of log entries to keep (max 1000):". This way it's obvious to even the balloon-less people what's happening.
Thanks BTW for creating this great light-weight tool!