CodeSnip Old Code (SVN)

Added Initialise and Finalise methods to ISearchFilter and provided implementations. Mainly for use in XRef searches to correct potential bug introduced in rewrites where repeated search would miss any new XRefs added to a snippet.

Removed unused units.
Changed call to FreeAndNil to direct call to .Free.

Changed use of "criteria" to "filter" in various identifiers in USearch unit and in using code to better reflect purpose of the names. Made changes to affected code.

Removed IStoredSelectionSearchCriteria interface: using ISelectionSearchCriteria instead.
Removed redundant TSearchCriteriaFactory.CreateSelectionSearchCriteria method overload and renamed other overload as CreateManualSelectionSearchCriteria.
Updated all affected code as required.

XMLDoc commented unit.

Made all methods that implement interfaces public.
Changed some other class visibility.
Used var keyword for field variables of classes.

Pulled duplicate code down from TSelectionSearchCriteria and TStoredSelectionSearchCriteria into new common base class, TBaseSelectionSearchCriteria.

Rationalised TSearchFactory: replaced all search specific methods except CreateNulSearch with new generic CreateSearch.
Revised calling code to call CreateSearch.
Reimplemented CreateNulSearch to call CreateSearch internally.

Collapsed all TSearch derived classes into single TSearch class, which was made final.
Changed TSearchFactory accordingly.

Removed redundant interface and method from USearch.
Moved check for a null search from ISearch to ISearchCriteria and changed calling code accordingly.
Revised TSearch and descendants to directly call ISearchCriteria.Match to match required records instead of indirectly. Match abstract method of TSearch removed accordingly.