Active Repositories
Recent Activity
Today
In D47643#1086284, @imp wrote:I've wanted for years to have nanobsd not need root at all...
Assert that we enter pcm_killchans() with !PCM_REGISTERED.
I've wanted for years to have nanobsd not need root at all...
OK, I'll re-submit following that approach.
I kinda think we should ditch this size altogether and nake minimal images by default. 8g is too big, imho, for a default that uses only 1/8 of that. Of we just use growfs and makefs/mkimg, we'll be good
@imp expressed the possibility of implementing options similar to the ones in D43232 (https://github.com/freebsd/freebsd-src/pull/964#issuecomment-1872262987). While this is evidently an interesting option, I have opted to propose just a "bump" to the minimum default size. Default meaning having no *_OPTIONS.
At some point this will be inevitable, currently the command sh nanobsd.sh with no custom configuration, fails. Presumably someone creating a customized image would have options set accordingly. More importantly, it is likely that the NANO_MEDIASIZE is set to match the size of the physical card. Industrial cards with 8GB or more seem to be the norm, after a little market research.
At any rate, this is just a suggestion, and I will gladly implement the maintainer's recommendations. What is paramount for me would be to fix sh nanobsd.sh before asking doc for a review of D47634.
Yesterday
On the "-10dbV" problem I could suggest to rename this to "minus10dbv" (and "plus4dbu as well).
(Note that default setting (-10dBV) is loudest, then +4dbU is lower, and HighGain is lowest volume)
Interesting, should be the other way round. The linux code doesn't seem to label these explicitly, which is why I expected the 0 value to be safe (quiet) similar to HDSP 9632. Chances are the input and output levels work the same and are in wrong order too, could you check them?
While studying for D47502, I stumbled upon the save-entropy.sh script. This part of the script seems wrong to me.
What I can infer is that this tries to guard against failing a comparison with a non-digit on the next line, by checking that whatever comes after saved-entropy. is a digit. Currently it is only checking for saved-entropy.\* (a literal *).
I don't know whom to ask for review. This change is low-priority, as it only verifies correctness, only root can write to the $entropy_dir.
Thank you!
I'd suggest we not do this, at least not before quantifying the performance impact of float support (see comment in D47638).
i can confirm so far that it works fine with emulators/wine.
In D47462#1086107, @christos wrote:In D47462#1085187, @dev_submerge.ch wrote:The refactored implementation of pcm_killchans() relies on the SD_F_REGISTERED flag (unset) to prevent addition of new channels, right? Should we make this explicit via assert or a comment?
While it wouldn't do any harm to assert that !PCM_REGISTERED, I do not really think it's necessary, since pcm_killchans() is only called from pcm_unregister() once we clear the flag.
Cycles to perform a 2MB aligned vm_page_alloc_contig() for shm_create_largepage():
x base
+ iter
+------------------------------------------------------------------------------+
| + x |
| ++ x |
| ++ xx |
| ++++ + xxx xx x|
||_MA___| |__MA____| |
+------------------------------------------------------------------------------+
N Min Max Median Avg Stddev
x 10 16813 17866 16989.5 17074.6 294.94715
+ 10 12691 13496 12759 12833.1 239.58643
Difference at 95.0% confidence
-4241.5 +/- 252.466
-24.841% +/- 1.2701%
(Student's t, pooled s = 268.696)