Re: Fast COPY FROM based on batch insert
| От | Andrey Lepikhov |
|---|---|
| Тема | Re: Fast COPY FROM based on batch insert |
| Дата | |
| Msg-id | [email protected] обсуждение исходный текст |
| Ответ на | Re: Fast COPY FROM based on batch insert (Etsuro Fujita <[email protected]>) |
| Ответы |
Re: Fast COPY FROM based on batch insert
|
| Список | pgsql-hackers |
On 10/12/22 07:56, Etsuro Fujita wrote: > On Tue, Oct 11, 2022 at 3:06 PM Andrey Lepikhov > <[email protected]> wrote: >> I reviewed the patch one more time. Only one question: bistate and >> ri_FdwRoutine are strongly bounded. Maybe to add some assertion on >> (ri_FdwRoutine XOR bistate) ? Just to prevent possible errors in future. > > You mean the bistate member of CopyMultiInsertBuffer? Yes > > We do not use that member at all for foreign tables, so the patch > avoids initializing that member in CopyMultiInsertBufferInit() when > called for a foreign table. So we have bistate = NULL for foreign > tables (and bistate != NULL for plain tables), as you mentioned above. > I think it is a good idea to add such assertions. How about adding > them to CopyMultiInsertBufferFlush() and > CopyMultiInsertBufferCleanup() like the attached? In the attached I > updated comments a bit further as well. Yes, quite enough. -- Regards Andrey Lepikhov Postgres Professional
В списке pgsql-hackers по дате отправления: