pgsql: Show Parallel Bitmap Heap Scan worker stats in EXPLAIN ANALYZE - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Show Parallel Bitmap Heap Scan worker stats in EXPLAIN ANALYZE
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Show Parallel Bitmap Heap Scan worker stats in EXPLAIN ANALYZE

Nodes like Memoize report the cache stats for each parallel worker, so it
makes sense to show the exact and lossy pages in Parallel Bitmap Heap Scan
in a similar way.  Likewise, Sort shows the method and memory used for
each worker.

There was some discussion on whether the leader stats should include the
totals for each parallel worker or not.  I did some analysis on this to
see what other parallel node types do and it seems only Parallel Hash does
anything like this.  All the rest, per what's supported by
ExecParallelRetrieveInstrumentation() are consistent with each other.

Author: David Geier <[email protected]>
Author: Heikki Linnakangas <[email protected]>
Author: Donghang Lin <[email protected]>
Author: Alena Rybakina <[email protected]>
Author: David Rowley <[email protected]>
Reviewed-by: Dmitry Dolgov <[email protected]>
Reviewed-by: Michael Christofides <[email protected]>
Reviewed-by: Robert Haas <[email protected]>
Reviewed-by: Dilip Kumar <[email protected]>
Reviewed-by: Tomas Vondra <[email protected]>
Reviewed-by: Melanie Plageman <[email protected]>
Reviewed-by: Donghang Lin <[email protected]>
Reviewed-by: Masahiro Ikeda <[email protected]>
Discussion: https://postgr.es/m/b3d80961-c2e5-38cc-6a32-61886cdf766d%40gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5a1e6df3b84c91957f80b19edb497a5eec83c403

Modified Files
--------------
src/backend/commands/explain.c            |  58 ++++++++++++++---
src/backend/executor/execParallel.c       |   3 +
src/backend/executor/nodeBitmapHeapscan.c | 105 +++++++++++++++++++++++++++---
src/include/executor/nodeBitmapHeapscan.h |   1 +
src/include/nodes/execnodes.h             |  35 ++++++++--
src/tools/pgindent/typedefs.list          |   2 +
6 files changed, 181 insertions(+), 23 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: Re: pgsql: Teach planner how to estimate rows for timestamp generate_series
Next
From: Fujii Masao
Date:
Subject: pgsql: Fix limit block handling in pg_wal_summary_contents().