pgsql: Fix incorrect error message for IDENTIFY_SYSTEM - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Fix incorrect error message for IDENTIFY_SYSTEM
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Fix incorrect error message for IDENTIFY_SYSTEM

Commit 5a991ef8692e accidentally reversed the order of the tuples
and fields parameters, making the error message incorrectly refer
to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and
3 or 4 fields. Fix by changing the order of the parameters.  This
also adds a comment describing why we check for < 3 when postgres
since 9.4 has been sending 4 fields.

Backpatch all the way since the bug is almost a decade old.

Author: Tomonari Katsumata <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Bug: #18224
Backpatch-through: v12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1ce2986795eb6ac4de32da835087ea1d486fbfa3

Modified Files
--------------
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix incorrect error message for IDENTIFY_SYSTEM
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix incorrect error message for IDENTIFY_SYSTEM