Avoid using internal test methods in SSL tests
The SSL tests for pg_ctl restart with an incorrect key passphrase used
the internal _update_pid method to set the pidfile after running pg_ctl
manually instead of using the supplied ->restart method. This refactors
the ->restart method to accept a fail_ok parameter like how ->start and
->stop does, and changes the SSL tests to use this instead. This removes
the need to call internal test module functions.
Reviewed-by: Melih Mutlu <[email protected]>
Reviewed-by: Heikki Linnakangas <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/33774978c78175095da9e6c276e8bcdb177725f8
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 31 +++++++++++++++++++++++--------
src/test/ssl/t/001_ssltests.pl | 23 +++++++++--------------
2 files changed, 32 insertions(+), 22 deletions(-)
