pgsql: Fix incorrect logic in plan dependency recording - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Fix incorrect logic in plan dependency recording
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Fix incorrect logic in plan dependency recording

Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test.  This meant
that we'd record a dependency only when the function's Oid was
InvalidOid.  Clearly this was meant to *not* record the dependency in
that case.

50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.

Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6341cb0b02ae16d7bbb8b4e7ebabf80c551a685e

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix incorrect logic in plan dependency recording
Next
From: Michael Paquier
Date:
Subject: pgsql: Refactor error messages for unsupported providers in pg_locale.c