pgsql: Postpone calls of unsafe server-side functions in pg_dump. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Postpone calls of unsafe server-side functions in pg_dump.
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Postpone calls of unsafe server-side functions in pg_dump.

Avoid calling pg_get_partkeydef(), pg_get_expr(relpartbound),
and regtypeout until we have lock on the relevant tables.
The existing coding is at serious risk of failure if there
are any concurrent DROP TABLE commands going on --- including
drops of other sessions' temp tables.

Back-patch of commit e3fcbbd62.  That's been in v15/HEAD long enough
to have some confidence about it, so now let's fix the problem in
older branches.

Original patch by me; thanks to Gilles Darold for back-patching
legwork.

Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/344b7849200fab474e647b43fd353fad37004941

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 150 +++++++++++++++++++++++++---------------------
src/bin/pg_dump/pg_dump.h |   4 +-
2 files changed, 84 insertions(+), 70 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Fix typos and bump catversion.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: sync src/tutorial/basics.source with SGML documentation.