pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion l
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Add CHECK_FOR_INTERRUPTS in ExecInsert's speculative insertion loop.

Ordinarily the functions called in this loop ought to have plenty
of CFIs themselves; but we've now seen a case where no such CFI is
reached, making the loop uninterruptible.  Even though that's from
a recently-introduced bug, it seems prudent to install a CFI at
the loop level in all branches.

Per discussion of bug #17558 from Andrew Kesper (an actual fix for
that bug will follow).

Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/963a6b6fa45d8f7627c14be7295f709ef92204f5

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add proper regression test for the recent SRFs-in-pathkeys probl
Next
From: Robert Haas
Date:
Subject: pgsql: Revert recent changes to 002_pg_upgrade.pl.