pgsql: Fix ALTER TABLE ADD COLUMN ... - Mailing list pgsql-committers

Log Message:
-----------
Fix ALTER TABLE ADD COLUMN ... PRIMARY KEY so that the new column is correctly
checked to see if it's been initialized to all non-nulls.  The implicit NOT
NULL constraint was not being checked during the ALTER (in fact, not even if
there was an explicit NOT NULL too), because ATExecAddColumn neglected to
set the flag needed to make the test happen.  This has been broken since
the capability was first added, in 8.0.

Brendan Jurd, per a report from Kaloyan Iliev.

Tags:
----
REL8_2_STABLE

Modified Files:
--------------
    pgsql/src/backend/commands:
        tablecmds.c (r1.206.2.3 -> r1.206.2.4)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.206.2.3&r2=1.206.2.4)
    pgsql/src/test/regress/expected:
        alter_table.out (r1.99 -> r1.99.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/alter_table.out?r1=1.99&r2=1.99.2.1)
    pgsql/src/test/regress/sql:
        alter_table.sql (r1.55 -> r1.55.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/alter_table.sql?r1=1.55&r2=1.55.2.1)