Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Correct some code in pg_restore when reading the header of a tar - Mailing list pgsql-committers

From [email protected] (Neil Conway)
Subject pgsql: Correct some code in pg_restore when reading the header of a tar
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Correct some code in pg_restore when reading the header of a tar archive:

(1) The code doesn't initialize `sum', so the initial "does the checksum
    match?" test is wrong.

(2) The loop that is intended to check for a "null block" just checks
    the first byte of the tar block 512 times, rather than each of the
    512 bytes one time (!), which I'm guessing was the intent.

It was only through sheer luck that this worked in the first place.

Per Coverity static analysis performed by EnterpriseDB.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
    pgsql/src/bin/pg_dump:
        pg_backup_tar.c (r1.38 -> r1.38.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_tar.c.diff?r1=1.38&r2=1.38.2.1)

pgsql-committers by date:

Previous
From: [email protected] (Neil Conway)
Date:
Subject: pgsql: Correct some code in pg_restore when reading the header of a tar
Next
From: [email protected] (Neil Conway)
Date:
Subject: pgsql: Fix bug in CONTINUE statement for PL/pgSQL: when we continue a