Change Details

**List of steps to reproduce** * Be logged-in on Wikidata * Go to https://www.wikidata.org/w/index.php?title=Q42&oldid=581 * Maybe reload the page a couple of times **What happens?**: * There are (non-js) edit buttons for the Terms and Sitelinks. **What should have happened instead?**: * There should not be any edit-buttons of any kind on old revisions. **History**: * This originally broke and was fixed in context of {T95405}. * However, the related browser test was flaky and thus skipped after attempts to make it non-flaky failed, see: {T227266}. * Thanks to a new initiative to delete tests that are skipped sincefor more than a year (T280652, [patch](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/681408)), this test came into the spotlight again. * While trying to reenable it again in a non-flaky way, this regression was discovered. **ACs:** - after the fix create integration tests that make sure this does not happen (again)/does not go uncheked **Notes:** - There is [a test](https://github.com/wikimedia/Wikibase/blob/4cfd0db53729e7c29f44e2927586fc57cd337db3/repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php#L277) but it didn't catch the problem. We should make sure that this test (or a new one) can detect regressions of this sort in the future.

**List of steps to reproduce** * Be logged-in on Wikidata * Go to https://www.wikidata.org/w/index.php?title=Q42&oldid=581 * Maybe reload the page a couple of times **What happens?**: * There are (non-js) edit buttons for the Terms and Sitelinks. **What should have happened instead?**: * There should not be any edit-buttons of any kind on old revisions. **History**: * This originally broke and was fixed in context of {T95405}. * However, the related browser test was flaky and thus skipped after attempts to make it non-flaky failed, see: {T227266}. * Thanks to a new initiative to delete tests that are skipped sincefor more than a year (T280652, [patch](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/681408)), this test came into the spotlight again. * While trying to reenable it again in a non-flaky way, this regression was discovered. **ACs:** - after the fix create integration tests that make sure this does not happen (again)/does not go uncheked - reenable the browser test in a stable way (see [patch](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/683914), T227266) **Notes:** - There is [a test](https://github.com/wikimedia/Wikibase/blob/4cfd0db53729e7c29f44e2927586fc57cd337db3/repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php#L277) but it didn't catch the problem. We should make sure that this test (or a new one) can detect regressions of this sort in the future.

**List of steps to reproduce** * Be logged-in on Wikidata * Go to https://www.wikidata.org/w/index.php?title=Q42&oldid=581 * Maybe reload the page a couple of times **What happens?**: * There are (non-js) edit buttons for the Terms and Sitelinks. **What should have happened instead?**: * There should not be any edit-buttons of any kind on old revisions. **History**: * This originally broke and was fixed in context of {T95405}. * However, the related browser test was flaky and thus skipped after attempts to make it non-flaky failed, see: {T227266}. * Thanks to a new initiative to delete tests that are skipped sincefor more than a year (T280652, [patch](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/681408)), this test came into the spotlight again. * While trying to reenable it again in a non-flaky way, this regression was discovered. **ACs:** - after the fix create integration tests that make sure this does not happen (again)/does not go uncheked - reenable the browser test in a stable way (see [patch](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/683914), T227266) **Notes:** - There is [a test](https://github.com/wikimedia/Wikibase/blob/4cfd0db53729e7c29f44e2927586fc57cd337db3/repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php#L277) but it didn't catch the problem. We should make sure that this test (or a new one) can detect regressions of this sort in the future.