Github PR is merged, so closing this as resolved.

Link to related Github PR: https://github.com/benapetr/wikimedia-bot/pull/76

I will add this.

I have added tests. Thank you for offering me to work on this on IRC!

I will add tests for this extension

This fixed the issue! Thanks everyone for your help! Can we use extension-unittests-composer instead of extension-unittests-composer-non-voting now, if it works good?

While working on this, I have noticed that in some extensions (for example WikiLexicalData) some classes are outside includes directory (need to take this into account while grep-ing). Additionally, some files are not loaded with autoloader, but are required from other files with require_once. I am not sure what to do with those. Do we need to replace require_once with autoloading first?

After enabling phpcs I noticed that there are a lot of rule violations here. I decided that it will be better to exclude all failing rules now and then fix them part-by-part in next patches. This will make code style fixes easier to review and merge. Additionally, I faced internal CodeSniffer error which I reported in T185642.

Thank you for your work @Osnard! Can we close this as resolved once https://gerrit.wikimedia.org/r/#/c/405853/ is merged?

I will add this and fix code style issues if those will be detected

tests/wikibase_tests.py::TestRedirects::test_normal_item ERROR: Logged in as '192.0.2.42' instead of 'Pywikibot-test'. Forcing re-login.

Hm, taking this into account, I think that the simplest solution would be just to edit cassette and replace 192.168.0.2.42 with Pywikibot-test in request which is reponsible for logging in.
Another possible (and maybe more correct) solution would be to write a custom cassette serializer/deserializer, so needed value (name of user used to run the test) is placed in cassette automatically on load.

Looks like cassette which was recorded does not contain one of requests:

CannotOverwriteExistingCassetteException: No match for the request (<Request (GET) https://www.wikidata.org/w/api.php?maxlag=5&format=json&rawcontinue=&meta=userinfo&action=query&uiprop=blockinfo%7Cgroups%7Chasmsg%7Crights>)

@Reedy Thank you! Then I will abandon my changes to core and fix extensions instead.

@Anomie Thank you for giving links to those tasks! You are right, there is no need to split files now if general reogranization will be done. So can we close this task as "Declined"?

There are quite a lot of such files in core so to make things simplier to manage, review and merge I will split it into multiple patches (by directories)

I will work on fixing this

Okay. Thank you for your work @Goraf! I have tested it once again (changing from 1 to 0 fixes the problem) and will push a patch now.

@Goraf Your explanation of this seems to be right. Do you have any plans to continue working on this? Maybe to provide a patch?

@Goraf thank you, I will take a look at it!

Thank you for merging this! Hopefully we will get some feedback after deployment. If there are any other issues related to this - please tell and I will be happy to fix!

Thank you for reviewing and merging! Now we can continue our work on this page by improving layout on mobile devices in T182247.

I have just pushed a patch which improves page layout.

@Osnard Thank you for update on this!

I will add this!

Well, I checked some of extensions and see that there is only one call to WikiAdmin: WikiAdmin::registerModuleClass(...) and some i18n messages. So if WikiAdmin extension is no longer developed and used, I think we can just remove that to fix CI jobs. In fact, that's what was done in https://gerrit.wikimedia.org/r/#/c/383344/ mentioned by @Umherirrender
What are your thoughts on this? (Anyway, I totally agree - @Osnard definitely has more information on this)

Is this a missing dependency? I couldn't find a WikiAdmin class anywhere in Gerrit.

My initial assumption was that these extensions are missing WikiAdmin extension, which they are probably dependent on.
But looks like the code of that extension is not available anymore. (Gerrit project, Github mirror and Phabricator project no longer exist)

This also affects BlueSpiceInterWikiLinks extension

Change from extension-unittests-generic to extension-unittests-composer in test config (layout.yaml) to test against the extensions own composer dependency.

Hi! Here is the link to my blog post where I share my experience participating (in English): https://blog.phandev.net/posts/gci17

I decided to work on this! @D3r1ck01 thank you for recommending to take a look at it!

Both patches are merged, so we can close this as resolved.

I am not sure if this task needs to be closed, as there could possibly be some other features to work on! Anyway, we may create separate tasks if it will be needed or reopen and update this one.

Pull Request on Github: https://github.com/wiki-ai/wikiclass/pull/59

Can't we just check the new variable name too, and mark the old one as depreciated, as usual for code functions ?

The patch got merged, so we can close this as resolved!

Looks like there is one more minor problem with Makefile. enwiki_tuning_reports rule runs tuning_reports/enwiki.wp10.md and tuning_reports/enwiki.nettrom_wp10.md. But there is no rule for tuning_reports/enwiki.wp10.md (looks like it was removed in the past). However, related file exists.

This seems to be really interesting. I will work on it!

@Goraf thank you for links!

I decided that I will find the issue and fix it.

I guess it is a good idea to run test scripts locally which are responsible for a patch before committing it. It is no alternative to wait for hours until the verify tests are done.

@Phantom42, very thanks for investigation and explanation! Happy New Year!

Languages added by this change are:

See my comment in T179182 for details.

Completly nothing! This is best change!

Thank you for reporting this bug!

To integrate something where it sees all "High" priority tasks on Phabricator and if there's no activity on one for 3 days or such it pings staff and reminds them (not for WMF Phab)

@Aklapper I have just submitted a patch, which does all required setup and adds VCR for one test. After this is reviewed and merged, cloneable task on GCI can be created, which will ask students to convert one or two test classes from the list above to dry by using VCR. So here we can do basically the same way as we did with minus-x tasks. Anyway, @jayvdb can provide more information here :)

Closing this as resolved because the patch is merged now. This is one more step in making this extension better support score writing in different languages!

The first set to do would be TestItemBasePageMethods

Looks interesting! I will work on adding support for this.

I will provide a patch for this

I will add unit test for this!

I will add a test for this!

I added tests to check that basic types are correctly encoded (ApiFormatRaw does not work with arrays or objects). I also added test case to check that exception is thrown if mime type or text are not given.

Well, for this task we need to add one more test case to NewsletterAPIEditTest.php which is edited in that change pretty much. So obviously it is better to wait for that change to be merged to avoid merge conflicts and some other minor problems. Additionally, I see that there are some problems with Echo extension not being available during CI build. So it is better to wait for that to be solved before adding tests for removing publishers. Hopefully you understand what I mean and agree with those points.

I will add tests for this!

While working on this I noticed that this is blocked by https://gerrit.wikimedia.org/r/#/c/401189/ change. There is no sense to work on this until that change is merged. I also see that @Pppery did a lot of work here, so I think it would be better for me to abandon this task and return to it later or @Pppery may finish this. Good luck!

I will add this test case!

I will add test for this!

Thank you for reviewing and merging!

Have 2 wikis setup, one of which setup like "Commons" so it shares its files with a client wiki. They should be linked with Extension:GlobalUsage. Setting this up is probably the hardest part of the whole thing.

This task seems to be interesting. I will work on this!

I just claimed a task on GCI (PreferencesList and PreferencesMaster). I decided to check that extensions code and noticed that both repos are empty. Do we still need to add those extensions to zuul in such case?

By @Nikerabbit recommendation, I split change to translatewiki.net repo into two separate patches. The first one ( https://gerrit.wikimedia.org/r/#/c/400613 ) adds keyAlgorithm: legacy for groups if it was not specified and the second ( https://gerrit.wikimedia.org/r/#/c/400683 ) removes keyAlgorithm: simple because it is not needed anymore.

I checked MediaWiki Language Extension Bundle and Release workboards, however there is no next release task for MLEB, so I can't add needed information to release notes. I think we need to ask @Arrbee to create it?

And I pushed a second patch (to Translate extension) which changes default value keyAlgorithm to simple.

I just pushed a change to translatewiki.net repo. That patch removes keyAlgorithm: simple and adds keyAlgorithm: legacy (if it was not specified) for all groups which use GettextFFS class.

I will work on this migration!

By the way, I noticed that function onBlockIpComplete unintentionally creates new global function too. This will be also fixed in my patch.

I will fix this issue!