Fomafix (Fomafix)
User

Projects

Calendar

User Details

User Since: Oct 14 2014, 8:51 AM (509 w, 2 d)
Availability: Available
LDAP User: Unknown
MediaWiki User: Fomafix [ Global Accounts ]

Recent Activity
View All

Sun, Jul 14

Fomafix committed rEMEUdc7913aee11f: Update namespace of PHP classes and deprecated functions.

Update namespace of PHP classes and deprecated functions

Sun, Jul 14, 7:35 PM

Sat, Jul 13

Fomafix added a comment to T143189: [EPIC] Split MobileContext god object apart.

The service MobileFrontend.Context created by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/305212 (rEMFRf3cf72ba636f: Add MobileFrontend.Context service) is not a valid service because it depends on RequestContext::getMain().
In https://gerrit.wikimedia.org/g/mediawiki/core/+/80064365ac0c0809b0932bfde77f082727aced8c/includes/ServiceWiring.php#15 stands:

Services MUST NOT vary their behaviour on global state, especially not WebRequest, RequestContext (T218555).

Sat, Jul 13, 8:51 AM · Patch-For-Review, MobileFrontend, Web-Team-Backlog (Needs Prioritization (Tech)), MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Reading-Web-Sprint-79-Uh-oh, Technical-Debt, Epic

Tue, Jul 9

Fomafix renamed T187866: The language code 'no' is ignored in the HTTP header field Accept-Language from The language code 'no' is ignored in Accept-Language HTTP header to The language code 'no' is ignored in the HTTP header field Accept-Language.

Tue, Jul 9, 10:33 AM · Patch-For-Review, Language codes, MediaWiki-Installer, I18n, UniversalLanguageSelector

Fomafix claimed T187866: The language code 'no' is ignored in the HTTP header field Accept-Language.

Tue, Jul 9, 10:33 AM · Patch-For-Review, Language codes, MediaWiki-Installer, I18n, UniversalLanguageSelector

Fri, Jul 5

Fomafix committed rEPPR996a348e6470: Migrate from ILBFactory to IConnectionProvider.

Migrate from ILBFactory to IConnectionProvider

Fri, Jul 5, 6:41 PM

Fri, Jun 28

Fomafix committed rEPPR3160bbebca35: Inject services into SpecialPageProperties.

Inject services into SpecialPageProperties

Fri, Jun 28, 12:22 PM

Fomafix committed rEPPR6f339fd99a12: Remove PHP code for MediaWiki < 1.38.

Remove PHP code for MediaWiki < 1.38

Fri, Jun 28, 12:22 PM

Jun 13 2024

Fomafix committed rEMML5f18dae896a0: Return a Message object on SpecialEmailAddresses::getDescription().

Return a Message object on SpecialEmailAddresses::getDescription()

Jun 13 2024, 5:22 PM

Fomafix committed rEMMLb2b3ce8b7f40: Add missing dependencies.

Add missing dependencies

Jun 13 2024, 5:22 PM

Fomafix committed rEMML66c6932c4fd8: Use OutputPage::setPageTitleMsg to set page title messages.

Use OutputPage::setPageTitleMsg to set page title messages

Jun 13 2024, 4:42 PM

Jun 10 2024

Fomafix committed rEPHN0db09e4a689f: Use MainConfigNames for MainConfig variables.

Use MainConfigNames for MainConfig variables

Jun 10 2024, 2:28 PM

Fomafix committed rEPHNf390308a9026: Use PHP types.

Use PHP types

Jun 10 2024, 1:28 PM

Jun 9 2024

Fomafix added a comment to T366792: Extension TimedMediaHandler breaks extension Score.

In T366792#9873346, @Nardog hat geschrieben:

How is this different from T363630: Score audio cannot be played if the page has other embedded media?

Jun 9 2024, 6:10 PM · Patch-For-Review, MediaWiki-extensions-Score, TimedMediaHandler

Jun 8 2024

Fomafix committed rEISU8d9fd7757ae4: Use namespaced PHP classes.

Use namespaced PHP classes

Jun 8 2024, 7:41 PM

Jun 7 2024

Fomafix committed rEISU472506b44f4a: Use $this->getReplicaDB() instead of $this->getDB( DB_REPLICA ).

Use $this->getReplicaDB() instead of $this->getDB( DB_REPLICA )

Jun 7 2024, 10:21 AM

Jun 6 2024

Fomafix committed rEPHNde3c2c6377ec: Inject services into PhonosIPAFilePersistJob.

Inject services into PhonosIPAFilePersistJob

Jun 6 2024, 8:51 PM

Fomafix claimed T366792: Extension TimedMediaHandler breaks extension Score.

Jun 6 2024, 12:20 PM · Patch-For-Review, MediaWiki-extensions-Score, TimedMediaHandler

Fomafix created T366792: Extension TimedMediaHandler breaks extension Score.

Jun 6 2024, 12:02 PM · Patch-For-Review, MediaWiki-extensions-Score, TimedMediaHandler

May 23 2024

Fomafix committed rEPHN72c52c70f9af: Use namespaced PHP classes.

Use namespaced PHP classes

May 23 2024, 2:37 PM

May 20 2024

Fomafix added a comment to T290062: Deprecate parameter onlyroot.

Formally the removal of the parameter onlyroot is a breaking change, but the impact is just one expanded level of subcategories.

May 20 2024, 7:19 AM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-extensions-CategoryTree

May 19 2024

Fomafix added a comment to T290062: Deprecate parameter onlyroot.

In T290062#9760939, @Krinkle wrote:

What cost are we trading?
What is the benefit?

May 19 2024, 7:28 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-extensions-CategoryTree

May 16 2024

Fomafix closed T204830: Temporarily redirect sgs.wikipedia.org to bat-smg.wikipedia.org until bat-smg->sgs move can be done as Resolved.

May 16 2024, 1:06 PM · serviceops, Patch-For-Review, Wikimedia-Apache-configuration, Wikimedia-Site-requests

May 14 2024

Fomafix committed rEPHNa12bca68cf63: Use only one constructor for engines.

Use only one constructor for engines

May 14 2024, 9:03 PM

May 6 2024

Pppery awarded T290062: Deprecate parameter onlyroot a Dislike token.

May 6 2024, 4:45 AM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-extensions-CategoryTree

May 5 2024

Fomafix closed T211557: Bad interaction between RevisionSlider and CollapsibleVector extension as Resolved.

May 5 2024, 5:07 PM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-21, WMDE-TechWish, User-thiemowmde, Revision-Slider, Regression, MediaWiki-extensions-CollapsibleVector

May 1 2024

Fomafix added a comment to T290062: Deprecate parameter onlyroot.

According to what commit is it deprecated?

May 1 2024, 7:48 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-extensions-CategoryTree

Fomafix updated the task description for T290062: Deprecate parameter onlyroot.

May 1 2024, 7:47 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MediaWiki-extensions-CategoryTree

Apr 30 2024

Fomafix committed rEPEL3a9e286611e2: Update namespace of the PHP classes.

Update namespace of the PHP classes

Apr 30 2024, 6:06 PM

Apr 25 2024

Fomafix committed rEREMbea28914b405: Use PHP type hints.

Use PHP type hints

Apr 25 2024, 9:20 PM

Fomafix claimed T329348: wpuselivepreview are generate unlimited header link in link.

Apr 25 2024, 12:36 PM · MediaWiki-extensions-CollapsibleVector

Fomafix reopened T211557: Bad interaction between RevisionSlider and CollapsibleVector extension as "Open".

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CollapsibleVector/+/638100 uses the hook 'wikipage.categories' to trigger the collapsing again. This is bad, because this hook gets also triggered on every live preview. Therefor https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CollapsibleVector/+/1021554 reverts this change.

Apr 25 2024, 11:47 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-10-21, WMDE-TechWish, User-thiemowmde, Revision-Slider, Regression, MediaWiki-extensions-CollapsibleVector

Apr 22 2024

Fomafix committed rELISc617e83ec679: Use HookHandlers and implement hooks.

Use HookHandlers and implement hooks

Apr 22 2024, 10:02 PM

Fomafix committed rELIS1e9eba661ab6: Inject service UserOptionsManager into LinkSuggest.

Inject service UserOptionsManager into LinkSuggest

Apr 22 2024, 10:02 PM

Fomafix committed rEPPR80bdc1b9c30d: Remove unused parameters in PageProperties::wfGetDB.

Remove unused parameters in PageProperties::wfGetDB

Apr 22 2024, 10:51 AM

Apr 21 2024

Fomafix committed rEPPR63dfba5a46a0: Declare private properties.

Declare private properties

Apr 21 2024, 12:48 PM

Mar 24 2024

Fomafix committed rEISUcbe1b44e58ac: Remove unused file resources/ext.imageSuggestions/init.js.

Remove unused file resources/ext.imageSuggestions/init.js

Mar 24 2024, 5:09 PM

Fomafix committed rEISU03724eadd2e6: Use $this->getServiceContainer() in maintenance.

Use $this->getServiceContainer() in maintenance

Mar 24 2024, 5:09 PM

Mar 18 2024

Fomafix committed rEPHN61f78ecfc35b: Use MediaWikiIntegrationTestCase instead of TestCase.

Use MediaWikiIntegrationTestCase instead of TestCase

Mar 18 2024, 7:19 PM

Mar 11 2024

Fomafix committed rEDKM945445d460a6: Move the button styles in the same block.

Move the button styles in the same block

Mar 11 2024, 1:42 PM

Fomafix committed rEDKM2a509c9ac9fb: Fix tooltip.

Fix tooltip

Mar 11 2024, 1:42 PM

Fomafix committed rEDKM0ea5b97faaa8: Add missing module dependencies.

Add missing module dependencies

Mar 11 2024, 9:52 AM

Feb 15 2024

Fomafix committed rEPHN393596de9a28: Improve the links in the popup message.

Improve the links in the popup message

Feb 15 2024, 3:36 AM

Feb 10 2024

Fomafix committed rEREM4effbf74b7a5: Fix @param order.

Fix @param order

Feb 10 2024, 5:23 PM

Feb 9 2024

Fomafix committed rEREM2c5ffa5ffdfc: Add missing module dependencies.

Add missing module dependencies

Feb 9 2024, 2:44 AM

Feb 8 2024

Fomafix committed rEREMec3706082c44: Add dependency on module 'ext.RedirectManager.images'.

Add dependency on module 'ext.RedirectManager.images'

Feb 8 2024, 4:59 AM

Fomafix committed rEREMa1983f2c0258: Use selector in extension.json instead of JavaScript.

Use selector in extension.json instead of JavaScript

Feb 8 2024, 4:58 AM

Feb 7 2024

Fomafix added a comment to T334289: Special:CategoryTree switches mode by itself.

The bug description is about a specific bug which was accidental introduced by change rECTRaec8d75570fd: Replace WebRequest::getVal by ::getRawVal or ::getText. This bug gets fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CategoryTree/+/991038 PS1. But you blocked this change.

Feb 7 2024, 11:30 AM · Patch-For-Review, Regression, MediaWiki-extensions-CategoryTree

Feb 3 2024

Fomafix added a comment to T334289: Special:CategoryTree switches mode by itself.

@Jdlrobson: Is this still a regression?

Feb 3 2024, 9:20 AM · Patch-For-Review, Regression, MediaWiki-extensions-CategoryTree

Jan 26 2024

Fomafix committed rEREM08c91c942bf0: Add delete button to delete the redirect.

Add delete button to delete the redirect

Jan 26 2024, 11:09 AM

Jan 21 2024

Fomafix committed rEREMb32158322d2d: Use arrow function expressions.

Use arrow function expressions

Jan 21 2024, 12:11 AM

Jan 20 2024

Fomafix committed rEREMcc540bd209ff: Use .map() instead of .forEach().

Use .map() instead of .forEach()

Jan 20 2024, 5:23 PM

Fomafix committed rEREMc859b841838a: Give access to `this` by `.bind( this )`.

Give access to `this` by `.bind( this )`

Jan 20 2024, 3:08 PM

Jan 18 2024

Fomafix committed rEREMaa44a2b3a520: Delay text insertion until after closing the dialog.

Delay text insertion until after closing the dialog

Jan 18 2024, 1:20 AM

Fomafix committed rEREMe9ea863583fd: Remove redundant closure for the packageFiles module.

Remove redundant closure for the packageFiles module

Jan 18 2024, 1:20 AM

Jan 16 2024

Fomafix claimed T334289: Special:CategoryTree switches mode by itself.

This bug was introduced by the change rECTRaec8d75570fd: Replace WebRequest::getVal by ::getRawVal or ::getText.

Jan 16 2024, 4:24 PM · Patch-For-Review, Regression, MediaWiki-extensions-CategoryTree

Jan 12 2024

Fomafix committed rEREMc91dc23014fa: Use .map() instead of .forEach() to support multiple errors.

Use .map() instead of .forEach() to support multiple errors

Jan 12 2024, 5:48 AM

Jan 4 2024

Fomafix committed rEREM04cbb4e277ee: Add tooltips to the buttons.

Add tooltips to the buttons

Jan 4 2024, 3:20 AM

Fomafix committed rEREM7c1893d6fa84: Mark tag 'redirectmanager' as active software defined tag.

Mark tag 'redirectmanager' as active software defined tag

Jan 4 2024, 3:10 AM

Jan 2 2024

Fomafix committed rEREM5b8bd69fb8f1: Avoid Object.keys on array.

Avoid Object.keys on array

Jan 2 2024, 2:53 AM

Dec 30 2023

Fomafix committed rEREMd93f28345d88: Use ES6 syntax.

Use ES6 syntax

Dec 30 2023, 4:26 AM

Dec 16 2023

Fomafix closed T353373: Invalid URL for GNU General Public License on installer as Resolved.

Dec 16 2023, 4:38 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MediaWiki-Installer

Dec 14 2023

Fomafix updated the task description for T353373: Invalid URL for GNU General Public License on installer.

Dec 14 2023, 1:46 AM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MediaWiki-Installer

Dec 13 2023

Fomafix moved T353373: Invalid URL for GNU General Public License on installer from General to Web installer on the MediaWiki-Installer board.

Dec 13 2023, 9:24 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MediaWiki-Installer

Fomafix created T353373: Invalid URL for GNU General Public License on installer.

Dec 13 2023, 8:11 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MediaWiki-Installer

Dec 7 2023

Fomafix committed rERAC097a68325c67: Use namespaced classes.

Use namespaced classes

Dec 7 2023, 10:55 AM

Dec 6 2023

Fomafix committed rEREMecbe501e4050: Add dependency on module 'mediawiki.jqueryMsg'.

Add dependency on module 'mediawiki.jqueryMsg'

Dec 6 2023, 3:36 AM

Dec 4 2023

Fomafix committed rEREMe3278672a736: Use namespaced classes.

Use namespaced classes

Dec 4 2023, 12:33 PM

Fomafix committed rEREMe046412b12cc: Move the copyButton condition to the copyButton.

Move the copyButton condition to the copyButton

Dec 4 2023, 8:05 AM

Fomafix committed rEREM0eb485c54865: Use user interface language on server generated error messages.

Use user interface language on server generated error messages

Dec 4 2023, 2:33 AM

Fomafix committed rEREMa7fed6798454: SECURITY: Prevent possible JavaScript injection by stored message.

SECURITY: Prevent possible JavaScript injection by stored message

Dec 4 2023, 2:18 AM

Fomafix committed rEREM21fc8ae1be82: Use formatversion=2 on Api requests.

Use formatversion=2 on Api requests

Dec 4 2023, 1:41 AM

Dec 2 2023

Fomafix committed rEREMcfdce7104537: Use MediaWiki\ResourceLoader\ImageModule instead of ResourceLoaderImageModule.

Use MediaWiki\ResourceLoader\ImageModule instead of ResourceLoaderImageModule

Dec 2 2023, 9:18 AM

Fomafix committed rEREM2d877c262c31: Inject services.

Inject services

Dec 2 2023, 1:54 AM

Nov 18 2023

Fomafix committed rEPHNb225e0121701: Avoid empty <sup></sup> on missing file attribute.

Avoid empty <sup></sup> on missing file attribute

Nov 18 2023, 1:56 PM

Nov 17 2023

Fomafix added a comment to T350949: Play music requires a futher click on mobile browsers.

I tested with a iPhone SE3 with iOS 16.7.2, 30 MBit/s downstream and with mobile version and desktop version of the page. I can see the starting and stopping of loading animation, which takes a few 100 ms I guess.

Nov 17 2023, 2:15 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Browser-Support-Apple-Safari, MediaWiki-extensions-Phonos

Fomafix added a comment to T350949: Play music requires a futher click on mobile browsers.

The behavior on https://patchdemo.wmflabs.org/wikis/274381f11d/wiki/Hymne_der_Sowjetunion with a iPhone Safari is now slightly different:

Nov 17 2023, 10:34 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Browser-Support-Apple-Safari, MediaWiki-extensions-Phonos

Nov 16 2023

Fomafix added a comment to T350949: Play music requires a futher click on mobile browsers.

This issue is independent to T350369, because rEPHN365e80b9f580: Use static integers instead of OO.ui.Keys (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Phonos/+/973387/) is now deployed, but issue still exist.

Nov 16 2023, 10:02 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Browser-Support-Apple-Safari, MediaWiki-extensions-Phonos

Nov 13 2023

Fomafix committed rEPHNa2635a0de965: Rework PHP code.

Rework PHP code

Nov 13 2023, 12:08 PM

Nov 12 2023

Fomafix committed rEPHN365e80b9f580: Use static integers instead of OO.ui.Keys.

Use static integers instead of OO.ui.Keys

Nov 12 2023, 12:41 AM

Nov 11 2023

Fomafix added a comment to T350369: Errors in mw-client-NEW-errors TypeError: Cannot read properties of undefined (reading 'Keys').

modules/ext.phonos.init.js uses OO.ui.Keys. OO.ui.Keys is defined in module oojs-ui-core. In extension.json there is no dependency on this module. Therefor error can happen if the module in not loaded yet.

Nov 11 2023, 4:23 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Community-Tech (CommTech-Kanban), MediaWiki-extensions-Phonos