Page MenuHomePhabricator

wwen (William Wen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 1 2024, 4:19 PM (15 w, 2 d)
Availability
Available
Review Queue
0

Recent Activity

Thu, Aug 8

wwen added a comment to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.

Thanks for the review! We're already in contact with Ray so we're good on that front. I'll definitely add modifying the docs to my todo list.

Thu, Aug 8, 4:01 PM
wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Thu, Aug 8, 3:59 PM
wwen updated the diff for D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Thu, Aug 8, 3:59 PM

Wed, Aug 7

wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Wed, Aug 7, 4:23 PM
wwen requested review of D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Wed, Aug 7, 4:22 PM
wwen added a comment to D218749: Bug 1896836 - Round current time up in browser_timezone.js to nearest second to avoid intermittent failure. r=timhuang.

My theory about what happens here is that lastModified gets rounded up to the nearest second, then new Date() is called quick enough that it happens before the second is up. So, new Date() is smaller than lastModified and offset becomes -1.

Wed, Aug 7, 3:03 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen updated the diff for D218749: Bug 1896836 - Round current time up in browser_timezone.js to nearest second to avoid intermittent failure. r=timhuang.
Wed, Aug 7, 3:02 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen created D218749: Bug 1896836 - Round current time up in browser_timezone.js to nearest second to avoid intermittent failure. r=timhuang.
Wed, Aug 7, 2:55 PM · testing-exception-unchanged (Doesn't change behavior for users)

Wed, Jul 31

wwen added inline comments to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Wed, Jul 31, 7:44 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Wed, Jul 31, 7:40 PM

Tue, Jul 30

wwen added inline comments to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Tue, Jul 30, 2:19 PM

Mon, Jul 29

wwen added inline comments to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Mon, Jul 29, 7:35 PM
wwen requested review of D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Mon, Jul 29, 7:31 PM

Fri, Jul 26

wwen closed D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Fri, Jul 26, 12:22 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen committed rMOZILLACENTRALb109d9a3387c: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Bug 1904095 - Add tests for new permission manager functionality. r=pbz
Fri, Jul 26, 12:22 PM

Thu, Jul 25

wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Thu, Jul 25, 7:03 PM

Wed, Jul 24

wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Wed, Jul 24, 9:17 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Wed, Jul 24, 8:51 PM
wwen requested review of D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Wed, Jul 24, 3:09 PM
wwen updated the diff for D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Wed, Jul 24, 2:28 PM
wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Wed, Jul 24, 2:28 PM

Tue, Jul 23

wwen updated subscribers of D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Tue, Jul 23, 8:52 PM
wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Tue, Jul 23, 8:48 PM
wwen updated the diff for D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Tue, Jul 23, 8:48 PM

Fri, Jul 19

wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Fri, Jul 19, 4:29 PM
wwen updated the diff for D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Fri, Jul 19, 4:29 PM
wwen added inline comments to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Fri, Jul 19, 3:12 PM
wwen updated the diff for D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Fri, Jul 19, 3:08 PM
wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Fri, Jul 19, 3:08 PM

Thu, Jul 18

wwen closed D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Thu, Jul 18, 4:02 PM · testing-approved
wwen committed rMOZILLACENTRALe99b663d79f5: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI..
Bug 1880230 - Added support for private browsing only widgets in CustomizableUI.
Thu, Jul 18, 4:02 PM
wwen requested review of D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Thu, Jul 18, 3:55 PM · testing-approved

Jul 17 2024

wwen planned changes to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 17 2024, 6:29 PM · testing-approved
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 17 2024, 6:29 PM · testing-approved
wwen planned changes to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 17 2024, 6:20 PM · testing-approved
wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Jul 17 2024, 6:18 PM
wwen updated the diff for D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Jul 17 2024, 6:18 PM
wwen planned changes to D216830: WIP: Bug 1908099 - Add prototype message for GPC onboarding. r=manuel.
Jul 17 2024, 3:49 PM

Jul 12 2024

wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 12 2024, 3:33 PM · testing-approved
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 12 2024, 3:28 PM · testing-approved
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 12 2024, 3:22 PM · testing-approved

Jul 11 2024

wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 11 2024, 7:26 PM · testing-approved
wwen closed D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 11 2024, 2:37 PM · testing-approved
wwen committed rMOZILLACENTRALb44ee81f22b7: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI..
Bug 1880230 - Added support for private browsing only widgets in CustomizableUI.
Jul 11 2024, 2:37 PM

Jul 10 2024

wwen requested review of D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 10 2024, 2:29 PM · testing-exception-unchanged (Doesn't change behavior for users)

Jul 9 2024

wwen added a comment to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.

Thanks for the review and no worries about any delays! This is more of a backlog bug fix anyway.

Jul 9 2024, 8:22 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 9 2024, 8:01 PM
wwen added inline comments to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 9 2024, 7:48 PM
wwen added inline comments to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 9 2024, 7:46 PM

Jul 8 2024

wwen updated the diff for D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 8 2024, 9:46 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen added inline comments to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 8 2024, 9:28 PM
wwen requested review of D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 8 2024, 9:24 PM
wwen updated the diff for D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 8 2024, 3:36 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen added inline comments to D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 8 2024, 3:22 PM · testing-exception-unchanged (Doesn't change behavior for users)

Jul 4 2024

wwen added inline comments to D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 4 2024, 7:36 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen requested review of D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 4 2024, 7:33 PM · testing-exception-unchanged (Doesn't change behavior for users)

Jul 3 2024

wwen planned changes to D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jul 3 2024, 9:20 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen added a comment to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.

Paul, can you see if the approach to this bug is okay?

Jul 3 2024, 6:36 PM
wwen requested review of D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:19 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:16 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:16 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:08 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:08 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:07 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:07 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:02 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 6:02 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 5:48 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 5:48 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 3:49 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 3:49 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 3:40 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jul 3 2024, 3:40 PM
wwen added inline comments to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 3 2024, 1:54 PM · testing-approved

Jul 2 2024

wwen added a comment to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.

Also, a clean profile doesn't start in the default state. If I restore to default in the customize toolbar menu, a new import bookmarks button pops up. Is this intended behaviour? This also shows up on central so I don't believe it is related to this change.

Jul 2 2024, 8:39 PM · testing-approved
wwen added inline comments to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 2 2024, 8:19 PM · testing-approved
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jul 2 2024, 7:20 PM · testing-approved

Jun 29 2024

wwen closed D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 29 2024, 3:19 AM · testing-approved
wwen committed rMOZILLACENTRAL7f2beff76748: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI..
Bug 1880230 - Added support for private browsing only widgets in CustomizableUI.
Jun 29 2024, 3:19 AM

Jun 28 2024

wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jun 28 2024, 8:09 PM
wwen updated the diff for D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jun 28 2024, 8:09 PM
wwen planned changes to D215233: Bug 1767271 - Add new permission for shutdown exceptions. r=pbz.
Jun 28 2024, 5:45 PM

Jun 26 2024

wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 26 2024, 1:45 PM · testing-approved

Jun 25 2024

wwen requested review of D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jun 25 2024, 7:36 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 25 2024, 2:12 PM · testing-approved

Jun 24 2024

wwen planned changes to D214729: Bug 1904095 - Add tests for new permission manager functionality. r=pbz.
Jun 24 2024, 4:13 PM · testing-exception-unchanged (Doesn't change behavior for users)
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 24 2024, 3:48 PM · testing-approved
wwen added a comment to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.

As far as I can tell, your solution of adding API widgets works well. Waiting on a try build to see if it breaks anything else but it's looking good from my manual testing.

Jun 24 2024, 3:46 PM · testing-approved
wwen requested review of D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 24 2024, 3:44 PM · testing-approved
wwen planned changes to D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 24 2024, 3:39 PM · testing-approved
wwen updated the diff for D209857: Bug 1880230 - Added support for private browsing only widgets in CustomizableUI. r=hsohaney.
Jun 24 2024, 3:39 PM · testing-approved
wwen closed D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 24 2024, 3:25 PM · testing-approved
wwen committed rMOZILLACENTRALd85a0c432b59: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz
Jun 24 2024, 3:24 PM
wwen updated the diff for D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 24 2024, 1:55 PM · testing-approved

Jun 21 2024

wwen updated the diff for D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 21 2024, 11:15 PM · testing-approved
wwen updated the diff for D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 21 2024, 9:08 PM · testing-approved
wwen updated the diff for D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 21 2024, 8:28 PM · testing-approved
wwen added a comment to D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.

Bug for adding tests: https://bugzilla.mozilla.org/show_bug.cgi?id=1904095

Jun 21 2024, 4:44 PM · testing-approved
wwen updated the diff for D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 21 2024, 4:37 PM · testing-approved
wwen updated the diff for D212057: Bug 1658094 - Add new cleaner for "cookie" permissions. r=pbz.
Jun 21 2024, 4:23 PM · testing-approved