User Details
- User Since
- May 1 2024, 4:19 PM (15 w, 2 d)
- Availability
- Available
- Review Queue
- 0
Thu, Aug 8
Thanks for the review! We're already in contact with Ray so we're good on that front. I'll definitely add modifying the docs to my todo list.
Wed, Aug 7
My theory about what happens here is that lastModified gets rounded up to the nearest second, then new Date() is called quick enough that it happens before the second is up. So, new Date() is smaller than lastModified and offset becomes -1.
Wed, Jul 31
Tue, Jul 30
Mon, Jul 29
Fri, Jul 26
Thu, Jul 25
Wed, Jul 24
Tue, Jul 23
Fri, Jul 19
Thu, Jul 18
Jul 17 2024
Jul 12 2024
Jul 11 2024
Jul 10 2024
Jul 9 2024
Thanks for the review and no worries about any delays! This is more of a backlog bug fix anyway.
Jul 8 2024
Jul 4 2024
Jul 3 2024
Paul, can you see if the approach to this bug is okay?
Jul 2 2024
Also, a clean profile doesn't start in the default state. If I restore to default in the customize toolbar menu, a new import bookmarks button pops up. Is this intended behaviour? This also shows up on central so I don't believe it is related to this change.
Jun 29 2024
Jun 28 2024
Jun 26 2024
Jun 25 2024
Jun 24 2024
As far as I can tell, your solution of adding API widgets works well. Waiting on a try build to see if it breaks anything else but it's looking good from my manual testing.
Jun 21 2024
Bug for adding tests: https://bugzilla.mozilla.org/show_bug.cgi?id=1904095