code review 6061043: cmd/gc: fix addresses escaping through closures called ...

cmd/gc: fix addresses escaping through closures called in-place.

Fixes issue 3545.

[lvd, 2012-04-18 13:56:18]

Hello [email protected] (cc: [email protected]),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-04-23 19:15:21]

LGTM

I added a bunch more tests to escape2.go.
Will submit.

[rsc, 2012-04-23 19:42:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=a890477d3dfb ***

cmd/gc: fix addresses escaping through closures called in-place.

Fixes issue 3545.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6061043

Committer: Russ Cox <[email protected]>

http://codereview.appspot.com/6061043/diff/4001/test/escape2.go
File test/escape2.go (right):

http://codereview.appspot.com/6061043/diff/4001/test/escape2.go#newcode1069
test/escape2.go:1069: func foo124(x **int) {	// ERROR "does not escape"
Please put the variable names in these patterns, like above.  In theory there is
just one thing on each line, but it's safer to be explicit.

Also, please make a foo124a with x = p where x is the global var x *int instead
of a function parameter.

http://codereview.appspot.com/6061043/diff/4001/test/escape2.go#newcode1077
test/escape2.go:1077: func foo125(ch chan *int) {	// ERROR "does not escape"
Please make a foo125a variant with defer func instead of just func.

http://codereview.appspot.com/6061043/diff/4001/test/escape2.go#newcode1090
test/escape2.go:1090: // px = &i  // would escape i-> should move to heap, as
should the one below
Confusing.  Delete.

[lvd, 2012-04-23 20:03:43]

thanks

On Mon, Apr 23, 2012 at 21:42, <[email protected]> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=a890477d3dfb<http://code.google...
>
>
> cmd/gc: fix addresses escaping through closures called in-place.
>
> Fixes issue 3545.
>
> R=rsc
> CC=golang-dev
> http://codereview.appspot.com/**6061043<http://codereview.appspot.com/6061043>
>
> Committer: Russ Cox <[email protected]>
>
>
>
>
http://codereview.appspot.com/**6061043/diff/4001/test/**escape2.go<http://co...
> File test/escape2.go (right):
>
> http://codereview.appspot.com/**6061043/diff/4001/test/**
>
escape2.go#newcode1069<http://codereview.appspot.com/6061043/diff/4001/test/escape2.go#newcode1069>
> test/escape2.go:1069: func foo124(x **int) {    // ERROR "does not escape"
> Please put the variable names in these patterns, like above.  In theory
> there is just one thing on each line, but it's safer to be explicit.
>
> Also, please make a foo124a with x = p where x is the global var x *int
> instead of a function parameter.
>
> http://codereview.appspot.com/**6061043/diff/4001/test/**
>
escape2.go#newcode1077<http://codereview.appspot.com/6061043/diff/4001/test/escape2.go#newcode1077>
> test/escape2.go:1077: func foo125(ch chan *int) {       // ERROR "does not
> escape"
> Please make a foo125a variant with defer func instead of just func.
>
> http://codereview.appspot.com/**6061043/diff/4001/test/**
>
escape2.go#newcode1090<http://codereview.appspot.com/6061043/diff/4001/test/escape2.go#newcode1090>
> test/escape2.go:1090: // px = &i  // would escape i-> should move to
> heap, as should the one below
> Confusing.  Delete.
>
>
http://codereview.appspot.com/**6061043/<http://codereview.appspot.com/6061043/>
>