Skip to content

K001, K002, K003: do not round() values of main metrics (calls, total_time, rows); use integers when float is not needed.

Calls:

  • 1.14K – important info is hidden. We must not round the value here, we need exact value of the integer number.

Total time:

  • 1ms/sec or 0s/sec – important info is hidden. We must not round the value here, we need exact value of the float number. (1.23 ms/sec or 0.23 ms/sec)

Rows:

  • 19.77K – important info is hidden. We must not round the value here, we need exact value of the integer number.

shared_blks_hit, shared_blks_read, etc

  • 52.84M blks – important info is hidden. We must not round the value here, we need exact value of the integer number. As for differentiated values, it is okay to have non-exact value like 392.18K blks/sec.

Acceptance criteria

  • in Calls column, instead of 1.14K I see 1140256 (better: 1,140,256)
  • in Total time (and kcache_user_time_ms, kcache_system_time), instead of 1ms/sec I see 1.51 ms/sec. Instead of 0s/sec I see 0.23 ms/sec.
  • instead of 7.00 blks I see 7 blks
  • in Rows: instead of 19.77K I see 19774012 (better: 19,774,012)
  • in shared_blks_hit and others: instead of 52.84M blks I see 52840656 blks (better: 52,840,656 blks)
Edited by Nikolay Samokhvalov