Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter failing to run for some PRs #2252

Open
dstillman opened this issue Sep 23, 2020 · 1 comment
Open

Linter failing to run for some PRs #2252

dstillman opened this issue Sep 23, 2020 · 1 comment

Comments

@dstillman
Copy link
Member

@adomasven:

https://travis-ci.com/github/dstillman/translators/builds/186128798

Error: Command failed: git diff --name-status master
fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

I did a rebase against master before pushing — not sure if that mattered.

@adomasven
Copy link
Member

adomasven commented Sep 23, 2020

This is the linter failing. The translator tests didn't run.

0.00s$ [[ "$TRAVIS_PULL_REQUEST" != "false" ]] && cd pull-request-check && ./check-pull-request.sh || true
The command "[[ "$TRAVIS_PULL_REQUEST" != "false" ]] && cd pull-request-check && ./check-pull-request.sh || true" exited with 0.

I'm not sure why $TRAVIS_PULL_REQUEST == "false" though for a PR.

@dstillman dstillman changed the title Translator check still failing for some PRs Linter failing to run for some PRs Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants