Skip to content

Commit 2e310e1

Browse files
dfandrichptitSeb
authored andcommitted
test1474: make precheck more robust on non-Solaris systems
If uname -r returns something odd, perl could return an error code and the test would be erroneously skipped. The qx// syntax avoid this. Followup to 08f9b21
1 parent 99f1f0a commit 2e310e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/data/test1474

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ HTTP PUT with Expect: 100-continue and 417 response during upload
8989
http://%HOSTIP:%HTTPPORT/we/want/%TESTNUMBER -T %LOGDIR/test%TESTNUMBER.txt --limit-rate 64K --expect100-timeout 0.001
9090
</command>
9191
<precheck>
92-
perl -e "print 'Test does not work on this BSD system' if ( $^O eq 'netbsd' || $^O eq 'openbsd' || ($^O eq 'solaris' && `uname -r` * 100 <= 510));"
92+
perl -e "print 'Test does not work on this BSD system' if ( $^O eq 'netbsd' || $^O eq 'openbsd' || ($^O eq 'solaris' && qx/uname -r/ * 100 <= 510));"
9393
</precheck>
9494
# Must be large enough to trigger curl's automatic 100-continue behaviour
9595
<file name="%LOGDIR/test%TESTNUMBER.txt">

0 commit comments

Comments
 (0)