Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: udapi/udapi-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: udapi/udapi-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refactor-corefud-delete
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Apr 15, 2024

  1. refactor corefud.Delete 

    It may be subjective, but I find this easier to understand the code.
    @martinpopel
    martinpopel committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c28dfd3 View commit details
    Browse the repository at this point in the history

  2. corefud.Delete bugfix: Functor may refere even to nodes outside DEPS

    @martinpopel
    martinpopel committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a2dc301 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. simplify the corefud.Delete code by using deps instead of raw_deps 

    Fix node.raw_deps, so that it always sorts and removes duplicates,
so that the output CoNLL-U files are valid.
Add tests.
    @martinpopel
    martinpopel committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    07864f9 View commit details
    Browse the repository at this point in the history
Loading