Deprecated/Removed constant used

[famfo]

After upgrading from v4.x to v5.x, davis no longer started due to:

Uncaught Error: Undefined constant Symfony\Component\HttpFoundation\Request::HEADER_X_FORWARDED_ALL in public/index.php:24

HEADER_X_FORWARDED_ALL seems to be deprecated and now removed, I had to replace it with HEADER_X_FORWARDED_FOR in my installation. HEADER_X_FORWARDED_ALL seems to include HEADER_X_FORWARDED_FOR, HEADER_X_FORWARDED_HOST, HEADER_X_FORWARDED_PORT and HEADER_X_FORWARDED_PROTO.

Here is my patch for this, I am not familiar with PHP and the other headers though, that's why I'm not opening a PR.

 if ($trustedProxies = $_SERVER['TRUSTED_PROXIES'] ?? false) {
-    Request::setTrustedProxies(explode(',', $trustedProxies), Request::HEADER_X_FORWARDED_ALL ^ Request::HEADER_X_FORWARDED_HOST);
+    Request::setTrustedProxies(explode(',', $trustedProxies), Request::HEADER_X_FORWARDED_FOR ^ Request::HEADER_X_FORWARDED_HOST);
 }

[tchapi]

Thanks @famfo for your report.

Can you indicate on what PHP version (and reverse proxy) you are?

[famfo]

php version: 8.3.16
reverse proxy is caddy: v2.9.1

[tchapi]

Thank you; This is weird as it's working on my side, but you're right that the index file is lagging in terms of version, I'll look to update it asap

[famfo]

I ran composer update after updating the version, that may have updated some part of symfony to an incompatible version

[tchapi]

Probably fixed in #177 — could you try that everything works on your side with this branch?

Thanks a lot!

[famfo]

That seems to have fixed it, thanks ^^

[tchapi]

Merged in master now :)

I'll try to make a release before end of week