Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine fromAsync as “built-in async function” #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

js-choi
Copy link
Collaborator

@js-choi js-choi commented Apr 5, 2025

This tweaks the spec to use the new “built-in async function” machinery in tc39/ecma262#2942. It resolves #43. See also #31, #36.

  • It uses the same “This async method performs the following steps when called” language as proposal-async-iterator-helpers.
  • It replaces returning Completion Records with direct returning of array values, which are now implicitly wrapped in Completion Records by the definition of built-in async function objects.
  • It removes the wrapping async Abstract Closure, which is now implicitly defined by the definition of built-in async function objects.
  • It tweaks the ending note to match the language in Array.from’s note.
  • It lastly updates ecmarkup to v21.2.0 and ecma262-biblio to v2.1.2869.

This is the last step before creating a pull request to tc39/ecma262. We’re almost there.

@nicolo-ribaudo, @ljharb, since you reviewed it before for Stage 13 (#14), would you mind reviewing before we merge this?

@js-choi js-choi requested review from nicolo-ribaudo and ljharb April 5, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redefine fromAsync as “built-in async function”
2 participants