Skip to content

Modified AsyncBlockStart to accept Abstract Closure #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

Modified AsyncBlockStart to accept Abstract Closure #26

merged 1 commit into from
Jul 11, 2022

Conversation

Aditi-1400
Copy link
Contributor

Modified AsyncBlockStart to accept either a parse node or an Abstract Closure with no parameters.
This fixes #24

@js-choi js-choi requested a review from ljharb February 4, 2022 13:20
@js-choi
Copy link
Collaborator

js-choi commented Feb 4, 2022

Looks good to me right now.

CC reviewer: @nicolo-ribaudo.

ljharb
ljharb approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@js-choi js-choi merged commit 233339e into tc39:main Jul 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ljharb ljharb ljharb approved these changes

@bakkot bakkot bakkot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec: AsyncFunctionStart does not accept closure argument
4 participants
@Aditi-1400 @js-choi @ljharb @bakkot