Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: AsyncFunctionStart does not accept closure argument #24

Closed
js-choi opened this issue Feb 2, 2022 · 1 comment · Fixed by #26
Closed

Spec: AsyncFunctionStart does not accept closure argument #24

js-choi opened this issue Feb 2, 2022 · 1 comment · Fixed by #26
Labels
bug Something isn't working

Comments

@js-choi
Copy link
Collaborator

js-choi commented Feb 2, 2022

Step 4 of the specification currently says:

Perform AsyncFunctionStart(promiseCapability, fromAsyncClosure).

This is an error. AsyncFunctionStart, which in turn calls AsyncBlockStart, expects its second argument to be a Parse Node.

We might want first to call CreateBuiltinFunction on fromAsyncClosure or something.

This issue was discovered by Aditi Singh of Igalia.
@js-choi js-choi added the bug Something isn't working label Feb 2, 2022
@bakkot
Copy link
Contributor

bakkot commented Feb 2, 2022

You can change AsyncBlockStart to accept either a parse node or an Abstract Closure with no parameters. That's what GeneratorStart does.

@Aditi-1400 Aditi-1400 mentioned this issue Feb 3, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modified AsyncBlockStart to accept Abstract Closure Aditi-1400/proposal-array-from-async
2 participants
@js-choi @bakkot