Skip to content

[DX] Improving documentation when multiple languages are possible #4229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajanssens opened this issue Sep 15, 2014 · 5 comments
Closed

[DX] Improving documentation when multiple languages are possible #4229

ajanssens opened this issue Sep 15, 2014 · 5 comments

Comments

@ajanssens
Copy link

Symfony 2 comes with a lot of possibilities when it comes to configuration : YAML, XML or plain old PHP.
We also have sometimes the choice to use Annotations. As for the templating there's Twig and PHP.

Most of the time documentation is well referenced with every languages but there's still a few pages where we can only find YML when XML and PHP are possible like this one : http://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/routing.html

I've made a PR (sensiolabs/SensioFrameworkExtraBundle#325) to cover a few gaps but, by example, I don't really know how to set "type Annotation" from an import in PHP.

Here is some other pages when languages are missing :

http://symfony.com/doc/current/book/propel.html : config.yml only, then XML for schema. I'm not using Propel but i'm asking myself : can't I use YAML here ? Or even Annotations ?

http://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html#creating-a-converter : In this one converter service only in YAML and XML. PHP is missing.

I think there's a bit more of them. A really few, I'd like this DX Issue to be a first move to track this pages down and fill the gaps :)

@stof
Copy link
Member

stof commented Sep 15, 2014

All these places are occuring in doc provided in external repos. This issue has already been fixed for the main symfony documentation a few months ago by ensuring we have all formats everywhere.
the right thing to do is to contribute to each repo to add the missing formats.

but, by example, I don't really know how to set "type Annotation" from an import in PHP.

The Loader::import method receives the type as its second argument

@xabbuh
Copy link
Member

xabbuh commented Sep 15, 2014

@stof Actually, the Propel chapter is part of the book.

@stof
Copy link
Member

stof commented Sep 15, 2014

hmm, indeed

@wouterj
Copy link
Member

wouterj commented Sep 15, 2014

The propel book does only show configuration snippets from app/config/parameters.yml. It doesn't make sense to use other formats there (we don't do that in other places in the docs too).

Afaik, you can only use XML when configuring Propel or did that change in the past? If this is correct, the propel book does not miss anything.

@wouterj
Copy link
Member

wouterj commented May 2, 2015

Closing as the Propel book is going to be removed (#4900) and the other examples are from third party bundles, which should be fixed and reported in their repository. I'm almost 100% sure that the core docs documents every format everywhere.

@wouterj wouterj closed this as completed May 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants