Turned return type annotations of private methods into php return types.

Author: derrabus

Diff for: Application.php

@@ -1030,10 +1030,8 @@ protected function getDefaultHelperSet()
 
     /**
      * Returns abbreviated suggestions in string format.
-     *
-     * @return string A formatted string of abbreviated suggestions
      */
-    private function getAbbreviationSuggestions(array $abbrevs)
+    private function getAbbreviationSuggestions(array $abbrevs): string
     {
         return '    '.implode("\n    ", $abbrevs);
     }
@@ -1062,7 +1060,7 @@ public function extractNamespace($name, $limit = null)
      *
      * @return string[] A sorted array of similar string
      */
-    private function findAlternatives(string $name, iterable $collection)
+    private function findAlternatives(string $name, iterable $collection): array
     {
         $threshold = 1e3;
         $alternatives = [];
@@ -1175,7 +1173,7 @@ private function splitStringByWidth(string $string, int $width)
      *
      * @return string[] The namespaces of the command
      */
-    private function extractAllNamespaces(string $name)
+    private function extractAllNamespaces(string $name): array
     {
         // -1 as third argument is needed to skip the command short name when exploding
         $parts = explode(':', $name, -1);

Diff for: Command/LockableTrait.php

@@ -29,10 +29,8 @@ trait LockableTrait
 
     /**
      * Locks a command.
-     *
-     * @return bool
      */
-    private function lock(string $name = null, bool $blocking = false)
+    private function lock(string $name = null, bool $blocking = false): bool
     {
         if (!class_exists(SemaphoreStore::class)) {
             throw new LogicException('To enable the locking feature you must install the symfony/lock component.');

Diff for: Descriptor/JsonDescriptor.php

@@ -100,10 +100,7 @@ private function writeData(array $data, array $options)
         $this->write(json_encode($data, $flags));
     }
 
-    /**
-     * @return array
-     */
-    private function getInputArgumentData(InputArgument $argument)
+    private function getInputArgumentData(InputArgument $argument): array
     {
         return [
             'name' => $argument->getName(),
@@ -114,10 +111,7 @@ private function getInputArgumentData(InputArgument $argument)
         ];
     }
 
-    /**
-     * @return array
-     */
-    private function getInputOptionData(InputOption $option)
+    private function getInputOptionData(InputOption $option): array
     {
         return [
             'name' => '--'.$option->getName(),
@@ -130,10 +124,7 @@ private function getInputOptionData(InputOption $option)
         ];
     }
 
-    /**
-     * @return array
-     */
-    private function getInputDefinitionData(InputDefinition $definition)
+    private function getInputDefinitionData(InputDefinition $definition): array
     {
         $inputArguments = [];
         foreach ($definition->getArguments() as $name => $argument) {
@@ -148,10 +139,7 @@ private function getInputDefinitionData(InputDefinition $definition)
         return ['arguments' => $inputArguments, 'options' => $inputOptions];
     }
 
-    /**
-     * @return array
-     */
-    private function getCommandData(Command $command)
+    private function getCommandData(Command $command): array
     {
         $command->getSynopsis();
         $command->mergeApplicationDefinition(false);

Diff for: Helper/DebugFormatterHelper.php

@@ -107,10 +107,7 @@ public function stop($id, $message, $successful, $prefix = 'RES')
         return $message;
     }
 
-    /**
-     * @return string
-     */
-    private function getBorder(string $id)
+    private function getBorder(string $id): string
     {
         return sprintf('<bg=%s> </>', $this->colors[$this->started[$id]['border']]);
     }

Diff for: Input/StringInput.php

@@ -40,11 +40,9 @@ public function __construct(string $input)
     /**
      * Tokenizes a string.
      *
-     * @return array An array of tokens
-     *
      * @throws InvalidArgumentException When unable to parse input (should never happen)
      */
-    private function tokenize(string $input)
+    private function tokenize(string $input): array
     {
         $tokens = [];
         $length = \strlen($input);

Diff for: Output/ConsoleOutput.php

@@ -125,10 +125,8 @@ protected function hasStderrSupport()
     /**
      * Checks if current executing environment is IBM iSeries (OS400), which
      * doesn't properly convert character-encodings between ASCII to EBCDIC.
-     *
-     * @return bool
      */
-    private function isRunningOS400()
+    private function isRunningOS400(): bool
     {
         $checks = [
             \function_exists('php_uname') ? php_uname('s') : '',

Diff for: Question/ConfirmationQuestion.php

@@ -35,10 +35,8 @@ public function __construct(string $question, bool $default = true, string $true
 
     /**
      * Returns the default answer normalizer.
-     *
-     * @return callable
      */
-    private function getDefaultNormalizer()
+    private function getDefaultNormalizer(): callable
     {
         $default = $this->getDefault();
         $regex = $this->trueAnswerRegex;

Diff for: Terminal.php

@@ -85,7 +85,7 @@ private static function initDimensions()
      *
      * @return int[]|null An array composed of the width and the height or null if it could not be parsed
      */
-    private static function getConsoleMode()
+    private static function getConsoleMode(): ?array
     {
         $info = self::readFromProcess('mode CON');
 
@@ -98,20 +98,13 @@ private static function getConsoleMode()
 
     /**
      * Runs and parses stty -a if it's available, suppressing any error output.
-     *
-     * @return string|null
      */
-    private static function getSttyColumns()
+    private static function getSttyColumns(): ?string
     {
         return self::readFromProcess('stty -a | grep columns');
     }
 
-    /**
-     * @param string $command
-     *
-     * @return string|null
-     */
-    private static function readFromProcess($command)
+    private static function readFromProcess(string $command): ?string
     {
         if (!\function_exists('proc_open')) {
             return null;