From 516f4c92792ae0452d93b96f63694bae65d72a30 Mon Sep 17 00:00:00 2001 From: Kyle Conroy Date: Sat, 2 Apr 2022 22:55:12 -0700 Subject: [PATCH] fix(bundler): Only close multipart writer once --- internal/bundler/upload.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/bundler/upload.go b/internal/bundler/upload.go index 8f09f8562c..556fb79423 100644 --- a/internal/bundler/upload.go +++ b/internal/bundler/upload.go @@ -41,22 +41,20 @@ func (up *Uploader) Validate() error { func (up *Uploader) buildRequest(ctx context.Context, result map[string]string) (*http.Request, error) { body := bytes.NewBuffer([]byte{}) - w := multipart.NewWriter(body) - defer w.Close() if err := writeInputs(w, up.configPath, up.config); err != nil { return nil, err } if err := writeOutputs(w, up.dir, result); err != nil { return nil, err } - w.Close() - + if err := w.Close(); err != nil { + return nil, err + } req, err := http.NewRequest("POST", "https://api.sqlc.dev/upload", body) if err != nil { return nil, err } - // Set sqlc-version header req.Header.Set("Content-Type", w.FormDataContentType()) req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", up.token))