Fix #1417 Change socket mode ping/pong from debug to trace

seratch · seratch · commit bdf235db7307 · 2025-01-14T13:25:00.000+09:00
diff --git a/slack-api-client/src/main/java/com/slack/api/socket_mode/impl/SocketModeClientJavaWSImpl.java b/slack-api-client/src/main/java/com/slack/api/socket_mode/impl/SocketModeClientJavaWSImpl.java
@@ -130,15 +130,15 @@ public void connect() {
     public boolean verifyConnection() {
         if (this.currentSession != null && this.currentSession.isOpen()) {
             try {
-                if (getLogger().isDebugEnabled()) {
-                    getLogger().debug("Sending a ping message");
+                if (getLogger().isTraceEnabled()) {
+                    getLogger().trace("Sending a ping message");
                 }
                 this.currentSession.sendPing();
                 long waitMillis = 0L;
                 while (waitMillis <= 3_000L) {
                     if (this.currentSession.isPongReceived()) {
-                        if (getLogger().isDebugEnabled()) {
-                            getLogger().debug("Received a pong message");
+                        if (getLogger().isTraceEnabled()) {
+                            getLogger().trace("Received a pong message");
                         }
                         return true;
                     }
@@ -152,8 +152,8 @@ public boolean verifyConnection() {
                         e.getMessage()
                 );
             }
-            if (getLogger().isDebugEnabled()) {
-                getLogger().debug("Failed to receive a pong message");
+            if (getLogger().isTraceEnabled()) {
+                getLogger().trace("Failed to receive a pong message");
             }
         }
         return false;
diff --git a/slack-api-client/src/main/java/com/slack/api/socket_mode/impl/SocketModeClientTyrusImpl.java b/slack-api-client/src/main/java/com/slack/api/socket_mode/impl/SocketModeClientTyrusImpl.java
@@ -187,8 +187,8 @@ public void connect() {
     public boolean verifyConnection() {
         if (this.currentSession != null && this.currentSession.isOpen()) {
             String ping = "ping-pong_" + currentSession.getId();
-            if (getLogger().isDebugEnabled()) {
-                getLogger().debug("Sending a ping message: {}", ping);
+            if (getLogger().isTraceEnabled()) {
+                getLogger().trace("Sending a ping message: {}", ping);
             }
             ByteBuffer pingBytes = ByteBuffer.wrap(ping.getBytes());
             try {
@@ -199,8 +199,8 @@ public boolean verifyConnection() {
                 while (waitMillis <= 3_000L) {
                     String pong = latestPong.getAndSet(null);
                     if (pong != null && pong.equals(ping)) {
-                        if (getLogger().isDebugEnabled()) {
-                            getLogger().debug("Received a pong message: {}", ping);
+                        if (getLogger().isTraceEnabled()) {
+                            getLogger().trace("Received a pong message: {}", ping);
                         }
                         return true;
                     }
@@ -213,8 +213,8 @@ public boolean verifyConnection() {
                         this.currentSession.getId(),
                         e.getMessage());
             }
-            if (getLogger().isDebugEnabled()) {
-                getLogger().debug("Failed to receive a pong message: {}", ping);
+            if (getLogger().isTraceEnabled()) {
+                getLogger().trace("Failed to receive a pong message: {}", ping);
             }
         }
         return false;
diff --git a/slack-jakarta-socket-mode-client/src/main/java/com/slack/api/jakarta_socket_mode/impl/JakartaSocketModeClientTyrusImpl.java b/slack-jakarta-socket-mode-client/src/main/java/com/slack/api/jakarta_socket_mode/impl/JakartaSocketModeClientTyrusImpl.java
@@ -187,8 +187,8 @@ public void connect() {
     public boolean verifyConnection() {
         if (this.currentSession != null && this.currentSession.isOpen()) {
             String ping = "ping-pong_" + currentSession.getId();
-            if (getLogger().isDebugEnabled()) {
-                getLogger().debug("Sending a ping message: {}", ping);
+            if (getLogger().isTraceEnabled()) {
+                getLogger().trace("Sending a ping message: {}", ping);
             }
             ByteBuffer pingBytes = ByteBuffer.wrap(ping.getBytes());
             try {
@@ -199,8 +199,8 @@ public boolean verifyConnection() {
                 while (waitMillis <= 3_000L) {
                     String pong = latestPong.getAndSet(null);
                     if (pong != null && pong.equals(ping)) {
-                        if (getLogger().isDebugEnabled()) {
-                            getLogger().debug("Received a pong message: {}", ping);
+                        if (getLogger().isTraceEnabled()) {
+                            getLogger().trace("Received a pong message: {}", ping);
                         }
                         return true;
                     }
@@ -213,8 +213,8 @@ public boolean verifyConnection() {
                         this.currentSession.getId(),
                         e.getMessage());
             }
-            if (getLogger().isDebugEnabled()) {
-                getLogger().debug("Failed to receive a pong message: {}", ping);
+            if (getLogger().isTraceEnabled()) {
+                getLogger().trace("Failed to receive a pong message: {}", ping);
             }
         }
         return false;

Original file line number	Diff line number	Diff line change
`@@ -130,15 +130,15 @@ public void connect() {`
`130`	`130`	`public boolean verifyConnection() {`
`131`	`131`	`if (this.currentSession != null && this.currentSession.isOpen()) {`
`132`	`132`	`try {`
`133`		`- if (getLogger().isDebugEnabled()) {`
`134`		`- getLogger().debug("Sending a ping message");`
	`133`	`+ if (getLogger().isTraceEnabled()) {`
	`134`	`+ getLogger().trace("Sending a ping message");`
`135`	`135`	`}`
`136`	`136`	`this.currentSession.sendPing();`
`137`	`137`	`long waitMillis = 0L;`
`138`	`138`	`while (waitMillis <= 3_000L) {`
`139`	`139`	`if (this.currentSession.isPongReceived()) {`
`140`		`- if (getLogger().isDebugEnabled()) {`
`141`		`- getLogger().debug("Received a pong message");`
	`140`	`+ if (getLogger().isTraceEnabled()) {`
	`141`	`+ getLogger().trace("Received a pong message");`
`142`	`142`	`}`
`143`	`143`	`return true;`
`144`	`144`	`}`
`@@ -152,8 +152,8 @@ public boolean verifyConnection() {`
`152`	`152`	`e.getMessage()`
`153`	`153`	`);`
`154`	`154`	`}`
`155`		`- if (getLogger().isDebugEnabled()) {`
`156`		`- getLogger().debug("Failed to receive a pong message");`
	`155`	`+ if (getLogger().isTraceEnabled()) {`
	`156`	`+ getLogger().trace("Failed to receive a pong message");`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`	`return false;`
Original file line number	Diff line number	Diff line change
`@@ -187,8 +187,8 @@ public void connect() {`
`187`	`187`	`public boolean verifyConnection() {`
`188`	`188`	`if (this.currentSession != null && this.currentSession.isOpen()) {`
`189`	`189`	`String ping = "ping-pong_" + currentSession.getId();`
`190`		`- if (getLogger().isDebugEnabled()) {`
`191`		`- getLogger().debug("Sending a ping message: {}", ping);`
	`190`	`+ if (getLogger().isTraceEnabled()) {`
	`191`	`+ getLogger().trace("Sending a ping message: {}", ping);`
`192`	`192`	`}`
`193`	`193`	`ByteBuffer pingBytes = ByteBuffer.wrap(ping.getBytes());`
`194`	`194`	`try {`
`@@ -199,8 +199,8 @@ public boolean verifyConnection() {`
`199`	`199`	`while (waitMillis <= 3_000L) {`
`200`	`200`	`String pong = latestPong.getAndSet(null);`
`201`	`201`	`if (pong != null && pong.equals(ping)) {`
`202`		`- if (getLogger().isDebugEnabled()) {`
`203`		`- getLogger().debug("Received a pong message: {}", ping);`
	`202`	`+ if (getLogger().isTraceEnabled()) {`
	`203`	`+ getLogger().trace("Received a pong message: {}", ping);`
`204`	`204`	`}`
`205`	`205`	`return true;`
`206`	`206`	`}`
`@@ -213,8 +213,8 @@ public boolean verifyConnection() {`
`213`	`213`	`this.currentSession.getId(),`
`214`	`214`	`e.getMessage());`
`215`	`215`	`}`
`216`		`- if (getLogger().isDebugEnabled()) {`
`217`		`- getLogger().debug("Failed to receive a pong message: {}", ping);`
	`216`	`+ if (getLogger().isTraceEnabled()) {`
	`217`	`+ getLogger().trace("Failed to receive a pong message: {}", ping);`
`218`	`218`	`}`
`219`	`219`	`}`
`220`	`220`	`return false;`