Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sshd/terminal: Upstream changes to golang.org/x/term #381

Open
shazow opened this issue Mar 26, 2021 · 2 comments
Open

sshd/terminal: Upstream changes to golang.org/x/term #381

shazow opened this issue Mar 26, 2021 · 2 comments

Comments

@shazow
Copy link
Owner

shazow commented Mar 26, 2021

We have some important changes in our local fork of golang.org/x/term (formerly x/crypto/terminal), need to upstream them.

@abitrolly
Copy link

@shazow so where to put this commit? Seems to relate to getSize call. However, I am not sure why getSize is not sufficient?

https://cs.opensource.google/go/x/term/+/refs/tags/v0.25.0:term_unix.go;l=59-65

@shazow
Copy link
Owner Author

shazow commented Nov 5, 2024

@abitrolly getSize returns the size of the window. We need the width of a character/string. The commit includes a test that needs to pass, so could run it to see if it has been fixed upstream. I haven't checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants