Skip to content

Commit b63d64b

Browse files
committed
Updated linter
1 parent a17dfb8 commit b63d64b

File tree

6 files changed

+15
-11
lines changed

6 files changed

+15
-11
lines changed

client/.eslintrc.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ rules:
2121
# Good idea, but let's go to flow before fixing all these
2222
react/forbid-prop-types: 0
2323

24+
# arrow-parens:
25+
# - 0
26+
# - "as-needed"
27+
2428
settings:
2529
import/resolver:
2630
webpack:

client/app/bundles/comments/actions/commentsActionCreators.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ export function fetchComments() {
4747
return (
4848
requestsManager
4949
.fetchEntities()
50-
.then((res) => dispatch(fetchCommentsSuccess(res.data)))
51-
.catch((error) => dispatch(fetchCommentsFailure(error)))
50+
.then(res => dispatch(fetchCommentsSuccess(res.data)))
51+
.catch(error => dispatch(fetchCommentsFailure(error)))
5252
);
5353
};
5454
}
@@ -59,8 +59,8 @@ export function submitComment(comment) {
5959
return (
6060
requestsManager
6161
.submitEntity({ comment })
62-
.then((res) => dispatch(submitCommentSuccess(res.data)))
63-
.catch((error) => dispatch(submitCommentFailure(error)))
62+
.then(res => dispatch(submitCommentSuccess(res.data)))
63+
.catch(error => dispatch(submitCommentFailure(error)))
6464
);
6565
};
6666
}

client/app/bundles/comments/components/CommentBox/CommentList/CommentList.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default class CommentList extends BaseComponent {
3535

3636
render() {
3737
const { $$comments, cssTransitionGroupClassNames } = this.props;
38-
const commentNodes = $$comments.map(($$comment) =>
38+
const commentNodes = $$comments.map($$comment =>
3939

4040
// `key` is a React-specific concept and is not mandatory for the
4141
// purpose of this tutorial. if you're curious, see more here:

client/app/bundles/comments/components/SimpleCommentScreen/SimpleCommentScreen.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ export default class SimpleCommentScreen extends BaseComponent {
3131
return (
3232
request
3333
.get('comments.json', { responseType: 'json' })
34-
.then((res) => this.setState({ $$comments: Immutable.fromJS(res.data.comments) }))
35-
.catch((error) => this.setState({ fetchCommentsError: error }))
34+
.then(res => this.setState({ $$comments: Immutable.fromJS(res.data.comments) }))
35+
.catch(error => this.setState({ fetchCommentsError: error }))
3636
);
3737
}
3838

@@ -57,7 +57,7 @@ export default class SimpleCommentScreen extends BaseComponent {
5757
isSaving: false,
5858
});
5959
})
60-
.catch((error) => {
60+
.catch(error => {
6161
this.setState({
6262
submitCommentError: error,
6363
isSaving: false,

client/app/bundles/comments/reducers/commentsReducer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ export default function commentsReducer($$state = $$initialState, action = null)
3333
}
3434

3535
case actionTypes.SUBMIT_COMMENT_SUCCESS: {
36-
return $$state.withMutations((state) => (
36+
return $$state.withMutations(state => (
3737
state
3838
.updateIn(
3939
['$$comments'],
40-
($$comments) => $$comments.unshift(Immutable.fromJS(comment))
40+
$$comments => $$comments.unshift(Immutable.fromJS(comment))
4141
)
4242
.merge({
4343
submitCommentError: null,

client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
"chai": "^3.5.0",
9595
"chai-immutable": "^1.6.0",
9696
"eslint": "^3.9.1",
97-
"eslint-config-shakacode": "^13.0.0",
97+
"eslint-config-shakacode": "^13.0.1-beta.1",
9898
"eslint-import-resolver-webpack": "^0.7.0",
9999
"eslint-plugin-import": "^2.0.1",
100100
"eslint-plugin-jsx-a11y": "^2.2.3",

0 commit comments

Comments
 (0)