Conversation
… to access this ref will fail. Did you mean to use React.forwardRef()? 🐞 fix: 修复 Warning: validateDOMNesting(...): <div> cannot appear as a child of <table>.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request contains multiple fixes and improvements to the ScriptCat browser extension, primarily focusing on Monaco Editor configuration, UI component enhancements, and code organization.
Key Changes
- Enhanced Monaco Editor configuration with TypeScript compiler options and hover tooltips for script metadata
- Improved React component handling with proper ref forwarding and accessibility features
- Added Monaco Editor registration to the install page for consistent editor behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pkg/utils/monaco-editor/index.ts | Added script metadata tooltips, improved regex pattern matching, and enhanced TypeScript compiler options |
| src/pkg/utils/monaco-editor/config.ts | Added allowNonTsExtensions flag to fix Monaco Editor source file errors |
| src/pages/options/routes/ScriptList.tsx | Improved DraggableContainer with proper ref forwarding and accessibility features |
| src/pages/install/main.tsx | Added Monaco Editor registration for consistent editor functionality |
| src/pages/components/CodeEditor/index.tsx | Enhanced diff editor with hideUnchangedRegions and improved dispose handling |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CodFrm
reviewed
Sep 5, 2025
| resource: "引入资源文件", | ||
| require: "引入外部 js 文件", | ||
| noframes: "表示脚本不运行在`<frame>`中", | ||
| definition: "ScriptCat特有功能：一个`.d.ts`文件的引用地址,能够自动补全编辑器的自动提示", |
Member
|
感谢🙏 |
Collaborator
|
PR #733 退回 DraggableContainer 的 |
Collaborator
|
标题说 「修复N个问题」 |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.