Conversation
Member
|
IconHome 我觉得没啥问题，而且这么久了，不用变更吧 🙏，感谢哥哥，我看看 |
Collaborator
IconSettings 比較合理 |
Member
|
说实话，换成 setting 后，我倒是有点不习惯 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由于都是细微的调整，所以没有分成多个 PR。
IconHome图标替换成IconSettings，和 Violentmonkey、Tampermonkey 保持一致，也和设置界面的 URL（/src/options.html）保持语义上的一致，避免用户误以为是项目主页（https://docs.scriptcat.org/）。margin-right，避免右侧按钮在hover状态下的background和开关相连。开启脚本标签和对应的开关过于分散，反而使前一个ScriptListItem的开关和后一个ScriptListItem的标签更加接近，造成视觉上的困惑。