Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the extension available for the VS Live Share web client #199

Closed
heksesang opened this issue Apr 14, 2021 · 6 comments · Fixed by #200
Closed

Make the extension available for the VS Live Share web client #199

heksesang opened this issue Apr 14, 2021 · 6 comments · Fixed by #200
Labels
enhancement New feature or request

Comments

@heksesang
Copy link

Currently it's not possible to get Scala syntax highlighting in the web client of Live Share sessions, because this extension is not declared as a web extension.

It would be nice to fix that. :)

@nicolasstucki nicolasstucki added the enhancement New feature or request label Apr 14, 2021
@nicolasstucki
Copy link
Contributor

@heksesang do you know the location of the documentation of how to declare as a web extension?

@nicolasstucki
Copy link
Contributor

My guess is that we need to change the manifest but there is nothing that looks like this in https://code.visualstudio.com/api/references/extension-manifest

@nicolasstucki
Copy link
Contributor

[2021-04-14 11:32:47.885] [window] [error] Error: Cannot install 'Scala Syntax (official)' because this extension is not a web extension.
    at E.installFromGallery (https://vscodeweb.azureedge.net/stable/3c4e3df9e89829dce27b7b5c24508306b151f30d/out/vs/workbench/workbench.web.api.js?v=2:1531:39644)
    at async Promise.all (index 0)
    at async Object.G [as settled] (https://vscodeweb.azureedge.net/stable/3c4e3df9e89829dce27b7b5c24508306b151f30d/out/vs/workbench/workbench.web.api.js?v=2:68:20994)
[2021-04-14 11:32:47.917] [window] [error] Cannot install 'Scala Syntax (official)' because this extension is not a web extension.: Error: Cannot install 'Scala Syntax (official)' because this extension is not a web extension.
    at E.installFromGallery (https://vscodeweb.azureedge.net/stable/3c4e3df9e89829dce27b7b5c24508306b151f30d/out/vs/workbench/workbench.web.api.js?v=2:1531:39644)
    at async Promise.all (index 0)
    at async Object.G [as settled] (https://vscodeweb.azureedge.net/stable/3c4e3df9e89829dce27b7b5c24508306b151f30d/out/vs/workbench/workbench.web.api.js?v=2:68:20994)

nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Apr 14, 2021
This feature is not officially supported yet. See microsoft/vscode#111043

Fixes scala#199
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Apr 14, 2021
This feature is not officially supported yet. See microsoft/vscode#111043

Fixes scala#199
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Apr 14, 2021
This feature is not officially supported yet. See microsoft/vscode#111043

Fixes scala#199
nicolasstucki added a commit to nicolasstucki/vscode-scala-syntax that referenced this issue Apr 14, 2021
This feature is not officially supported yet. See microsoft/vscode#111043

Fixes scala#199
@nicolasstucki
Copy link
Contributor

The fix in #200 did not work. That solution used an undocumented feature (see microsoft/vscode#111043).

@heksesang
Copy link
Author

There is now added some documentation for Web Extensions authoring here: https://code.visualstudio.com/api/extension-guides/web-extensions

@nicolasstucki
Copy link
Contributor

It looks like we do not need to do any changes. This extension currently works on Live Share and GitHub.dev. I installed it on both of those and they have worked without any issues.

PanAeon pushed a commit to PanAeon/vscode-scala-syntax that referenced this issue Apr 28, 2022
This feature is not officially supported yet. See microsoft/vscode#111043

Fixes scala#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants