-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Standardize on //> using
in tests.
#18149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
//> using
in tests.
To be fair, But, pedantics aside, I'm strongly in favour! |
Ah yes, I mis-spoke. It's just that I came across |
(Scala 2: scala/scala#10405) |
There are test-only pragmas that it would be nice to adopt or make standard, such as to express "this test should be run only under certain JVM versions" (as opposed to requesting a specific JVM version). Maybe just a tweak such as
or maybe support for test tags or groups. I haven't used The colon syntax in dotty supports:
|
- update remaining `// scalac:` to `//> using options` in tests - throw error when using old syntax in tests fixes `scalac:` portion of #18149 still to do: - rewrite `// test: -jvm 15+` to use a directive - support `// scalajs: --skip` with a directive or similar once this is done, we can remove the `toolArg` regex
Is this issue solved by #18413? |
I intended to follow up about the other use cases for jvm version and sjs skipping. I'll look later today, for some reason I recently had the browser tab open. |
Tests currently use the
// scala: ...
syntax to add an option to the compilation. Example:// scalac: -Wunused:privates
They should be using
//> using
instead. We should reinforce conventions rather than creating alternative ones.I think this would be a good issue for the spree.
The text was updated successfully, but these errors were encountered: