Skip to content

Scalastyle config for "Scala Style Guide" #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evis opened this issue Nov 10, 2017 · 6 comments
Open

Scalastyle config for "Scala Style Guide" #924

evis opened this issue Nov 10, 2017 · 6 comments
Labels

Comments

@evis
Copy link
Contributor

evis commented Nov 10, 2017

It would be so nice to have scalastyle config for this guide. This way we could enforce these rules in Scala projects automatically.

@bzitzow
Copy link

bzitzow commented Feb 27, 2018

+1

@SethTisue
Copy link
Member

SethTisue commented Feb 27, 2018

or Scalafmt

@jvican
Copy link
Member

jvican commented Feb 28, 2018

@evis mind sending a PR?

@SethTisue
Copy link
Member

SethTisue commented Feb 28, 2018

Perhaps Scalafmt's default configuration already is mostly consistent with the guide? And the same for Scalastyle? In other words, perhaps this is essentially already done...?

thinking out loud, but: I wonder if a way to improve the guide would be, in each section of the guide, add a sort of footnote or info box that says what from that section is currently enforced by scalastyle and/or scalafmt. or maybe that level of detail isn't necessary, I don't know.

in any case, it's not clear to me what is actually actionable on this ticket.

@evis
Copy link
Contributor Author

evis commented Mar 1, 2018

mind sending a PR?

I thought about it, for sure. I tried to make scalastyle config for guide, but found a lot of guide conventions, which aren't covered by standard scalastyle rules. So, we need to implement these scalastyle rules. Or just make partial config, which doesn't cover all style conventions suggested by guide.

Perhaps Scalafmt's default configuration already is mostly consistent with the guide?

Not sure, will check it.

And the same for Scalastyle?

Definitely not, see above.

in each section of the guide, add a sort of footnote or info box that says what from that section is currently enforced by scalastyle and/or scalafmt. or maybe that level of detail isn't necessary, I don't know. in any case, it's not clear to me what is actually actionable on this ticket.

That level isn't really necessary imo. I'd like to just have link to scalastyle (scalafmt too?) config, which encorces style described in guide.

@evis
Copy link
Contributor Author

evis commented Mar 8, 2018

One may check incomplete scalastyle config here: https://github.com/evis/scala-style-guide-enforce/blob/master/scalastyle_config.xml

There are still 29 TODOs, though, due to lack of corresponding scalastyle implemented rules... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants