-
Notifications
You must be signed in to change notification settings - Fork 1k
Scalastyle config for "Scala Style Guide" #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 |
or Scalafmt |
@evis mind sending a PR? |
Perhaps Scalafmt's default configuration already is mostly consistent with the guide? And the same for Scalastyle? In other words, perhaps this is essentially already done...? thinking out loud, but: I wonder if a way to improve the guide would be, in each section of the guide, add a sort of footnote or info box that says what from that section is currently enforced by scalastyle and/or scalafmt. or maybe that level of detail isn't necessary, I don't know. in any case, it's not clear to me what is actually actionable on this ticket. |
I thought about it, for sure. I tried to make scalastyle config for guide, but found a lot of guide conventions, which aren't covered by standard scalastyle rules. So, we need to implement these scalastyle rules. Or just make partial config, which doesn't cover all style conventions suggested by guide.
Not sure, will check it.
Definitely not, see above.
That level isn't really necessary imo. I'd like to just have link to scalastyle (scalafmt too?) config, which encorces style described in guide. |
One may check incomplete scalastyle config here: https://github.com/evis/scala-style-guide-enforce/blob/master/scalastyle_config.xml There are still 29 TODOs, though, due to lack of corresponding scalastyle implemented rules... :( |
It would be so nice to have scalastyle config for this guide. This way we could enforce these rules in Scala projects automatically.
The text was updated successfully, but these errors were encountered: